From f06dde4fa35be40a2347f5a19a0efbe4ba06bfd9 Mon Sep 17 00:00:00 2001 From: Matthew Jones Date: Thu, 17 Apr 2014 10:14:47 -0400 Subject: [PATCH] Fix AC-1202... when marking a schedule as inactive also mark it as disabled. When filtering schedules for what should run make sure we exclude inactive schedules also --- awx/main/models/schedules.py | 2 +- awx/main/models/unified_jobs.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/awx/main/models/schedules.py b/awx/main/models/schedules.py index 4b82f03f6f..61675306c0 100644 --- a/awx/main/models/schedules.py +++ b/awx/main/models/schedules.py @@ -23,7 +23,7 @@ __all__ = ['Schedule'] class ScheduleFilterMethods(object): def enabled(self, enabled=True): - return self.filter(enabled=enabled) + return self.filter(enabled=enabled, active=enabled) def before(self, dt): return self.filter(next_run__lt=dt) diff --git a/awx/main/models/unified_jobs.py b/awx/main/models/unified_jobs.py index 7c4f808f63..f10f238041 100644 --- a/awx/main/models/unified_jobs.py +++ b/awx/main/models/unified_jobs.py @@ -190,6 +190,8 @@ class UnifiedJobTemplate(PolymorphicModel, CommonModelNameNotUnique): ''' for schedule in self.schedules.filter(active=True): schedule.mark_inactive() + schedule.enabled = False + schedule.save() super(UnifiedJobTemplate, self).mark_inactive(save=save) def save(self, *args, **kwargs): @@ -423,7 +425,7 @@ class UnifiedJob(PolymorphicModel, PasswordFieldsModel, CommonModelNameNotUnique @classmethod def _get_task_class(cls): raise NotImplementedError # Implement in subclasses. - + @classmethod def _get_parent_field_name(cls): return 'unified_job_template' # Override in subclasses.