External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-03-11 06:29:31 -02:30
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3874 from jbradberry/expose-role-type

Browse Source 
Expose the content type associated with roles for ActivityStream objects in the API

Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
This commit is contained in:
softwarefactory-project-zuul[bot]
2019-05-17 18:06:38 +00:00
committed by GitHub
parent ab1e45d6c4 3579584ffc
commit f174902bb2
2 changed files with 39 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
awx/api/serializers.py
View File

@@ -4955,7 +4955,10 @@ class InstanceGroupSerializer(BaseSerializer):
class ActivityStreamSerializer(BaseSerializer): class ActivityStreamSerializer(BaseSerializer):
changes = serializers.SerializerMethodField() changes = serializers.SerializerMethodField()
object_association = serializers.SerializerMethodField() object_association = serializers.SerializerMethodField(
help_text=_("When present, shows the field name of the role or relationship that changed."))
object_type = serializers.SerializerMethodField(
help_text=_("When present, shows the model on which the role or relationship was defined."))
@cached_property @cached_property
def _local_summarizable_fk_fields(self): def _local_summarizable_fk_fields(self):
@@ -4980,8 +4983,8 @@ class ActivityStreamSerializer(BaseSerializer):
class Meta: class Meta:
model = ActivityStream model = ActivityStream
fields = ('*', '-name', '-description', '-created', '-modified', fields = ('*', '-name', '-description', '-created', '-modified', 'timestamp', 'operation',
'timestamp', 'operation', 'changes', 'object1', 'object2', 'object_association') 'changes', 'object1', 'object2', 'object_association', 'object_type')
def get_fields(self): def get_fields(self):
ret = super(ActivityStreamSerializer, self).get_fields() ret = super(ActivityStreamSerializer, self).get_fields()
@@ -5024,6 +5027,21 @@ class ActivityStreamSerializer(BaseSerializer):
logger.debug('Failed to parse activity stream relationship type {}'.format(obj.object_relationship_type)) logger.debug('Failed to parse activity stream relationship type {}'.format(obj.object_relationship_type))
return "" return ""
def get_object_type(self, obj):
if not obj.object_relationship_type:
return ""
elif obj.object_relationship_type.endswith('_role'):
return camelcase_to_underscore(obj.object_relationship_type.rsplit('.', 2)[-2])
# default case: these values look like
# "awx.main.models.organization.Organization_notification_templates_success"
# so we have to take after the last period but before the first underscore.
try:
cls = obj.object_relationship_type.rsplit('.', 1)[0]
return camelcase_to_underscore(cls.split('_', 1))
except Exception:
logger.debug('Failed to parse activity stream relationship type {}'.format(obj.object_relationship_type))
return ""
def get_related(self, obj): def get_related(self, obj):
rel = {} rel = {}
if obj.actor is not None: if obj.actor is not None:

26
awx/ui/client/src/activity-stream/factories/build-description.factory.js
View File

@@ -17,6 +17,16 @@ export default function BuildDescription(BuildAnchor, $log, i18n) {
switch(activity.object_association){ switch(activity.object_association){
// explicit role dis+associations // explicit role dis+associations
case 'role': case 'role':
var object1 = activity.object1;
var object2 = activity.object2;
// if object1 winds up being the role's resource, we need to swap the objects
// in order to make the sentence make sense.
if (activity.object_type === object1) {
object1 = activity.object2;
object2 = activity.object1;
}
// object1 field is resource targeted by the dis+association // object1 field is resource targeted by the dis+association
// object2 field is the resource the role is inherited from // object2 field is the resource the role is inherited from
// summary_field.role[0] contains ref info about the role // summary_field.role[0] contains ref info about the role
@@ -24,23 +34,23 @@ export default function BuildDescription(BuildAnchor, $log, i18n) {
// expected outcome: "disassociated <object2> role_name from <object1>" // expected outcome: "disassociated <object2> role_name from <object1>"
case 'disassociate': case 'disassociate':
if (isGroupRelationship(activity)){ if (isGroupRelationship(activity)){
activity.description += BuildAnchor(activity.summary_fields.group[1], activity.object2, activity) + activity.summary_fields.role[0].role_field + activity.description += BuildAnchor(activity.summary_fields.group[1], object2, activity) + activity.summary_fields.role[0].role_field +
' from ' + BuildAnchor(activity.summary_fields.group[0], activity.object1, activity); ' from ' + BuildAnchor(activity.summary_fields.group[0], object1, activity);
} }
else{ else{
activity.description += BuildAnchor(activity.summary_fields[activity.object2][0], activity.object2, activity) + activity.summary_fields.role[0].role_field + activity.description += BuildAnchor(activity.summary_fields[object2][0], object2, activity) + activity.summary_fields.role[0].role_field +
' from ' + BuildAnchor(activity.summary_fields[activity.object1][0], activity.object1, activity); ' from ' + BuildAnchor(activity.summary_fields[object1][0], object1, activity);
} }
break; break;
// expected outcome: "associated <object2> role_name to <object1>" // expected outcome: "associated <object2> role_name to <object1>"
case 'associate': case 'associate':
if (isGroupRelationship(activity)){ if (isGroupRelationship(activity)){
activity.description += BuildAnchor(activity.summary_fields.group[1], activity.object2, activity) + activity.summary_fields.role[0].role_field + activity.description += BuildAnchor(activity.summary_fields.group[1], object2, activity) + activity.summary_fields.role[0].role_field +
' to ' + BuildAnchor(activity.summary_fields.group[0], activity.object1, activity); ' to ' + BuildAnchor(activity.summary_fields.group[0], object1, activity);
} }
else{ else{
activity.description += BuildAnchor(activity.summary_fields[activity.object2][0], activity.object2, activity) + activity.summary_fields.role[0].role_field + activity.description += BuildAnchor(activity.summary_fields[object2][0], object2, activity) + activity.summary_fields.role[0].role_field +
' to ' + BuildAnchor(activity.summary_fields[activity.object1][0], activity.object1, activity); ' to ' + BuildAnchor(activity.summary_fields[object1][0], object1, activity);
} }
break; break;
} }