External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-03-06 11:11:07 -03:30
Code Issues Packages Projects Releases Wiki Activity

All job template launches now require a credential, so we'll pass this along

Browse Source
This commit is contained in:
Matthew Jones
2014-12-11 16:24:12 -05:00
parent c2c47328df
commit f52cf37200
1 changed files with 26 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
awx/main/tests/jobs.py
View File

@@ -449,6 +449,11 @@ class BaseJobTestMixin(BaseTestMixin):
from awx.main.tests.tasks import (TEST_SSH_KEY_DATA, from awx.main.tests.tasks import (TEST_SSH_KEY_DATA,
TEST_SSH_KEY_DATA_LOCKED, TEST_SSH_KEY_DATA_LOCKED,
TEST_SSH_KEY_DATA_UNLOCK) TEST_SSH_KEY_DATA_UNLOCK)
self.cred_sue = self.user_sue.credentials.create(
username='sue',
password=TEST_SSH_KEY_DATA,
created_by=self.user_sue,
)
self.cred_bob = self.user_bob.credentials.create( self.cred_bob = self.user_bob.credentials.create(
username='bob', username='bob',
password='ASK', password='ASK',
@@ -947,6 +952,7 @@ class JobTemplateTest(BaseJobTestMixin, django.test.TestCase):
inventory = self.inv_eng.pk, inventory = self.inv_eng.pk,
project = self.proj_dev.pk, project = self.proj_dev.pk,
playbook = self.proj_dev.playbooks[0], playbook = self.proj_dev.playbooks[0],
credential = self.cred_sue.pk,
survey_enabled = True, survey_enabled = True,
) )
with self.current_user(self.user_sue): with self.current_user(self.user_sue):
@@ -1021,6 +1027,14 @@ class JobTemplateTest(BaseJobTestMixin, django.test.TestCase):
job_type = PERM_INVENTORY_DEPLOY, job_type = PERM_INVENTORY_DEPLOY,
inventory = self.inv_eng.pk, inventory = self.inv_eng.pk,
project = self.proj_dev.pk, project = self.proj_dev.pk,
credential = self.cred_sue.pk,
playbook = self.proj_dev.playbooks[0],
)
data_no_cred = dict(
name = 'launched job template no credential',
job_type = PERM_INVENTORY_DEPLOY,
inventory = self.inv_eng.pk,
project = self.proj_dev.pk,
playbook = self.proj_dev.playbooks[0], playbook = self.proj_dev.playbooks[0],
) )
with self.current_user(self.user_sue): with self.current_user(self.user_sue):
@@ -1032,6 +1046,15 @@ class JobTemplateTest(BaseJobTestMixin, django.test.TestCase):
launch_url = reverse('api:job_template_launch', launch_url = reverse('api:job_template_launch',
args=(response['id'],)) args=(response['id'],))
# You can still post the job template without a credential, just can't launch it without one
with self.current_user(self.user_sue):
response = self.post(url, data_no_cred, expect=201)
detail_url = reverse('api:job_template_detail',
args=(response['id'],))
self.assertEquals(response['url'], detail_url)
no_launch_url = reverse('api:job_template_launch',
args=(response['id'],))
# Invalid auth can't trigger the launch endpoint # Invalid auth can't trigger the launch endpoint
self.check_invalid_auth(launch_url, {}, methods=('post',)) self.check_invalid_auth(launch_url, {}, methods=('post',))
@@ -1045,6 +1068,9 @@ class JobTemplateTest(BaseJobTestMixin, django.test.TestCase):
j = Job.objects.get(pk=response['job']) j = Job.objects.get(pk=response['job'])
self.assertTrue(j.status == 'new') self.assertTrue(j.status == 'new')
# Can't launch a job template without a credential defined
with self.current_user(self.user_sue):
response = self.post(no_launch_url, {}, expect=400)
class JobTest(BaseJobTestMixin, django.test.TestCase): class JobTest(BaseJobTestMixin, django.test.TestCase):