External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-02-26 15:36:04 -03:30
Code Issues Packages Projects Releases Wiki Activity

Add comment to explain why we resolve the promises sequentially

Browse Source
This commit is contained in:
Marliana Lara
2021-06-24 15:32:33 -04:00
committed by Shane McDonald
parent 162ea776fd
commit f541fe9904
4 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
awx/ui_next/src/api/mixins/InstanceGroups.mixin.js
View File

@@ -30,6 +30,7 @@ const InstanceGroupsMixin = parent =>
async orderInstanceGroups(resourceId, current, original) { async orderInstanceGroups(resourceId, current, original) {
/* eslint-disable no-await-in-loop, no-restricted-syntax */ /* eslint-disable no-await-in-loop, no-restricted-syntax */
// Resolve Promises sequentially to maintain order and avoid race condition
if (!isEqual(current, original)) { if (!isEqual(current, original)) {
for (const group of original) { for (const group of original) {
await this.disassociateInstanceGroup(resourceId, group.id); await this.disassociateInstanceGroup(resourceId, group.id);

1
awx/ui_next/src/screens/Inventory/InventoryAdd/InventoryAdd.jsx
View File

@@ -24,6 +24,7 @@ function InventoryAdd() {
...remainingValues, ...remainingValues,
}); });
/* eslint-disable no-await-in-loop, no-restricted-syntax */ /* eslint-disable no-await-in-loop, no-restricted-syntax */
// Resolve Promises sequentially to maintain order and avoid race condition
for (const group of instanceGroups) { for (const group of instanceGroups) {
await InventoriesAPI.associateInstanceGroup(inventoryId, group.id); await InventoriesAPI.associateInstanceGroup(inventoryId, group.id);
} }

1
awx/ui_next/src/screens/Inventory/SmartInventoryAdd/SmartInventoryAdd.jsx
View File

@@ -20,6 +20,7 @@ function SmartInventoryAdd() {
} = await InventoriesAPI.create(values); } = await InventoriesAPI.create(values);
/* eslint-disable no-await-in-loop, no-restricted-syntax */ /* eslint-disable no-await-in-loop, no-restricted-syntax */
// Resolve Promises sequentially to maintain order and avoid race condition
for (const group of groupsToAssociate) { for (const group of groupsToAssociate) {
await InventoriesAPI.associateInstanceGroup(invId, group.id); await InventoriesAPI.associateInstanceGroup(invId, group.id);
} }

1
awx/ui_next/src/screens/Template/JobTemplateAdd/JobTemplateAdd.jsx
View File

@@ -65,6 +65,7 @@ function JobTemplateAdd() {
async function submitInstanceGroups(templateId, addedGroups = []) { async function submitInstanceGroups(templateId, addedGroups = []) {
/* eslint-disable no-await-in-loop, no-restricted-syntax */ /* eslint-disable no-await-in-loop, no-restricted-syntax */
// Resolve Promises sequentially to maintain order and avoid race condition
for (const group of addedGroups) { for (const group of addedGroups) {
await JobTemplatesAPI.associateInstanceGroup(templateId, group.id); await JobTemplatesAPI.associateInstanceGroup(templateId, group.id);
} }