diff --git a/awx/api/serializers.py b/awx/api/serializers.py index 5e5d1b6934..7a81a06def 100644 --- a/awx/api/serializers.py +++ b/awx/api/serializers.py @@ -1651,12 +1651,6 @@ class CredentialSerializerCreate(CredentialSerializer): fields = ('*', 'user', 'team', 'organization') def create(self, validated_data): - ''' - Special cases are processed for creating a credential. Fields of - user, team, and organization are allowed, and if given, roles are - automatically created for these. This is only used for list-create - view. - ''' # Remove the user, team, and organization processed in view for field in ['user', 'team', 'organization']: validated_data.pop(field, None) diff --git a/awx/main/tests/functional/api/test_credential.py b/awx/main/tests/functional/api/test_credential.py index 165f3a1547..a272328b34 100644 --- a/awx/main/tests/functional/api/test_credential.py +++ b/awx/main/tests/functional/api/test_credential.py @@ -22,14 +22,14 @@ def test_create_user_credential_via_credentials_list(post, get, alice): assert response.data['count'] == 1 @pytest.mark.django_db -def test_credential_validation_error_with_bad_user(post, alice): +def test_credential_validation_error_with_bad_user(post, admin): response = post(reverse('api:credential_list'), { 'user': 'asdf', 'name': 'Some name', 'username': 'someusername' - }, alice) - assert response.status_code == 403 - assert response.data['detail'] == 'You do not have permission to perform this action.' + }, admin) + assert response.status_code == 400 + assert response.data['user'][0] == 'Incorrect type. Expected pk value, received unicode.' @pytest.mark.django_db def test_create_user_credential_via_user_credentials_list(post, get, alice):