mirror of
https://github.com/ansible/awx.git
synced 2026-02-17 19:20:05 -03:30
Changed status tweaks for API validation and encryption
API validation topic: - do not set changed=True if the object did not actually change - deals with cases where API manipulates data before saving Warn if encrypted data prevent accurate changed status Handle false changed case of tower_user password password field not present in data Test changed=True warning with JT/WFJT survey spec defaults case for list data in JSON
This commit is contained in:
@@ -123,9 +123,10 @@ def main():
|
||||
# These will be passed into the create/updates
|
||||
credential_type_params = {
|
||||
'name': new_name if new_name else name,
|
||||
'kind': kind,
|
||||
'managed_by_tower': False,
|
||||
}
|
||||
if kind:
|
||||
credential_type_params['kind'] = kind
|
||||
if module.params.get('description'):
|
||||
credential_type_params['description'] = module.params.get('description')
|
||||
if module.params.get('inputs'):
|
||||
|
||||
@@ -450,6 +450,8 @@ def main():
|
||||
existing_spec = module.get_endpoint(spec_endpoint)['json']
|
||||
if new_spec != existing_spec:
|
||||
module.json_output['changed'] = True
|
||||
if existing_item and module.has_encrypted_values(existing_spec):
|
||||
module._encrypted_changed_warning('survey_spec', existing_item, warning=True)
|
||||
on_change = update_survey
|
||||
|
||||
if state == 'absent':
|
||||
|
||||
@@ -209,6 +209,8 @@ def main():
|
||||
existing_spec = module.get_endpoint(spec_endpoint)
|
||||
if new_spec != existing_spec:
|
||||
module.json_output['changed'] = True
|
||||
if existing_item and module.has_encrypted_values(existing_spec):
|
||||
module._encrypted_changed_warning('survey_spec', existing_item, warning=True)
|
||||
on_change = update_survey
|
||||
|
||||
if state == 'absent':
|
||||
|
||||
Reference in New Issue
Block a user