From fe6bac6d9ebb5b5895c61385b47d9f303c70d777 Mon Sep 17 00:00:00 2001 From: Rick Elrod Date: Wed, 6 Dec 2023 08:43:45 -0600 Subject: [PATCH] [CI] Reduce GHA timeouts from 6h default (#14704) * [CI] Reduce GHA timeouts from 6h default The goal here is to never interfere with a real run (so most of the timeout-minutes values seem rather high) but to avoid having 6h long runs if something goes crazy and never ends. Signed-off-by: Rick Elrod * Do bash hackery instead Signed-off-by: Rick Elrod --------- Signed-off-by: Rick Elrod --- .github/actions/run_awx_devel/action.yml | 12 ++++++++---- .github/workflows/ci.yml | 6 ++++++ .github/workflows/devel_images.yml | 1 + .github/workflows/docs.yml | 1 + .github/workflows/feature_branch_deletion.yml | 1 + .github/workflows/label_issue.yml | 2 ++ .github/workflows/label_pr.yml | 2 ++ .github/workflows/pr_body_check.yml | 1 + .github/workflows/promote.yml | 1 + .github/workflows/stage.yml | 1 + .github/workflows/update_dependabot_prs.yml | 1 + .github/workflows/upload_schema.yml | 1 + 12 files changed, 26 insertions(+), 4 deletions(-) diff --git a/.github/actions/run_awx_devel/action.yml b/.github/actions/run_awx_devel/action.yml index 80b02669cf..79c795c85d 100644 --- a/.github/actions/run_awx_devel/action.yml +++ b/.github/actions/run_awx_devel/action.yml @@ -43,10 +43,14 @@ runs: - name: Update default AWX password shell: bash run: | - while [[ "$(curl -s -o /dev/null -w ''%{http_code}'' -k https://localhost:8043/api/v2/ping/)" != "200" ]] - do - echo "Waiting for AWX..." - sleep 5 + SECONDS=0 + while [[ "$(curl -s -o /dev/null -w ''%{http_code}'' -k https://localhost:8043/api/v2/ping/)" != "200" ]]; do + if [[ $SECONDS -gt 600 ]]; then + echo "Timing out, AWX never came up" + exit 1 + fi + echo "Waiting for AWX..." + sleep 5 done echo "AWX is up, updating the password..." docker exec -i tools_awx_1 sh <<-EOSH diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7bc82741e8..afdbd69eb6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,6 +11,7 @@ jobs: common-tests: name: ${{ matrix.tests.name }} runs-on: ubuntu-latest + timeout-minutes: 60 permissions: packages: write contents: read @@ -49,6 +50,7 @@ jobs: dev-env: runs-on: ubuntu-latest + timeout-minutes: 60 steps: - uses: actions/checkout@v3 @@ -63,6 +65,7 @@ jobs: awx-operator: runs-on: ubuntu-latest + timeout-minutes: 60 steps: - name: Checkout awx uses: actions/checkout@v3 @@ -112,6 +115,7 @@ jobs: collection-sanity: name: awx_collection sanity runs-on: ubuntu-latest + timeout-minutes: 30 strategy: fail-fast: false steps: @@ -131,6 +135,7 @@ jobs: collection-integration: name: awx_collection integration runs-on: ubuntu-latest + timeout-minutes: 60 strategy: fail-fast: false matrix: @@ -182,6 +187,7 @@ jobs: collection-integration-coverage-combine: name: combine awx_collection integration coverage runs-on: ubuntu-latest + timeout-minutes: 10 needs: - collection-integration strategy: diff --git a/.github/workflows/devel_images.yml b/.github/workflows/devel_images.yml index 179828be7d..7f8c791bc4 100644 --- a/.github/workflows/devel_images.yml +++ b/.github/workflows/devel_images.yml @@ -12,6 +12,7 @@ jobs: push: if: endsWith(github.repository, '/awx') || startsWith(github.ref, 'refs/heads/release_') runs-on: ubuntu-latest + timeout-minutes: 60 permissions: packages: write contents: read diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index d50793210e..a5dc51fb59 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -6,6 +6,7 @@ jobs: docsite-build: name: docsite test build runs-on: ubuntu-latest + timeout-minutes: 30 steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/feature_branch_deletion.yml b/.github/workflows/feature_branch_deletion.yml index 3e574b211b..3fbd287cb1 100644 --- a/.github/workflows/feature_branch_deletion.yml +++ b/.github/workflows/feature_branch_deletion.yml @@ -9,6 +9,7 @@ on: jobs: push: runs-on: ubuntu-latest + timeout-minutes: 20 permissions: packages: write contents: read diff --git a/.github/workflows/label_issue.yml b/.github/workflows/label_issue.yml index f33efab600..c5a2b2c7cb 100644 --- a/.github/workflows/label_issue.yml +++ b/.github/workflows/label_issue.yml @@ -13,6 +13,7 @@ permissions: jobs: triage: runs-on: ubuntu-latest + timeout-minutes: 20 name: Label Issue steps: @@ -26,6 +27,7 @@ jobs: community: runs-on: ubuntu-latest + timeout-minutes: 20 name: Label Issue - Community steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/label_pr.yml b/.github/workflows/label_pr.yml index 6ee5a34e8b..15571a866c 100644 --- a/.github/workflows/label_pr.yml +++ b/.github/workflows/label_pr.yml @@ -14,6 +14,7 @@ permissions: jobs: triage: runs-on: ubuntu-latest + timeout-minutes: 20 name: Label PR steps: @@ -25,6 +26,7 @@ jobs: community: runs-on: ubuntu-latest + timeout-minutes: 20 name: Label PR - Community steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/pr_body_check.yml b/.github/workflows/pr_body_check.yml index 7af1914bb4..9532aa87ed 100644 --- a/.github/workflows/pr_body_check.yml +++ b/.github/workflows/pr_body_check.yml @@ -10,6 +10,7 @@ jobs: if: github.repository_owner == 'ansible' && endsWith(github.repository, 'awx') name: Scan PR description for semantic versioning keywords runs-on: ubuntu-latest + timeout-minutes: 20 permissions: packages: write contents: read diff --git a/.github/workflows/promote.yml b/.github/workflows/promote.yml index 58e3762851..81a7878d6e 100644 --- a/.github/workflows/promote.yml +++ b/.github/workflows/promote.yml @@ -15,6 +15,7 @@ jobs: promote: if: endsWith(github.repository, '/awx') runs-on: ubuntu-latest + timeout-minutes: 90 steps: - name: Checkout awx uses: actions/checkout@v3 diff --git a/.github/workflows/stage.yml b/.github/workflows/stage.yml index aab4ad83a5..f38cda55ec 100644 --- a/.github/workflows/stage.yml +++ b/.github/workflows/stage.yml @@ -23,6 +23,7 @@ jobs: stage: if: endsWith(github.repository, '/awx') runs-on: ubuntu-latest + timeout-minutes: 90 permissions: packages: write contents: write diff --git a/.github/workflows/update_dependabot_prs.yml b/.github/workflows/update_dependabot_prs.yml index a61eb1c172..bcb0b7674a 100644 --- a/.github/workflows/update_dependabot_prs.yml +++ b/.github/workflows/update_dependabot_prs.yml @@ -9,6 +9,7 @@ jobs: name: Update Dependabot Prs if: contains(github.event.pull_request.labels.*.name, 'dependencies') && contains(github.event.pull_request.labels.*.name, 'component:ui') runs-on: ubuntu-latest + timeout-minutes: 20 steps: - name: Checkout branch diff --git a/.github/workflows/upload_schema.yml b/.github/workflows/upload_schema.yml index ae4e23d977..0b7bc7bf6e 100644 --- a/.github/workflows/upload_schema.yml +++ b/.github/workflows/upload_schema.yml @@ -13,6 +13,7 @@ on: jobs: push: runs-on: ubuntu-latest + timeout-minutes: 60 permissions: packages: write contents: read