diff --git a/awx/ui_next/src/components/PromptDetail/PromptDetail.jsx b/awx/ui_next/src/components/PromptDetail/PromptDetail.jsx index e10fc1e4a0..f8a20319f0 100644 --- a/awx/ui_next/src/components/PromptDetail/PromptDetail.jsx +++ b/awx/ui_next/src/components/PromptDetail/PromptDetail.jsx @@ -5,7 +5,7 @@ import { withI18n } from '@lingui/react'; import { t, Trans } from '@lingui/macro'; import { Link } from 'react-router-dom'; import styled from 'styled-components'; -import { Chip, Divider } from '@patternfly/react-core'; +import { Chip, Divider, Title } from '@patternfly/react-core'; import { toTitleCase } from '../../util/strings'; import CredentialChip from '../CredentialChip'; @@ -18,9 +18,19 @@ import PromptInventorySourceDetail from './PromptInventorySourceDetail'; import PromptJobTemplateDetail from './PromptJobTemplateDetail'; import PromptWFJobTemplateDetail from './PromptWFJobTemplateDetail'; -const PromptHeader = styled.h2` - font-weight: bold; - margin: var(--pf-global--spacer--lg) 0; +const PromptTitle = styled(Title)` + margin-top: 40px; + --pf-c-title--m-md--FontWeight: 700; + grid-column: 1 / -1; +`; + +const PromptDivider = styled(Divider)` + margin-top: var(--pf-global--spacer--lg); + margin-bottom: var(--pf-global--spacer--lg); +`; + +const PromptDetailList = styled(DetailList)` + padding: 0px 20px; `; function formatTimeout(timeout) { @@ -136,9 +146,11 @@ function PromptDetail({ i18n, resource, launchConfig = {}, overrides = {} }) { {hasPromptData(launchConfig) && hasOverrides && ( <> - - {i18n._(t`Prompted Values`)} - + + {i18n._(t`Prompted Values`)} + + + {launchConfig.ask_job_type_on_launch && ( )} - + )} diff --git a/awx/ui_next/src/components/Schedule/ScheduleDetail/ScheduleDetail.jsx b/awx/ui_next/src/components/Schedule/ScheduleDetail/ScheduleDetail.jsx index eee6b25c32..597d499cbe 100644 --- a/awx/ui_next/src/components/Schedule/ScheduleDetail/ScheduleDetail.jsx +++ b/awx/ui_next/src/components/Schedule/ScheduleDetail/ScheduleDetail.jsx @@ -5,7 +5,7 @@ import { RRule, rrulestr } from 'rrule'; import styled from 'styled-components'; import { withI18n } from '@lingui/react'; import { t } from '@lingui/macro'; -import { Chip, Title, Button } from '@patternfly/react-core'; +import { Chip, Divider, Title, Button } from '@patternfly/react-core'; import { Schedule } from '../../../types'; import AlertModal from '../../AlertModal'; import { CardBody, CardActionsRow } from '../../Card'; @@ -27,11 +27,21 @@ import ErrorDetail from '../../ErrorDetail'; import ChipGroup from '../../ChipGroup'; import { VariablesDetail } from '../../CodeMirrorInput'; +const PromptDivider = styled(Divider)` + margin-top: var(--pf-global--spacer--lg); + margin-bottom: var(--pf-global--spacer--lg); +`; + const PromptTitle = styled(Title)` + margin-top: 40px; --pf-c-title--m-md--FontWeight: 700; grid-column: 1 / -1; `; +const PromptDetailList = styled(DetailList)` + padding: 0px 20px; +`; + function ScheduleDetail({ schedule, i18n }) { const { id, @@ -41,6 +51,7 @@ function ScheduleDetail({ schedule, i18n }) { dtend, dtstart, extra_data, + inventory, job_tags, job_type, limit, @@ -140,18 +151,25 @@ function ScheduleDetail({ schedule, i18n }) { survey_enabled, } = launchData || {}; + const showCredentialsDetail = + ask_credential_on_launch && credentials.length > 0; + const showInventoryDetail = ask_inventory_on_launch && inventory; + const showVariablesDetail = + (ask_variables_on_launch || survey_enabled) && + ((typeof extra_data === 'string' && extra_data !== '') || + (typeof extra_data === 'object' && Object.keys(extra_data).length > 0)); + const showPromptedFields = - ask_credential_on_launch || + showCredentialsDetail || ask_diff_mode_on_launch || - ask_inventory_on_launch || + showInventoryDetail || ask_job_type_on_launch || ask_limit_on_launch || ask_scm_branch_on_launch || ask_skip_tags_on_launch || ask_tags_on_launch || - ask_variables_on_launch || ask_verbosity_on_launch || - survey_enabled; + showVariablesDetail; if (isLoading) { return ; @@ -189,15 +207,18 @@ function ScheduleDetail({ schedule, i18n }) { date={modified} user={summary_fields.modified_by} /> - {showPromptedFields && ( - <> - - {i18n._(t`Prompted Fields`)} - + + {showPromptedFields && ( + <> + + {i18n._(t`Prompted Values`)} + + + {ask_job_type_on_launch && ( )} - {ask_inventory_on_launch && ( + {showInventoryDetail && ( )} - {ask_credential_on_launch && ( + {showCredentialsDetail && ( )} - {(ask_variables_on_launch || survey_enabled) && ( + {showVariablesDetail && ( )} - - )} - + + + )} {summary_fields?.user_capabilities?.edit && (