Commit Graph
2424 Commits
Author SHA1 Message Date
Akita Noek 1aeca1bebb Merge pull request #2919 from anoek/2918
Several system auditor fixes to allow SA's to read and see things
2016-07-11 15:23:36 -04:00
Akita Noek fd461a9768 Remove redundant check 2016-07-11 15:05:35 -04:00
Matthew Jones 2f843d15e0 Also forcefully kill the main process 2016-07-11 14:45:41 -04:00
Akita Noek ec37703ce8 Allow SA's to read all notification templates 2016-07-11 14:44:36 -04:00
Matthew Jones 43c5105a57 No more Mr. Nice Tower
or how I learned to stop worrying and use SIGKILL.

Ansible has a bug that could potentially leave tower's jobs hanging
around indefinitely requiring manual shell intervention.   I'm going to
put this here and until Ansible can get to the bottom of it.
2016-07-11 14:37:09 -04:00
Akita Noek 134b60dbed Switch to explicit checks for system auditor for all applicable get_queryset calls
Solves #2918 and probably a couple other corner cases where orphan
situations could happen
2016-07-11 14:06:40 -04:00
Matthew Jones 6447434aa1 Hanele credential in notifications when deleted 2016-07-11 10:16:33 -04:00
Akita Noek 8bad695d26 Merge pull request #2886 from anoek/2804
Allow anyone who can read an inventory to see adhoc commands run on that inventory
2016-07-08 16:57:37 -04:00
Akita Noek 7733167693 Updated tests to reflect new expected behavior 2016-07-08 16:29:14 -04:00
AlanCoding 5027027aba update behavior of access.py to newer DRF, display POST box for most list endpoints 2016-07-08 15:18:40 -04:00
Matthew Jones ae9b4d3e58 Revert "Fix up hook conditions for rbac activity stream"
This reverts commit 36c14f83bcb11fcdbd31140ce182ab87e3db4644.
2016-07-08 13:13:22 -04:00
Matthew Jones 26b0d345f8 Notification guarding for deleted inventory 2016-07-08 13:04:42 -04:00
Matthew Jones 1c860b81ac Fix up hook conditions for rbac activity stream 2016-07-08 13:03:34 -04:00
Matthew Jones 4c7f54cf72 Fix an activity stream associate with deleted obj
In some scenarios the activity stream associate could be invoked where
obj2 doesn't exist... the .get() will fail and tank the caller
preventing the save.   This guards that and blocks the activity stream
event, saving the save (whew!)
2016-07-08 12:56:52 -04:00
Akita Noek a0017eb074 Skip troublesome old job tests
These are actively being worked on by matburt and cmeyers, merging these
skips because the otherwise unrelated test failures are causing
headaches for the UI team.
2016-07-08 12:33:32 -04:00
Akita Noek ee3d4dc42d Allow anyone who can read an inventory to see adhoc commands run on that inventory
This implicitly solves one of the issues with #2804, but is in general a
better behavior in general we believe.
2016-07-08 12:09:39 -04:00
Akita Noek 33547259e2 Merge pull request #2840 from anoek/test-porting
Ported several old tests to our new test system
2016-07-08 09:25:35 -04:00
Chris Church 2387ef0d3a Merge pull request #2850 from wenottingham/wording-tweak
Tweak system job template wording
2016-07-07 16:18:33 -04:00
Bill Nottingham e0d76ec378 Tweak system job wording. 2016-07-07 16:12:51 -04:00
Akita Noek 521fa13662 More mock fixes for organizations.py tests 2016-07-07 14:41:11 -04:00
AlanCoding 94c4db1d6a Show the project list POST text box for org admins in API browser 2016-07-07 14:05:09 -04:00
Akita Noek 856ad80c21 Mock feature_enabled for organization tests 2016-07-07 13:53:21 -04:00
Chris Meyers 735a75729f Revert "fixes Save with update_fields did not affect any rows"
This reverts commit c6d282fce27d23317d2649ccf00b75799dad1a86.

This didn't fix the underlying issue. The issue is that the inventory
object may have been deleted by the time save is called.
2016-07-07 12:09:16 -04:00
Akita Noek 55730f8730 Ported old/organizations.py tests 2016-07-07 11:58:38 -04:00
Akita Noek e41614f4e7 flake8 2016-07-07 10:24:04 -04:00
Akita Noek a42986894f Made it so org auditors can see all users if ORG_ADMINS_CAN_SEE_ALL_USERS is true
Addresses #2706
2016-07-07 09:22:36 -04:00
Akita Noek b6ec87f18a Merge pull request #2820 from anoek/2806
Allow anyone who can read an inventory to see adhoc command run against said inventory
2016-07-07 09:09:16 -04:00
Akita Noek 51b959406a Merge pull request #2819 from anoek/2744
Make it so users can see all roles on things they can see.
2016-07-06 16:16:42 -04:00
Alan Rominger 9476bc12e9 Merge pull request #2787 from AlanCoding/2733_credential_org_access
Processing of "organization" related field in credential can_change
2016-07-06 15:43:17 -04:00
AlanCoding 5df846eb0a remove unnecessary fixture from org_credential 2016-07-06 15:21:57 -04:00
Alan Rominger 70b9a48f82 Merge pull request #2739 from AlanCoding/2735_proj_access
Do not allow creating projects as foreign org admin
2016-07-06 15:09:43 -04:00
Akita Noek 0e7ed8428d Allow anyone who can read an inventory to see adhoc command run against said inventory 2016-07-06 14:23:42 -04:00
Akita Noek 015085fe15 Added role visibility tests 2016-07-06 13:38:52 -04:00
Akita Noek b4810f6486 Typo 2016-07-06 13:38:43 -04:00
Akita Noek b94902d970 filter_visible_roles performance enhancement 2016-07-06 12:20:52 -04:00
AlanCoding ddbe54f841 allow null data cases in credential can_change 2016-07-05 15:06:40 -04:00
Akita Noek a126736332 Expand role visibility such that you can always see all roles on any objects you can see
Completes #2774
2016-07-05 15:06:25 -04:00
Matthew Jones 77f2bd1c0d Missing ad-hoc notification template assignment 2016-07-05 14:34:49 -04:00
AlanCoding c21d560cfd Credential can_change updates for organization related field 2016-07-05 14:04:52 -04:00
Akita Noek e818daa74f Ensure system auditors/admins can see all roles
Partial fix for #2744
2016-07-05 14:01:46 -04:00
Matthew Jones cec1f413a4 Switch notification to use jobhostsummary name
In case the host is removed prior to the notification being emitted
we'll use the host_name cached on the jobhostsummary object iself.
2016-07-05 12:32:37 -04:00
Chris Meyers 1aca42ae93 fixes Save with update_fields did not affect any rows 2016-07-05 11:46:46 -04:00
Matthew Jones d899c33ac4 Handle errors that come out of job deps generation 2016-07-01 15:40:46 -04:00
Wayne Witzel III c00d32d0eb Merge pull request #2714 from wwitzel3/issue-2706
ensure the singleton roles show up for sys auditor / sys admins
2016-07-01 11:11:58 -04:00
Wayne Witzel III 16bc0cdf0b add helper decorator to ensure signleton roles see the proper role list 2016-07-01 10:38:02 -04:00
AlanCoding c7bedcb004 Do not allow creating proejcts as foreign org admin 2016-07-01 09:51:26 -04:00
Akita Noek 2ff5efda3b Merge pull request #2721 from anoek/2710
Fix inventory update permission so update_role is enough to update
2016-06-30 21:51:14 -04:00
Akita Noek b21c7e1d15 Fix inventory update permission so update_role is enough to update 2016-06-30 14:58:44 -04:00
Chris Meyers 84e02a5dd2 fix unit tests and make delete last unattach more generic 2016-06-30 14:13:19 -04:00
Akita Noek d79188f865 Cleaned up unit/test_redact.py 2016-06-30 12:16:57 -04:00