Marliana Lara
2b6cfd7b3d
Handle undefined schedule value in job detail component
2019-10-29 11:24:11 -04:00
Graham Mainwaring
b2b33605cc
Add UI toggle to disable public Galaxy ( #3867 )
2019-10-29 11:24:11 -04:00
mabashian
d06b0de74b
Revert 6282b5bacb
2019-10-29 11:24:11 -04:00
Ryan Petrello
6dfc714c75
when isolated or container jobs fail to launch, set job status to error
...
a status of error makes more sense, because failed generally points to
an issue with the playbook itself, while error is more generally used
for reporting issues internal to Tower
see: https://github.com/ansible/awx/issues/4909
2019-10-29 11:24:10 -04:00
Jake McDermott
cf5d3d55f0
Set omitted runner event line lengths to 0
...
runner_on_start events have zero-length strings for their stdout
fields. We don't want to display these in the ui so we omit them.
Although the stdout field is an empty string, it still has a recorded
line length of 1 that we must account for. Since we're not rendering
the blank line, we must also go back and set the event record's line
length to 0 in order to avoid deleting too many lines when we pop or
shift events off of the view while scrolling.
2019-10-29 11:24:10 -04:00
Jake McDermott
e91d383165
Fix off-by-one errors
2019-10-29 11:24:10 -04:00
mabashian
72d19b93a0
Prettier formatting
2019-10-29 11:01:04 -04:00
softwarefactory-project-zuul[bot]
ff1c96b0e0
Merge pull request #5132 from mabashian/4980-job-details-delete
...
Hide delete button on job details from users without proper permissions
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-29 01:18:50 +00:00
softwarefactory-project-zuul[bot]
6aaf906594
Merge pull request #5130 from mabashian/4948-empty-list
...
Fix org teams empty list text
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-29 01:13:08 +00:00
Keith Grant
da7baced50
upgrade patternfly to latest, update tests
2019-10-28 15:59:47 -07:00
mabashian
01788263e2
Hide delete button on job details from users without proper permissions
2019-10-28 17:50:32 -04:00
mabashian
8daceabd26
Removes close button from footer of host details modal
2019-10-28 17:38:28 -04:00
mabashian
8fbfed5c55
Fix org teams empty list text
2019-10-28 17:21:14 -04:00
softwarefactory-project-zuul[bot]
c4a3c0aac1
Merge pull request #5128 from fosterseth/fix-5081-towerbaseurl400
...
Fix URLField to allow numbers in top level domain
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-28 21:09:26 +00:00
Ryan Petrello
4d0c567d73
Merge pull request #3911 from jbradberry/truncate-fix
...
Add the no_truncate parameter to the job and adhoc event sublist views
2019-10-28 16:08:29 -04:00
softwarefactory-project-zuul[bot]
365f897059
Merge pull request #5103 from mabashian/proj-notifs
...
Hook up notifications tab on projects
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-28 19:38:15 +00:00
mabashian
7b1158ee8e
Fix failing unit tests due to missing scm_revision key
2019-10-28 15:31:03 -04:00
mabashian
d8814b7162
Add displayName so that ActionButtonCell can be referenced in tests
2019-10-28 15:11:58 -04:00
mabashian
9af3fa557b
Fix merge conflict fallout. Remove stale edit click handler.
2019-10-28 15:11:58 -04:00
mabashian
e0d8d35090
Adds edit buttons to Templates, Inventories, Organizations, and Projects list items when the user has edit capabilities.
2019-10-28 15:04:02 -04:00
Seth Foster
7e83ddc968
Fix URLField to allow numbers in top level domain
...
Add a custom regex to URLField that allows numbers to be present in the
top level domain, e.g. https://towerhost.org42
Set by variable allow_numbers_in_top_level_domain in URLField __init__,
and is set to True by default. If set to False, it will use the regex
specified in the built-in django URLValidator class.
This solution was originally implemented in LDAPServerURIField, but is
now implemented in URLField to support this behavior more generally. The
changes in LDAPServerURIField are longer needed and have been removed in
this commit.
Adds unit testing to make sure URLField changes handle regex input
and settings correctly.
2019-10-28 13:47:01 -04:00
Jeff Bradberry
b48815d2bb
Add the no_truncate parameter to the job and adhoc event sublist views
...
which are the ones that the CLI actually uses.
2019-10-28 12:51:14 -04:00
Jake McDermott
ad383cdb44
Merge pull request #3909 from jakemcdermott/fix-3578-comment
...
Improve code comment regarding handling of omitted events
2019-10-28 11:52:11 -04:00
softwarefactory-project-zuul[bot]
bbbacd62ae
Merge pull request #5125 from gmarsay/bugfix-slack-notification
...
Bugfix - Slack notification with name and avatar
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-28 15:37:39 +00:00
Jake McDermott
91afa88b44
Improve accuracy of code comment
2019-10-28 11:28:57 -04:00
softwarefactory-project-zuul[bot]
a6fd3d0c09
Merge pull request #5115 from AlanCoding/string_explosion
...
Fix bug: WFJT-type node YAML vars broke task manager
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-28 15:15:06 +00:00
Ryan Petrello
b575fa4243
Merge pull request #3898 from ryanpetrello/k8s-messy-client
...
attempt to clean up cacert trash the k8s python client leaves behind
2019-10-28 11:09:24 -04:00
softwarefactory-project-zuul[bot]
edf0d4bf85
Merge pull request #5120 from AlanCoding/var_lib
...
Move development PROJECTS_ROOT
Reviewed-by: Matthew Jones <mat@matburt.net >
https://github.com/matburt
2019-10-28 15:08:00 +00:00
Alan Rominger
3cab73c574
Add tests for AWX collection credential fixes ( #3893 )
2019-10-28 09:58:00 -04:00
Ryan Petrello
b3af64d66f
work around a bug in the k8s client that leaves trash in /tmp
2019-10-28 09:43:32 -04:00
Jake McDermott
841975d72b
Scrape tag input state from dom and put it in vm
...
The tag input state lives somewhere in the associated select2 widgetry
and isn't directly tied to the vm like it is for the other inputs.
2019-10-26 20:02:41 -04:00
Guillaume Marsay
31a96d20ab
Update slack_backend.py
2019-10-26 22:07:31 +02:00
softwarefactory-project-zuul[bot]
9a70ac88c0
Merge pull request #5075 from AlexSCorey/credentialsLookUp
...
Credentials look up
Reviewed-by: Alex Corey <Alex.swansboro@gmail.com >
https://github.com/AlexSCorey
2019-10-25 20:51:13 +00:00
Alex Corey
dab80fb842
Adds Proptypes
2019-10-25 16:16:04 -04:00
AlanCoding
a6404bdd0d
Move development PROJECTS_ROOT
2019-10-25 15:48:07 -04:00
Alex Corey
7f409c6487
Moves JT CredentialsList Manipulation Back to CredentialsLookup
...
Rename CredentialsLookup to MultiCredentialLookup
Removes unnecessary functions in Lookup.
Puts CredentialsList manipulation on CredsLookup and removes that work from JTForm.
Upates tests for CredentialsLookup and JTForm to reflect changes above.
2019-10-25 15:13:11 -04:00
softwarefactory-project-zuul[bot]
491e4c709e
Merge pull request #5116 from jakemcdermott/remove-jdetails-close
...
Remove close button from job details
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-25 16:43:21 +00:00
softwarefactory-project-zuul[bot]
480c8516ab
Merge pull request #5086 from keithjgrant/4614-fix-template-edit-border
...
Fix border/padding while loading jt edit form
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-25 16:31:53 +00:00
Jake McDermott
a517b15c26
Remove close button from job details
2019-10-25 11:59:40 -04:00
AlanCoding
609528e8a3
Fix bug: WFJT-type node YAML vars broke task manager
2019-10-25 11:41:58 -04:00
Jake McDermott
e17ee4b58f
Hide revision copy button when there's no revision
2019-10-25 11:40:06 -04:00
softwarefactory-project-zuul[bot]
3dc8a10e85
Merge pull request #5104 from mabashian/4985-close-button-details
...
Remove close button from Project and Job Template details views
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-25 14:43:07 +00:00
softwarefactory-project-zuul[bot]
e893017e00
Merge pull request #5105 from mabashian/4956-template-details-links
...
Link to project and inventory from job template details
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-25 14:21:14 +00:00
Ryan Petrello
b51b1a959f
fix a syntax error
...
whoopsie
2019-10-25 10:20:18 -04:00
softwarefactory-project-zuul[bot]
4a1c121792
Merge pull request #5084 from fosterseth/fix-4147-schedule500error
...
Fix 500 error when creating a job schedule
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-25 13:35:57 +00:00
Rebeccah
95ab5327c3
added in check to see if the the current check has an instance or not to prevent nonetype errors
2019-10-25 09:20:44 -04:00
mabashian
07a5e17284
Link to project and inventory from job template details
2019-10-24 16:36:19 -04:00
mabashian
583d1390d2
Remove close button from Project and Job Template details views
2019-10-24 16:17:37 -04:00
mabashian
638f8eae21
Hook up notifications tab on projects
2019-10-24 15:48:12 -04:00
Keith Grant
1d7bd835e6
remove unused imports
2019-10-24 10:29:04 -07:00