Commit Graph
7250 Commits
Author SHA1 Message Date
Akita Noek e50f20eb69 Check can_update for ProjectAccess.can_start for superusers too
can_update is a special model getter that checks to see if the project
is in a valid state it looks like - so it's important to check this for
superusers too. The can_change check does the implicit is_superuser
check for us, so we don't need another expclit check here, just
can_start protection.
2016-05-02 15:56:05 -04:00
Akita Noek f6f555b185 Prevent organization changes for teams
In old_access.py we restricted even super users from doing this. I'm not
sure that it'd actually break anything to allow this, but I'm making the
new access.py behave like old_access.py for good measure until we have a
valid usecase for this.
2016-05-02 15:49:59 -04:00
Akita Noek 826874d61c CredentialAccess fix to ensure appropriate access to what we're adding a credential to 2016-05-02 15:43:12 -04:00
Akita Noek c7f2568c10 Fixed up some credential migration issues 2016-05-02 14:44:15 -04:00
Akita Noek 5825737447 Reduce JT read access check to simple read_role check 2016-05-02 11:27:37 -04:00
Akita Noek 83e83a5db3 Actually do job template migrations
Seems important
2016-05-02 11:16:15 -04:00
Akita Noek 58e9c4ef87 Fixed JT migration issue
Role.__contains__ is not defined here, so we needed to drop in the
implementation instead.
2016-05-02 11:14:31 -04:00
Akita Noek 8a5e22cb4a Fix old_access user/team reference 2016-05-02 10:14:29 -04:00
Akita Noek 29b55fa04d Moved access control from credential add view to access.py
as it should have always been. This messes up being able to post to
api/v1/users/:n/credentials and api/v1/teams/:n/credentials without
specifyign the user/team id in the post body, but looking at the old
code it looks like this might have always been the case, so whatevs..

This fixes a old v new access.py test "failure", and is better anyways..
2016-04-29 17:27:14 -04:00
Akita Noek 1bf4fdbff1 Fixed up the _old_access.py UserAccess queryset 2016-04-29 16:57:51 -04:00
Akita Noek 6427526686 Updated JT migration tests to be more correct
This test was passing before because we were erroneously making all
users organization auditors, which gave users read access to all JT's
under the org.
2016-04-29 15:34:54 -04:00
Akita Noek ac1503e55c Fixed org migrations.. users are 'members' not 'auditors' 2016-04-28 11:50:36 -04:00
Akita Noek 27a7cf0d88 Added an explicit save everything step in the rbac migration
This step ensures all of our roles get setup before we start the
migration. It also speeds things up a little as we can wrap everything
with a `with batch_role_ancestor_rebuilding()`. We were pretty much
doing this already, but we had an issue where we didn't catch all job
templates all the time, so this just makes it very explicit and ensures
everything is setup, and does so a little faster.
2016-04-28 10:37:15 -04:00
Akita Noek c9501ad556 commented out code cleanup 2016-04-28 09:39:18 -04:00
Akita Noek af4daec314 More RBAC migration fixes 2016-04-27 16:59:33 -04:00
Akita Noek b670681f6c Handle JT "create" permissions during migration 2016-04-27 15:28:17 -04:00
Akita Noek a6f735b4b9 Fixed call to role rebuilder during migrations 2016-04-27 15:27:52 -04:00
Chris Meyers 526e04a00c Merge pull request #1690 from chrismeyersfsu/fix-labels_disassociate
delete label on last disassociate
2016-04-27 13:21:14 -04:00
Chris Meyers e449237d8a move delete last unattach mixin to job template sublabel 2016-04-27 12:07:57 -04:00
Leigh ce14c0daff Merge pull request #1679 from leigh-johnson/DashboardHosts
Dashboard Hosts, Form Generator headerFields options
2016-04-27 10:46:28 -04:00
Leigh 9d97ce6dff Merge pull request #1664 from ansible/FixedJSHint
Fixed js hint linting
2016-04-27 10:09:25 -04:00
kensible 78f0dde679 Merge pull request #1627 from kensible/735-logoBrandingUpdate
Updated logos and branding
2016-04-27 10:01:43 -04:00
Chris Meyers 1925742da1 delete orphaned labels when jt or j deleted 2016-04-27 09:46:34 -04:00
Leigh Johnson 5afd8ecce4 pass enabled/disabled to DsahboardHostService #1679 2016-04-27 09:42:23 -04:00
Leigh Johnson 443d54407b fix typo in service call ##1679 2016-04-27 09:29:16 -04:00
Wayne Witzel III d418a09bfc Merge pull request #1700 from wwitzel3/issue-1429
Fixing CredentialList post access check
2016-04-27 09:10:26 -04:00
Leigh Johnson 85698213cb finish dashboard hosts edit, resolves #1598
remove debug line
2016-04-27 08:55:46 -04:00
Leigh Johnson baf8d9ef6f create dashboard-hosts model, finish list view w/ status toggle, #1598 2016-04-27 08:55:46 -04:00
Leigh Johnson 434097101f cloneDeep list config and add additional ignored field params 2016-04-27 08:55:46 -04:00
Jared Tabor ebe0a3acf5 UI Popover Help for IRC/Slack Channel Names
Adding information in the UI popover allowing the user to send names with or without a prepending symbol.
2016-04-26 13:56:20 -07:00
Wayne Witzel III e78eb591db change permission, not admin permission 2016-04-26 15:57:49 -04:00
Leigh Johnson fb517097f3 fix failing select-all directive test & comment out describe blocks that need rewriting in adhoc.controller-test 2016-04-26 15:16:51 -04:00
Wayne Witzel III 2b589228d3 Fixing CredentialList post access check 2016-04-26 14:36:22 -04:00
Michael Abashian e381a4da85 Merge pull request #1684 from mabashian/prompt-all-things-checkboxes
Added prompt-for checkboxes to certain fields on the job template forms
2016-04-26 14:07:06 -04:00
Alan Rominger 62acda143f Merge pull request #1665 from AlanCoding/job_ask_fields
Fix display of prompt-ability in job data
2016-04-26 12:21:56 -04:00
Michael Abashian 3dc59ae6db Added the ability to pass in ngChange with the subCheckbox form object. Separated the checkbox's ngDisabled from the parent form element. 2016-04-26 12:15:00 -04:00
Leigh Johnson 7cf39c6ba1 add missing lookup module dep 2016-04-26 11:33:50 -04:00
Alan Rominger c1ee5910d1 Merge pull request #1670 from AlanCoding/1642_scan_JT_counts
Include scan jobs in organization's job template count
2016-04-26 11:05:25 -04:00
Akita Noek 077db7931f Merge pull request #1693 from anoek/devel
Fixed duplicate active_roles entries
2016-04-25 20:54:28 -04:00
Akita Noek 9921d90316 Fixed duplicate active_roles entries
#1692
2016-04-25 20:33:59 -04:00
Chris Meyers 2f18a9f2c1 delete label on last disassociate 2016-04-25 17:20:07 -04:00
Akita Noek 48f61b43e7 Merge pull request #1685 from anoek/1295
Fixed up 2.4.5 -> 3.0 no_log merge
2016-04-25 16:09:55 -04:00
Akita Noek 1bf23e2acc Merge pull request #1683 from anoek/1676
Added resource information summary fields to the Role serializer
2016-04-25 16:02:12 -04:00
Akita Noek 601bd0da05 Fixed up 2.4.5 -> 3.0 no_log merge
Addresses #1295
2016-04-25 15:52:38 -04:00
Akita Noek 3e4c26de13 Added resource information summary fields to the Role serializer
Completes #1676
2016-04-25 15:43:01 -04:00
Michael Abashian ff78082b67 Added prompt-for checkboxes to certain fields on the job template forms 2016-04-25 15:26:58 -04:00
Akita Noek 6ad8a14703 Merge pull request #1680 from anoek/performance
hosts and roles query performance improvements
2016-04-25 15:08:19 -04:00
Akita Noek 3ffefd30a3 flake8 2016-04-25 14:43:03 -04:00
Akita Noek 40147f28f8 Updated test 2016-04-25 14:29:05 -04:00
Akita Noek 30ed9ab740 Reverted cursor pagination for /roles/
Turns out it doesn't play well with our custom filters, and performance
is still tolerable with the normal pagination..
2016-04-25 14:29:05 -04:00