Commit Graph

760 Commits

Author SHA1 Message Date
AlanCoding
eed5a5c924 fix adhoc IG bug and prevent related inventory deletion 2017-08-14 11:14:42 -04:00
Aaron Tan
0c652f2a3a Merge pull request #237 from jangsutsr/7412_update_unified_job_deletion_behavior
Prevent deleting unified jobs with active status
2017-08-10 12:11:27 -04:00
Aaron Tan
497aa13562 Prevent deleting unified jobs with active status 2017-08-10 12:01:25 -04:00
Chris Meyers
c3f24d878d reap waiting processes if crash 2017-08-09 14:01:33 -04:00
AlanCoding
5f4d033836 change test to match with recent error message change 2017-08-08 13:57:51 -04:00
Alan Rominger
40c01d9ba7 Merge pull request #190 from AlanCoding/no_inv_src_ig
do not use inventory source instance groups
2017-08-08 09:14:15 -04:00
Aaron Tan
1e77f909a5 Force providing TACACSPLUS_SECRET when TACACSPLUS_HOST is set 2017-08-07 12:12:05 -04:00
Chris Meyers
8574c6ef4a Merge pull request #180 from chrismeyersfsu/fix-7383
fix single update_on_project_update per-inventory
2017-08-07 10:57:01 -04:00
Chris Meyers
95c12ac1ab enforce muutally exclusivity on update_on_project_update and update_on_launch for scm inventory 2017-08-07 10:50:36 -04:00
Alan Rominger
1487a68aca Merge pull request #188 from AlanCoding/can_RBAC
remove can_update from RBAC checks
2017-08-04 14:45:50 -04:00
AlanCoding
aca1efa552 do not use inventory source instance groups 2017-08-04 13:11:59 -04:00
AlanCoding
dfda406090 remove can_update from RBAC checks 2017-08-04 12:39:05 -04:00
Aaron Tan
4fd637a06b Merge pull request #184 from jangsutsr/7382_move_inv_delete_activity_stream_into_view
Move inventory delete activity stream into view
2017-08-04 12:22:38 -04:00
Aaron Tan
bba1e46218 Move inventory delete activity stream into view 2017-08-04 10:37:34 -04:00
Ryan Petrello
b4d69cb5c7 don't delete settings that are marked as read_only 2017-08-04 10:06:35 -04:00
Chris Meyers
3c89aeaba4 fix single update_on_project_update per-inventory 2017-08-03 18:54:05 -04:00
Chris Meyers
22aa251a24 Merge pull request #127 from chrismeyersfsu/fix-6559
remove conditional inventory sources POST
2017-08-02 12:25:50 -04:00
Chris Meyers
6cc5f14e16 remove conditional inventory sources POST
* Move logic from validator down to model
* Allow only 1 inventory source of type scm with
update_on_project_update set to True; for each inventory
2017-08-02 11:49:10 -04:00
Alan Rominger
c6a790bd24 Merge pull request #145 from AlanCoding/vault_perm
treat vault_credential same as credential for JT launch
2017-08-02 09:46:40 -04:00
AlanCoding
0b617d7538 treat vault_credential same as credential for JT launch 2017-08-02 08:24:24 -04:00
Aaron Tan
57375dc7f1 Merge pull request #101 from jangsutsr/7322_prevent_saving_jt_with_pending_deleting_inv
Clear related job templates when inventory is deleted
2017-08-01 20:32:06 -04:00
AlanCoding
f794472b3d fix bug introduced with anon user activity stream entries 2017-08-01 10:43:49 -04:00
AlanCoding
55cc23a712 impersonate requesting user in inventory deletion task 2017-07-31 16:06:36 -04:00
Alan Rominger
60eba9fbe2 Merge pull request #104 from AlanCoding/extra_cred_restart
Fix RBAC bugs in job relaunch with prompted extra_credentials
2017-07-31 14:59:06 -04:00
Aaron Tan
cc481aa33b Clear related job templates when inventory is deleted 2017-07-31 13:47:58 -04:00
Ryan Petrello
25f16f9409 Merge pull request #105 from ryanpetrello/fix-7323
add validation errors for certain dependent credential fields
2017-07-31 09:40:34 -04:00
Christian Adams
9816ac418a Merge pull request #82 from rooftopcellist/smart_inventory
Blocks creation of Hosts, Groups, and IS for Smart Inventories
2017-07-28 16:33:50 -04:00
adamscmRH
3dcd6ef2c2 Blocks creation of Hosts, Groups, and IS for Smart Inventories
* Updated View unit tests

* Refactored Validators

* Validator Fix for Blocking
2017-07-28 16:24:09 -04:00
Ryan Petrello
5e15f9e04e add validation errors for certain dependent credential fields
see: https://github.com/ansible/ansible-tower/issues/7323
see: https://github.com/ansible/ansible-tower/issues/7293
see: https://github.com/ansible/ansible-tower/issues/7289
see: https://github.com/ansible/ansible-tower/issues/7292
2017-07-28 16:07:37 -04:00
AlanCoding
1722d2169b Fix RBAC bugs in job relaunch with prompted extra_credentials
In addition to just checking for similarity with JT,
in all cases (prompt_for_credential_on_launch both T/F)
check for use_role on all extra_credentials the job has
if the job extra_credentials differ from the JT
2017-07-28 15:53:29 -04:00
Ryan Petrello
568986b39f force isolated timeout settings to be positive integers
see: https://github.com/ansible/ansible-tower/issues/7328
2017-07-28 12:24:21 -04:00
Aaron Tan
5a540a877e Prevent unprivileged users from deleting inventory sources 2017-07-27 16:29:03 -04:00
Matthew Jones
2b1bcc23be Merge branch 'purge_ansible_name' into release_3.2.0
* purge_ansible_name:
  Remove ansible reference from dev PKG-INFO
  Add back in PRIVILEGE_ESCALATION_METHODS inadvertantly removed
  Add awx_ and AWX_ environment vars and extra_vars alongside Tower
  Refactor some tower periodic tasks to label as awx
  Refactor Notification backend for tower -> awx
  Refactor fact cache plugin from tower -> awx
  Rename tower display plugins to awx display
  Mass rename from ansible_(awx|tower) -> (awx|tower)
2017-07-26 23:06:55 -04:00
Ryan Petrello
2c2e5cadbf don't require a credential for job launch if vault is specified
see: https://github.com/ansible/ansible-tower/issues/7310
2017-07-26 14:35:06 -04:00
Matthew Jones
b3b4a515e2 Refactor some tower periodic tasks to label as awx 2017-07-26 13:35:30 -04:00
AlanCoding
8746df7b31 update SCM test to mock inventory update 2017-07-25 15:41:01 -04:00
Alan Rominger
439ca6d32e Merge pull request #27 from AlanCoding/initial_sync
Use "sync" type when doing SCM inv src update on create
2017-07-24 21:20:08 -04:00
Ryan Petrello
6b6b4de205 Merge pull request #13 from ryanpetrello/fix-7252
allow Job Templates to launch with *only* a vault credential
2017-07-24 16:36:44 -04:00
Ryan Petrello
94efdec092 Merge pull request #12 from ryanpetrello/fix-6776
don't allow boolean credential type fields that specify `secret`
2017-07-24 16:17:56 -04:00
AlanCoding
cc547af18b on initial SCM inv src creation update, dont update project rev 2017-07-24 15:12:16 -04:00
Chris Meyers
525490a9a0 all dependent jobs must finish before starting job
related to https://github.com/ansible/ansible-tower/issues/6570 https://github.com/ansible/ansible-tower/issues/6489

* Ensure that all jobs dependent on a job have finished (i.e. error,
success, failed) before starting the dependent job.
* Fixes a bug where a smaller set of dependent jobs to fail upon a
update_on_launch job failing is chosen.
* This fixes the bug of jobs starting before dependent Project Updates
created via update on launch. This also fixes similar bugs associated
with inventory updates.
2017-07-24 12:31:35 -04:00
Ryan Petrello
b0f5d2f82d allow Job Templates to launch with *only* a vault credential
see: https://github.com/ansible/ansible-tower/issues/7252
2017-07-24 11:42:35 -04:00
Ryan Petrello
9f11c008d2 don't allow boolean credential type fields that specify secret
secret doesn't really make sense for boolean values; they can't store
sensitive content because they're just true|false

see: https://github.com/ansible/ansible-tower/issues/6776
2017-07-24 11:41:12 -04:00
Ryan Petrello
340ced02e2 Merge pull request #7240 from ryanpetrello/fix-7216
improve sanitation of empty credential values to match API v1 behavior
2017-07-21 12:45:16 -04:00
Bill Nottingham
836dc7d7f5 Fixup unit tests 2017-07-21 11:45:02 -04:00
Ryan Petrello
a640d6afec improve sanitation of empty credential values to match API v1 behavior
This is mostly backwards compatability to avoid surprises: in 3.1.x
if you submit a field value with `null` or an empty string to
a CharField, it's treated as an empty string (and SSH key validation
is skipped).  For boolean field values (`net.authorize`), `null` and
empty string are coerced to `False`.

see: #7216
see: #7218
2017-07-21 11:25:56 -04:00
Alan Rominger
4c7e7c281c Merge pull request #7188 from AlanCoding/just_update_already
Allow manual updates in spite of update_on_project_update
2017-07-20 10:13:15 -04:00
AlanCoding
f2d51f99dc Allow manual updates in spite of update_on_project_update
This makes inventory sources with the that flag set behave
like any other inventory source with manual use.
They will still update when triggered by a project SCM
hash change.
2017-07-20 09:38:47 -04:00
Alan Rominger
c038116626 Merge pull request #7095 from AlanCoding/schedule_validation
Add various validation for schedule extra_data
2017-07-20 09:30:29 -04:00
Chris Meyers
91e67b9a74 Merge pull request #7159 from chrismeyersfsu/fix-5645
do not accept array as extra_vars
2017-07-20 09:16:22 -04:00