mirror of
https://github.com/ansible/awx.git
synced 2026-02-21 13:10:11 -03:30
5752c7a8e2
Sort both bulk updates and add batch size to facts bulk update to resolve deadlock issue Update tests to expect batch_size to agree with changes Add utility method to bulk update and sort hosts and applied that to the appropriate locations Update functional tests to use bulk_update_sorted_by_id since update_hosts has been deleted Add comment NOSONAR to get rid of Sonarqube warning since this is just a test and it's not actually a security issue Fix failing test test_finish_job_fact_cache_clear & test_finish_job_fact_cache_with_existing_data --------- Signed-off-by: Seth Foster <fosterbseth@gmail.com> Co-authored-by: Alan Rominger <arominge@redhat.com> Co-authored-by: Seth Foster <fosterbseth@gmail.com>
265 lines
9.5 KiB
Python
265 lines
9.5 KiB
Python
import redis
|
|
import pytest
|
|
from unittest import mock
|
|
import json
|
|
|
|
from awx.main.models import (
|
|
Job,
|
|
Instance,
|
|
Host,
|
|
JobHostSummary,
|
|
InventoryUpdate,
|
|
InventorySource,
|
|
Project,
|
|
ProjectUpdate,
|
|
SystemJob,
|
|
AdHocCommand,
|
|
InstanceGroup,
|
|
Label,
|
|
ExecutionEnvironment,
|
|
)
|
|
from awx.main.tasks.system import cluster_node_heartbeat
|
|
from awx.main.utils.db import bulk_update_sorted_by_id
|
|
|
|
from django.db import OperationalError
|
|
from django.test.utils import override_settings
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_orphan_unified_job_creation(instance, inventory):
|
|
job = Job.objects.create(job_template=None, inventory=inventory, name='hi world')
|
|
job2 = job.copy_unified_job()
|
|
assert job2.job_template is None
|
|
assert job2.inventory == inventory
|
|
assert job2.name == 'hi world'
|
|
assert job.job_type == job2.job_type
|
|
assert job2.launch_type == 'relaunch'
|
|
|
|
|
|
@pytest.mark.django_db
|
|
@mock.patch('awx.main.tasks.system.inspect_execution_and_hop_nodes', lambda *args, **kwargs: None)
|
|
@mock.patch('awx.main.models.ha.get_cpu_effective_capacity', lambda cpu, is_control_node: 8)
|
|
@mock.patch('awx.main.models.ha.get_mem_effective_capacity', lambda mem, is_control_node: 62)
|
|
def test_job_capacity_and_with_inactive_node():
|
|
i = Instance.objects.create(hostname='test-1')
|
|
i.save_health_data('18.0.1', 2, 8000)
|
|
assert i.enabled is True
|
|
assert i.capacity_adjustment == 1.0
|
|
assert i.capacity == 62
|
|
i.enabled = False
|
|
i.save()
|
|
with override_settings(CLUSTER_HOST_ID=i.hostname):
|
|
with mock.patch.object(redis.client.Redis, 'ping', lambda self: True):
|
|
cluster_node_heartbeat()
|
|
i = Instance.objects.get(id=i.id)
|
|
assert i.capacity == 0
|
|
|
|
|
|
@pytest.mark.django_db
|
|
@mock.patch('awx.main.models.ha.get_cpu_effective_capacity', lambda cpu: 8)
|
|
@mock.patch('awx.main.models.ha.get_mem_effective_capacity', lambda mem: 62)
|
|
def test_job_capacity_with_redis_disabled():
|
|
i = Instance.objects.create(hostname='test-1')
|
|
|
|
def _raise(self):
|
|
raise redis.ConnectionError()
|
|
|
|
with mock.patch.object(redis.client.Redis, 'ping', _raise):
|
|
i.local_health_check()
|
|
assert i.capacity == 0
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_job_type_name():
|
|
job = Job.objects.create()
|
|
assert job.job_type_name == 'job'
|
|
|
|
ahc = AdHocCommand.objects.create()
|
|
assert ahc.job_type_name == 'ad_hoc_command'
|
|
|
|
source = InventorySource.objects.create(source='ec2')
|
|
source.save()
|
|
iu = InventoryUpdate.objects.create(inventory_source=source, source='ec2')
|
|
assert iu.job_type_name == 'inventory_update'
|
|
|
|
proj = Project.objects.create()
|
|
proj.save()
|
|
pu = ProjectUpdate.objects.create(project=proj)
|
|
assert pu.job_type_name == 'project_update'
|
|
|
|
sjob = SystemJob.objects.create()
|
|
assert sjob.job_type_name == 'system_job'
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_job_notification_data(inventory, machine_credential, project):
|
|
encrypted_str = "$encrypted$"
|
|
job = Job.objects.create(
|
|
job_template=None,
|
|
inventory=inventory,
|
|
name='hi world',
|
|
extra_vars=json.dumps({"SSN": "123-45-6789"}),
|
|
survey_passwords={"SSN": encrypted_str},
|
|
project=project,
|
|
)
|
|
job.credentials.set([machine_credential])
|
|
notification_data = job.notification_data(block=0)
|
|
assert json.loads(notification_data['extra_vars'])['SSN'] == encrypted_str
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_job_notification_host_data(inventory, machine_credential, project, job_template, host):
|
|
job = Job.objects.create(job_template=job_template, inventory=inventory, name='hi world', project=project)
|
|
JobHostSummary.objects.create(job=job, host=host, changed=1, dark=2, failures=3, ok=4, processed=3, skipped=2, rescued=1, ignored=0)
|
|
assert job.notification_data()['hosts'] == {
|
|
'single-host': {'failed': True, 'changed': 1, 'dark': 2, 'failures': 3, 'ok': 4, 'processed': 3, 'skipped': 2, 'rescued': 1, 'ignored': 0}
|
|
}
|
|
|
|
|
|
@pytest.mark.django_db
|
|
class TestAnsibleFactsSave:
|
|
current_call = 0
|
|
|
|
def test_update_hosts_deleted_host(self, inventory):
|
|
hosts = [Host.objects.create(inventory=inventory, name=f'foo{i}') for i in range(3)]
|
|
for host in hosts:
|
|
host.ansible_facts = {'foo': 'bar'}
|
|
last_pk = hosts[-1].pk
|
|
assert inventory.hosts.count() == 3
|
|
Host.objects.get(pk=last_pk).delete()
|
|
assert inventory.hosts.count() == 2
|
|
bulk_update_sorted_by_id(Host, hosts, fields=['ansible_facts'])
|
|
assert inventory.hosts.count() == 2
|
|
for host in inventory.hosts.all():
|
|
host.refresh_from_db()
|
|
assert host.ansible_facts == {'foo': 'bar'}
|
|
|
|
def test_update_hosts_forever_deadlock(self, inventory, mocker):
|
|
hosts = [Host.objects.create(inventory=inventory, name=f'foo{i}') for i in range(3)]
|
|
for host in hosts:
|
|
host.ansible_facts = {'foo': 'bar'}
|
|
db_mock = mocker.patch('awx.main.tasks.facts.Host.objects.bulk_update')
|
|
db_mock.side_effect = OperationalError('deadlock detected')
|
|
with pytest.raises(OperationalError):
|
|
bulk_update_sorted_by_id(Host, hosts, fields=['ansible_facts'])
|
|
|
|
def fake_bulk_update(self, host_list):
|
|
if self.current_call > 2:
|
|
return Host.objects.bulk_update(host_list, ['ansible_facts', 'ansible_facts_modified'])
|
|
self.current_call += 1
|
|
raise OperationalError('deadlock detected')
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_update_hosts_resolved_deadlock(inventory, mocker):
|
|
|
|
hosts = [Host.objects.create(inventory=inventory, name=f'foo{i}') for i in range(3)]
|
|
|
|
# Set ansible_facts for each host
|
|
for host in hosts:
|
|
host.ansible_facts = {'foo': 'bar'}
|
|
|
|
bulk_update_sorted_by_id(Host, hosts, fields=['ansible_facts'])
|
|
|
|
# Save changes and refresh from DB to ensure the updated facts are saved
|
|
for host in hosts:
|
|
host.save() # Ensure changes are persisted in the DB
|
|
host.refresh_from_db() # Refresh from DB to get latest data
|
|
|
|
# Assert that the ansible_facts were updated correctly
|
|
for host in inventory.hosts.all():
|
|
assert host.ansible_facts == {'foo': 'bar'}
|
|
|
|
bulk_update_sorted_by_id(Host, hosts, fields=['ansible_facts'])
|
|
|
|
|
|
@pytest.mark.django_db
|
|
class TestLaunchConfig:
|
|
def test_null_creation_from_prompts(self):
|
|
job = Job.objects.create()
|
|
data = {
|
|
"credentials": [],
|
|
"extra_vars": {},
|
|
"limit": None,
|
|
"job_type": None,
|
|
"execution_environment": None,
|
|
"instance_groups": None,
|
|
"labels": None,
|
|
"forks": None,
|
|
"timeout": None,
|
|
"job_slice_count": None,
|
|
}
|
|
config = job.create_config_from_prompts(data)
|
|
assert config is None
|
|
|
|
def test_only_limit_defined(self, job_template):
|
|
job = Job.objects.create(job_template=job_template)
|
|
data = {
|
|
"credentials": [],
|
|
"extra_vars": {},
|
|
"job_tags": None,
|
|
"limit": "",
|
|
"execution_environment": None,
|
|
"instance_groups": None,
|
|
"labels": None,
|
|
"forks": None,
|
|
"timeout": None,
|
|
"job_slice_count": None,
|
|
}
|
|
config = job.create_config_from_prompts(data)
|
|
assert config.char_prompts == {"limit": ""}
|
|
assert not config.credentials.exists()
|
|
assert config.prompts_dict() == {"limit": ""}
|
|
|
|
def test_many_to_many_fields(self, job_template, organization):
|
|
job = Job.objects.create(job_template=job_template)
|
|
ig1 = InstanceGroup.objects.create(name='bar')
|
|
ig2 = InstanceGroup.objects.create(name='foo')
|
|
job_template.instance_groups.add(ig2)
|
|
label1 = Label.objects.create(name='foo', description='bar', organization=organization)
|
|
label2 = Label.objects.create(name='faz', description='baz', organization=organization)
|
|
# Order should matter here which is why we do 2 and then 1
|
|
data = {
|
|
"credentials": [],
|
|
"extra_vars": {},
|
|
"job_tags": None,
|
|
"limit": None,
|
|
"execution_environment": None,
|
|
"instance_groups": [ig2, ig1],
|
|
"labels": [label2, label1],
|
|
"forks": None,
|
|
"timeout": None,
|
|
"job_slice_count": None,
|
|
}
|
|
config = job.create_config_from_prompts(data)
|
|
|
|
assert config.instance_groups.exists()
|
|
config_instance_group_ids = [item.id for item in config.instance_groups.all()]
|
|
assert config_instance_group_ids == [ig2.id, ig1.id]
|
|
|
|
assert config.labels.exists()
|
|
config_label_ids = [item.id for item in config.labels.all()]
|
|
assert config_label_ids == [label2.id, label1.id]
|
|
|
|
def test_pk_field(self, job_template, organization):
|
|
job = Job.objects.create(job_template=job_template)
|
|
ee = ExecutionEnvironment.objects.create(name='test-ee', image='quay.io/foo/bar')
|
|
# Order should matter here which is why we do 2 and then 1
|
|
data = {
|
|
"credentials": [],
|
|
"extra_vars": {},
|
|
"job_tags": None,
|
|
"limit": None,
|
|
"execution_environment": ee,
|
|
"instance_groups": [],
|
|
"labels": [],
|
|
"forks": None,
|
|
"timeout": None,
|
|
"job_slice_count": None,
|
|
}
|
|
config = job.create_config_from_prompts(data)
|
|
|
|
assert config.execution_environment
|
|
# We just write the PK instead of trying to assign an item, that happens on the save
|
|
assert config.execution_environment_id == ee.id
|