External-Mirrors/keycloak
2
0
Fork 0
mirror of https://github.com/keycloak/keycloak.git synced 2026-01-10 15:32:05 -03:30
Code Issues Packages Projects Releases Wiki Activity

Make sure pagination is used even when first is null for getGroups endpoint

Browse Source 
Closes #25731

Signed-off-by: Michal Hajas <mhajas@redhat.com>
This commit is contained in:
Michal Hajas 2024-02-08 16:24:39 +01:00 committed by Alexander Schwartz
parent d73148089b
commit 124d32f5b3
2 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
services/src/main/java/org/keycloak/services/resources/admin/GroupsResource.java
View File

@ -100,13 +100,11 @@ public class GroupsResource {
stream = ModelToRepresentation.searchGroupModelsByAttributes(session, realm, attributes, firstResult, maxResults);
} else if (Objects.nonNull(search)) {
stream = session.groups().searchForGroupByNameStream(realm, search.trim(), exact, firstResult, maxResults);
} else if(Objects.nonNull(firstResult) && Objects.nonNull(maxResults)) {
stream = session.groups().getTopLevelGroupsStream(realm, firstResult, maxResults);
} else {
stream = session.groups().getTopLevelGroupsStream(realm);
stream = session.groups().getTopLevelGroupsStream(realm, firstResult, maxResults);
}
if(populateHierarchy) {
if (populateHierarchy) {
return GroupUtils.populateGroupHierarchyFromSubGroups(session, realm, stream, !briefRepresentation, groupsEvaluator);
}
boolean canViewGlobal = groupsEvaluator.canView();

14
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/admin/group/GroupTest.java
View File

@ -1146,9 +1146,21 @@ public class GroupTest extends AbstractGroupTest {
List<GroupRepresentation> allGroups = realm.groups().groups();
assertEquals(20, allGroups.size());
List<GroupRepresentation> slice = realm.groups().groups(5, 7);
List<GroupRepresentation> slice = realm.groups().groups(0, 7);
assertEquals(7, slice.size());
slice = realm.groups().groups(null, 7);
assertEquals(7, slice.size());
slice = realm.groups().groups(10, null);
assertEquals(10, slice.size());
slice = realm.groups().groups(5, 7);
assertEquals(7, slice.size());
slice = realm.groups().groups(15, 7);
assertEquals(5, slice.size());
List<GroupRepresentation> search = realm.groups().groups("group1",0,20);
assertEquals(11, search.size());
for(GroupRepresentation group : search) {