Rework floating promises to avoid concurrency side effects

Closes #40739

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Co-authored-by: Jon Koops <jonkoops@gmail.com>

js/apps/account-ui/src/account-security/AccountRow.tsx

@@ -111,8 +111,8 @@ export const AccountRow = ({
             <Button
               id={`${account.providerAlias}-idp-link`}
               variant="link"
-              onClick={() => {
+              onClick={async () => {
-                login({
+                await login({
                   action: "idp_link:" + account.providerAlias,
                 });
               }}

js/apps/account-ui/src/account-security/DeviceActivity.tsx

@@ -69,7 +69,7 @@ export const DeviceActivity = () => {
 
   const signOutAll = async () => {
     await deleteSession(context);
-    context.keycloak.logout();
+    await context.keycloak.logout();
   };
 
   const signOutSession = async (

js/apps/account-ui/src/account-security/SigningIn.tsx

@@ -266,8 +266,8 @@ export const SigningIn = () => {
                                 <Button
                                   variant="danger"
                                   data-testrole="remove"
-                                  onClick={() => {
+                                  onClick={async () => {
-                                    login({
+                                    await login({
                                       action:
                                         "delete_credential:" +
                                         meta.credential.id,
@@ -280,8 +280,10 @@ export const SigningIn = () => {
                               {container.updateAction && (
                                 <Button
                                   variant="secondary"
-                                  onClick={() => {
+                                  onClick={async () => {
-                                    login({ action: container.updateAction });
+                                    await login({
+                                      action: container.updateAction,
+                                    });
                                   }}
                                   data-testrole="update"
                                 >

js/apps/account-ui/src/oid4vci/Oid4Vci.tsx

@@ -51,6 +51,7 @@ export const Oid4Vci = () => {
 
   useEffect(() => {
     if (initialSelected !== selected && credentialsIssuer !== undefined) {
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       requestVCOffer(context, selectOptions[selected], credentialsIssuer).then(
         (blob) => {
           const reader = new FileReader();

js/apps/account-ui/src/resources/PermissionRequest.tsx

@@ -105,15 +105,15 @@ export const PermissionRequest = ({
                 </Td>
                 <Td>
                   <Button
-                    onClick={() => {
+                    onClick={async () => {
-                      approveDeny(shareRequest, true);
+                      await approveDeny(shareRequest, true);
                     }}
                   >
                     {t("accept")}
                   </Button>
                   <Button
-                    onClick={() => {
+                    onClick={async () => {
-                      approveDeny(shareRequest);
+                      await approveDeny(shareRequest);
                     }}
                     className="pf-v5-u-ml-sm"
                     variant="danger"

js/apps/account-ui/src/utils/usePromise.ts

@@ -66,7 +66,7 @@ export function usePromise<T>(
       }
     }
 
-    handlePromise();
+    void handlePromise();
 
     // Abort the Promise when the component unmounts, or the dependencies change.
     return () => controller.abort();

js/apps/account-ui/test/account-security/signing-in.spec.ts

@@ -18,7 +18,7 @@ test.describe("Signing in", () => {
 
     await page.getByTestId("accountSecurity").click();
     await expect(page.getByTestId("account-security/signing-in")).toBeVisible();
-    page.getByTestId("account-security/signing-in").click();
+    await page.getByTestId("account-security/signing-in").click();
 
     await expect(
       page.getByTestId("password/credential-list").getByRole("listitem"),
@@ -54,11 +54,11 @@ test.describe("Signing in 2", () => {
     await login(page, "jdoe", "jdoe", "groups");
 
     const credentials = await getCredentials(jdoeUser!.id!, realm);
-    deleteCredential(jdoeUser!.id!, credentials![0].id!, realm);
+    await deleteCredential(jdoeUser!.id!, credentials![0].id!, realm);
 
     await page.getByTestId("accountSecurity").click();
     await expect(page.getByTestId("account-security/signing-in")).toBeVisible();
-    page.getByTestId("account-security/signing-in").click();
+    await page.getByTestId("account-security/signing-in").click();
 
     await expect(
       page.getByTestId("password/credential-list").getByRole("listitem"),

js/apps/account-ui/test/admin-client.ts

@@ -58,7 +58,7 @@ export async function createIdentityProvider(
   idp: IdentityProviderRepresentation,
   realm = DEFAULT_REALM,
 ): Promise<string> {
-  return adminClient.identityProviders.create({ ...idp, realm })["id"];
+  return (await adminClient.identityProviders.create({ ...idp, realm }))["id"];
 }
 
 export async function deleteIdentityProvider(

js/apps/admin-ui/src/authentication/FlowDetails.tsx

@@ -434,7 +434,7 @@ export default function FlowDetails() {
                     const [removed] = order.splice(source.index, 1);
                     order.splice(dest.index, 0, removed);
                     const change = executionList.getChange(dragged, order);
-                    executeChange(dragged, change);
+                    void executeChange(dragged, change);
                     return true;
                   } else {
                     setLiveText(t("onDragCancel"));
@@ -482,9 +482,9 @@ export default function FlowDetails() {
                     type={
                       flow.providerId === "client-flow" ? "client" : "basic"
                     }
-                    onSelect={(type) => {
+                    onSelect={async (type) => {
                       if (type) {
-                        addExecution(flow.alias!, type);
+                        await addExecution(flow.alias!, type);
                       }
                       setShowAddExecutionDialog(false);
                     }}
@@ -494,8 +494,8 @@ export default function FlowDetails() {
                   <AddSubFlowModal
                     name={flow.alias!}
                     onCancel={() => setShowSubFlowDialog(false)}
-                    onConfirm={(newFlow) => {
+                    onConfirm={async (newFlow) => {
-                      addFlow(flow.alias!, newFlow);
+                      await addFlow(flow.alias!, newFlow);
                       setShowSubFlowDialog(false);
                     }}
                   />

js/apps/admin-ui/src/authentication/RequiredActions.tsx

@@ -160,7 +160,7 @@ export const RequiredActions = () => {
           if (!dragged.alias) return;
 
           const times = newIndex - oldIndex;
-          executeMove(dragged, times);
+          await executeMove(dragged, times);
         }}
         columns={[
           {
@@ -177,8 +177,8 @@ export const RequiredActions = () => {
                 label={t("on")}
                 labelOff={t("off")}
                 isChecked={row.enabled}
-                onChange={() => {
+                onChange={async () => {
-                  updateAction(row.data, "enabled");
+                  await updateAction(row.data, "enabled");
                 }}
                 aria-label={row.name}
               />
@@ -196,8 +196,8 @@ export const RequiredActions = () => {
                 isDisabled={!row.enabled}
                 labelOff={!row.enabled ? t("disabledOff") : t("off")}
                 isChecked={row.defaultAction}
-                onChange={() => {
+                onChange={async () => {
-                  updateAction(row.data, "defaultAction");
+                  await updateAction(row.data, "defaultAction");
                 }}
                 aria-label={row.name}
               />

js/apps/admin-ui/src/clients/keys/GenerateKeyDialog.tsx

@@ -148,8 +148,8 @@ export const GenerateKeyDialog = ({
           key="confirm"
           data-testid="confirm"
           isDisabled={!isValid}
-          onClick={() => {
+          onClick={async () => {
-            handleSubmit((config) => {
+            await handleSubmit((config) => {
               save(config);
               toggleDialog();
             })();

js/apps/admin-ui/src/clients/keys/ImportKeyDialog.tsx

@@ -58,8 +58,8 @@ export const ImportKeyDialog = ({
           id="modal-confirm"
           data-testid="confirm"
           key="confirm"
-          onClick={() => {
+          onClick={async () => {
-            handleSubmit((importFile) => {
+            await handleSubmit((importFile) => {
               save(importFile);
               toggleDialog();
             })();

js/apps/admin-ui/src/clients/keys/SamlImportKeyDialog.tsx

@@ -32,8 +32,8 @@ export const SamlImportKeyDialog = ({
 
   const { addAlert, addError } = useAlerts();
 
-  const submit = (form: SamlKeysDialogForm) => {
+  const submit = async (form: SamlKeysDialogForm) => {
-    submitForm(adminClient, form, id, attr, (error) => {
+    await submitForm(adminClient, form, id, attr, (error) => {
       if (error) {
         addError("importError", error);
       } else {
@@ -50,8 +50,8 @@ export const SamlImportKeyDialog = ({
       continueButtonLabel="import"
       titleKey="importKey"
       confirmButtonDisabled={!isValid}
-      onConfirm={() => {
+      onConfirm={async () => {
-        handleSubmit(submit)();
+        await handleSubmit(submit)();
       }}
     >
       <FormProvider {...form}>

js/apps/admin-ui/src/clients/keys/SamlKeys.tsx

@@ -224,8 +224,8 @@ export const SamlKeys = ({ clientId, save }: SamlKeysProps) => {
     messageKey: "reGenerateSigningExplain",
     continueButtonLabel: "yes",
     cancelButtonLabel: "no",
-    onConfirm: () => {
+    onConfirm: async () => {
-      generate(selectedType!);
+      await generate(selectedType!);
     },
   });
 

js/apps/admin-ui/src/clients/keys/SamlKeysDialog.tsx

@@ -84,8 +84,8 @@ export const SamlKeysDialog = ({
 
   const { addAlert, addError } = useAlerts();
 
-  const submit = (form: SamlKeysDialogForm) => {
+  const submit = async (form: SamlKeysDialogForm) => {
-    submitForm(adminClient, form, id, attr, (error) => {
+    await submitForm(adminClient, form, id, attr, (error) => {
       if (error) {
         addError("importError", error);
       } else {
@@ -133,9 +133,9 @@ export const SamlKeysDialog = ({
           data-testid="confirm"
           variant="primary"
           isDisabled={!isValid && !keys}
-          onClick={() => {
+          onClick={async () => {
             if (type) {
-              handleSubmit(submit)();
+              await handleSubmit(submit)();
             }
             onClose();
           }}

js/apps/admin-ui/src/context/realm-context/RealmContext.tsx

@@ -34,7 +34,7 @@ export const RealmContextProvider = ({ children }: PropsWithChildren) => {
 
   // Configure admin client to use selected realm when it changes.
   useEffect(() => {
-    (async () => {
+    void (async () => {
       adminClient.setConfig({ realmName: realm });
       const namespace = encodeURIComponent(realm);
       await i18n.loadNamespaces(namespace);

js/apps/admin-ui/src/context/whoami/WhoAmI.tsx

@@ -33,7 +33,7 @@ export class WhoAmI {
   constructor(me?: WhoAmIRepresentation) {
     this.#me = me;
     if (this.#me?.locale) {
-      i18n.changeLanguage(this.#me.locale, (error) => {
+      void i18n.changeLanguage(this.#me.locale, (error) => {
         if (error) {
           console.warn("Error(s) loading locale", this.#me?.locale, error);
         }

js/apps/admin-ui/src/permissions-configuration/permission-configuration/AssignedPolicies.tsx

@@ -92,7 +92,7 @@ export const AssignedPolicies = ({
       : [],
   );
 
-  const assign = (policies: { policy: PolicyRepresentation }[]) => {
+  const assign = async (policies: { policy: PolicyRepresentation }[]) => {
     const assignedPolicies = policies.map(({ policy }) => ({
       id: policy.id!,
     }));
@@ -101,7 +101,7 @@ export const AssignedPolicies = ({
       ...(getValues("policies") || []),
       ...assignedPolicies,
     ]);
-    trigger("policies");
+    await trigger("policies");
     setSelectedPolicies([
       ...selectedPolicies,
       ...policies.map(({ policy }) => policy),
@@ -171,8 +171,8 @@ export const AssignedPolicies = ({
                 providers={providers!}
                 policies={policies!}
                 resourceType={resourceType}
-                onAssign={(newPolicy) => {
+                onAssign={async (newPolicy) => {
-                  assign([{ policy: newPolicy }]);
+                  await assign([{ policy: newPolicy }]);
                 }}
               />
             )}

js/apps/admin-ui/src/permissions-configuration/permission-configuration/NewPermissionPolicyDialog.tsx

@@ -179,9 +179,9 @@ export const NewPermissionPolicyDialog = ({
     >
       <Form
         id="createPermissionPolicy-form"
-        onSubmit={(e) => {
+        onSubmit={async (e) => {
           e.stopPropagation();
-          handleSubmit(save)(e);
+          await handleSubmit(save)(e);
         }}
         isHorizontal
       >

js/apps/admin-ui/src/realm-settings/DefaultGroupsTab.tsx

@@ -128,8 +128,8 @@ export const DefaultsGroupsTab = () => {
             title: "addDefaultGroups",
             ok: "add",
           }}
-          onConfirm={(groups) => {
+          onConfirm={async (groups) => {
-            addGroups(groups || []);
+            await addGroups(groups || []);
             toggleGroupPicker();
           }}
           onClose={toggleGroupPicker}

js/apps/admin-ui/src/realm-settings/LoginTab.tsx

@@ -71,8 +71,8 @@ export const RealmSettingsLoginTab = ({
               label={t("on")}
               labelOff={t("off")}
               isChecked={realm.registrationAllowed}
-              onChange={(_event, value) => {
+              onChange={async (_event, value) => {
-                updateSwitchValue({ registrationAllowed: value });
+                await updateSwitchValue({ registrationAllowed: value });
               }}
               aria-label={t("registrationAllowed")}
             />
@@ -96,8 +96,8 @@ export const RealmSettingsLoginTab = ({
               label={t("on")}
               labelOff={t("off")}
               isChecked={realm.resetPasswordAllowed}
-              onChange={(_event, value) => {
+              onChange={async (_event, value) => {
-                updateSwitchValue({ resetPasswordAllowed: value });
+                await updateSwitchValue({ resetPasswordAllowed: value });
               }}
               aria-label={t("resetPasswordAllowed")}
             />
@@ -120,8 +120,8 @@ export const RealmSettingsLoginTab = ({
               label={t("on")}
               labelOff={t("off")}
               isChecked={realm.rememberMe}
-              onChange={(_event, value) => {
+              onChange={async (_event, value) => {
-                updateSwitchValue({ rememberMe: value });
+                await updateSwitchValue({ rememberMe: value });
               }}
               aria-label={t("rememberMe")}
             />
@@ -148,8 +148,8 @@ export const RealmSettingsLoginTab = ({
               label={t("on")}
               labelOff={t("off")}
               isChecked={realm.registrationEmailAsUsername}
-              onChange={(_event, value) => {
+              onChange={async (_event, value) => {
-                updateSwitchValue([
+                await updateSwitchValue([
                   {
                     registrationEmailAsUsername: value,
                   },
@@ -179,8 +179,8 @@ export const RealmSettingsLoginTab = ({
               label={t("on")}
               labelOff={t("off")}
               isChecked={realm.loginWithEmailAllowed}
-              onChange={(_event, value) => {
+              onChange={async (_event, value) => {
-                updateSwitchValue([
+                await updateSwitchValue([
                   {
                     loginWithEmailAllowed: value,
                   },
@@ -207,8 +207,8 @@ export const RealmSettingsLoginTab = ({
               label={t("on")}
               labelOff={t("off")}
               isChecked={realm.duplicateEmailsAllowed}
-              onChange={(_event, value) => {
+              onChange={async (_event, value) => {
-                updateSwitchValue({
+                await updateSwitchValue({
                   duplicateEmailsAllowed: value,
                 });
               }}
@@ -237,8 +237,8 @@ export const RealmSettingsLoginTab = ({
               label={t("on")}
               labelOff={t("off")}
               isChecked={realm.verifyEmail}
-              onChange={(_event, value) => {
+              onChange={async (_event, value) => {
-                updateSwitchValue({ verifyEmail: value });
+                await updateSwitchValue({ verifyEmail: value });
               }}
               aria-label={t("verifyEmail")}
             />
@@ -268,8 +268,8 @@ export const RealmSettingsLoginTab = ({
               label={t("on")}
               labelOff={t("off")}
               isChecked={realm.editUsernameAllowed}
-              onChange={(_event, value) => {
+              onChange={async (_event, value) => {
-                updateSwitchValue({ editUsernameAllowed: value });
+                await updateSwitchValue({ editUsernameAllowed: value });
               }}
               aria-label={t("editUsernameAllowed")}
             />

js/apps/admin-ui/src/realm-settings/NewClientPolicy.tsx

@@ -386,9 +386,9 @@ export default function NewClientPolicy() {
     titleKey: "disablePolicyConfirmTitle",
     messageKey: "disablePolicyConfirm",
     continueButtonLabel: "disable",
-    onConfirm: () => {
+    onConfirm: async () => {
       form.setValue("enabled", !form.getValues().enabled);
-      save();
+      await save();
     },
   });
 
@@ -401,8 +401,8 @@ export default function NewClientPolicy() {
       <DeleteConditionConfirm />
       <DeleteProfileConfirm />
       <AddClientProfileModal
-        onConfirm={(profiles: ClientProfileRepresentation[]) => {
+        onConfirm={async (profiles: ClientProfileRepresentation[]) => {
-          addProfiles(profiles.map((item) => item.name!));
+          await addProfiles(profiles.map((item) => item.name!));
         }}
         allProfiles={policyProfiles}
         open={profilesModalOpen}
@@ -452,12 +452,12 @@ export default function NewClientPolicy() {
               }
               isReadOnly={isGlobalPolicy}
               isEnabled={field.value}
-              onToggle={(value) => {
+              onToggle={async (value) => {
                 if (!value) {
                   toggleDisableDialog();
                 } else {
                   field.onChange(value);
-                  save();
+                  await save();
                 }
               }}
             />

js/apps/admin-ui/src/realm-settings/PartialImport.tsx

@@ -287,8 +287,8 @@ export const PartialImportDialog = (props: PartialImportProps) => {
             data-testid="confirm"
             key="import"
             isDisabled={!isAnyResourceChecked}
-            onClick={() => {
+            onClick={async () => {
-              doImport();
+              await doImport();
             }}
           >
             {t("import")}

js/apps/admin-ui/src/realm-settings/PoliciesTab.tsx

@@ -272,9 +272,9 @@ export const PoliciesTab = () => {
                   clientPolicy={clientPolicy}
                   form={form}
                   saveStatus={saveStatus}
-                  onConfirm={() => {
+                  onConfirm={async () => {
                     form.setValue(clientPolicy.name!, false);
-                    saveStatus();
+                    await saveStatus();
                   }}
                 />
               ),

js/apps/admin-ui/src/realm-settings/RealmSettingsTabs.tsx

@@ -218,7 +218,7 @@ export const RealmSettingsTabs = () => {
         return [];
       }
     };
-    fetchLocalizationTexts();
+    void fetchLocalizationTexts();
   }, [setValue, realm]);
 
   const save = async (r: UIRealmRepresentation) => {

js/apps/admin-ui/src/realm-settings/event-config/EventsTab.tsx

@@ -154,7 +154,7 @@ export const EventsTab = ({ realm }: EventsTabProps) => {
     const enabledEventTypes = events?.enabledEventTypes?.filter(
       (e) => !values.includes(e),
     );
-    addEvents(enabledEventTypes);
+    await addEvents(enabledEventTypes);
     setEvents({ ...events, enabledEventTypes });
   };
 

js/apps/admin-ui/src/realm-settings/localization/RealmOverrides.tsx

@@ -147,7 +147,7 @@ export const RealmOverrides = ({
       }
     };
 
-    fetchLocalizationTexts().then((translations) => {
+    void fetchLocalizationTexts().then((translations) => {
       const updatedRows: IRow[] = translations.map(
         (translation): IRow => ({
           rowEditBtnAriaLabel: () =>
@@ -221,7 +221,7 @@ export const RealmOverrides = ({
       refreshTable();
       translationForm.setValue("key", "");
       translationForm.setValue("value", "");
-      i18n.reloadResources();
+      await i18n.reloadResources();
 
       addAlert(t("addTranslationSuccess"), AlertVariant.success);
     } catch (error) {
@@ -321,7 +321,7 @@ export const RealmOverrides = ({
         },
         value,
       );
-      i18n.reloadResources();
+      await i18n.reloadResources();
 
       addAlert(t("updateTranslationSuccess"), AlertVariant.success);
       setTableRows(newRows);
@@ -341,8 +341,8 @@ export const RealmOverrides = ({
       {addTranslationModalOpen && (
         <AddTranslationModal
           handleModalToggle={handleModalToggle}
-          save={(pair: any) => {
+          save={async (pair: any) => {
-            addKeyValue(pair);
+            await addKeyValue(pair);
             handleModalToggle();
           }}
           form={translationForm}
@@ -517,8 +517,8 @@ export const RealmOverrides = ({
                     <Form
                       isHorizontal
                       className="kc-form-translationValue"
-                      onSubmit={handleSubmit(() => {
+                      onSubmit={handleSubmit(async () => {
-                        onSubmit(formValue, rowIndex);
+                        await onSubmit(formValue, rowIndex);
                       })}
                     >
                       <FormGroup

js/apps/admin-ui/src/realm-settings/themes/ImageUpload.tsx

@@ -25,7 +25,7 @@ export const ImageUpload = ({ name, onChange }: ImageUploadProps) => {
     });
 
   if (file) {
-    fileToDataUri(file).then((dataUri) => {
+    void fileToDataUri(file).then((dataUri) => {
       setDataUri(dataUri);
       onChange?.(dataUri);
     });
@@ -35,7 +35,7 @@ export const ImageUpload = ({ name, onChange }: ImageUploadProps) => {
   useEffect(() => {
     (() => {
       if (loadedFile) {
-        fileToDataUri(loadedFile).then((dataUri) => {
+        void fileToDataUri(loadedFile).then((dataUri) => {
           setDataUri(dataUri);
         });
       }

js/apps/admin-ui/src/realm-settings/themes/ThemeColors.tsx

@@ -144,8 +144,8 @@ export const ThemeColors = ({ realm, save, theme }: ThemeColorsProps) => {
     <>
       {open && (
         <FileNameDialog
-          onSave={(name) => {
+          onSave={async (name) => {
-            handleSubmit((data) => convert({ ...data, name }))();
+            await handleSubmit((data) => convert({ ...data, name }))();
             setOpen(false);
           }}
           onClose={toggle}

js/apps/admin-ui/src/realm-settings/themes/ThemesTab.tsx

@@ -134,7 +134,7 @@ styles=css/login.css css/theme-styles.css
       }
       `,
     );
-    zip.generateAsync({ type: "blob" }).then((content) => {
+    await zip.generateAsync({ type: "blob" }).then((content) => {
       const url = URL.createObjectURL(content);
       const a = document.createElement("a");
       a.href = url;

js/apps/admin-ui/src/realm-settings/user-profile/AttributesGroupTab.tsx

@@ -104,7 +104,7 @@ export const AttributesGroupTab = ({
           }),
         );
 
-        save(
+        await save(
           { ...config, groups },
           {
             successMessageKey: "deleteSuccess",

js/apps/admin-ui/src/realm-settings/user-profile/AttributesTab.tsx

@@ -102,7 +102,7 @@ export const AttributesTab = ({ setTableData }: AttributesTabProps) => {
           (attribute) => attribute.name !== attributeToDelete,
         );
 
-        save(
+        await save(
           { ...config, attributes: updatedAttributes, groups: config.groups },
           {
             successMessageKey: "deleteAttributeSuccess",
@@ -139,7 +139,7 @@ export const AttributesTab = ({ setTableData }: AttributesTabProps) => {
     attributes.splice(fromIndex, 1);
     attributes.splice(newIndex, 0, movedAttribute);
 
-    save(
+    await save(
       { attributes, groups },
       {
         successMessageKey: "updatedUserProfileSuccess",
@@ -228,7 +228,7 @@ export const AttributesTab = ({ setTableData }: AttributesTabProps) => {
           const dragged = attributes[oldIndex];
           if (!dragged.name) return;
 
-          executeMove(dragged, newIndex);
+          await executeMove(dragged, newIndex);
         }}
         actions={[
           {

js/apps/admin-ui/src/sessions/RevocationModal.tsx

@@ -114,8 +114,8 @@ export const RevocationModal = ({
           data-testid="set-to-now-button"
           key="set-to-now"
           variant="tertiary"
-          onClick={() => {
+          onClick={async () => {
-            setToNow();
+            await setToNow();
             handleModalToggle();
           }}
           form="revocation-modal-form"
@@ -126,8 +126,8 @@ export const RevocationModal = ({
           data-testid="clear-not-before-button"
           key="clear"
           variant="tertiary"
-          onClick={() => {
+          onClick={async () => {
-            clearNotBefore();
+            await clearNotBefore();
             handleModalToggle();
           }}
           form="revocation-modal-form"
@@ -138,8 +138,8 @@ export const RevocationModal = ({
           data-testid="modal-test-connection-button"
           key="push"
           variant="secondary"
-          onClick={() => {
+          onClick={async () => {
-            push();
+            await push();
             handleModalToggle();
           }}
           form="revocation-modal-form"

js/apps/admin-ui/src/user-federation/ldap/mappers/LdapMapperDetails.tsx

@@ -208,8 +208,8 @@ export default function LdapMapperDetails() {
                   ? [
                       <DropdownItem
                         key="ldapSync"
-                        onClick={() => {
+                        onClick={async () => {
-                          sync("keycloakToFed");
+                          await sync("keycloakToFed");
                         }}
                       >
                         {t(mapper.metadata.keycloakToFedSyncMessage)}

js/apps/admin-ui/src/user/EditUser.tsx

@@ -230,8 +230,8 @@ export default function EditUser() {
     titleKey: "disableConfirmUserTitle",
     messageKey: "disableConfirmUser",
     continueButtonLabel: "disable",
-    onConfirm: () => {
+    onConfirm: async () => {
-      save({
+      await save({
         ...toUserFormFields(user!),
         enabled: false,
       });
@@ -326,11 +326,11 @@ export default function EditUser() {
             {t("delete")}
           </DropdownItem>,
         ]}
-        onToggle={(value) => {
+        onToggle={async (value) => {
           if (!value) {
             toggleDisableDialog();
           } else {
-            save({
+            await save({
               ...toUserFormFields(user),
               enabled: value,
             });

js/apps/admin-ui/src/user/UserCredentials.tsx

@@ -263,9 +263,9 @@ export const UserCredentials = ({ user, setUser }: UserCredentialsProps) => {
     );
   };
 
-  const onDrop = (evt: ReactDragEvent) => {
+  const onDrop = async (evt: ReactDragEvent) => {
     if (isValidDrop(evt)) {
-      onDragFinish(state.draggedItemId, state.tempItemOrder);
+      await onDragFinish(state.draggedItemId, state.tempItemOrder);
     } else {
       onDragCancel();
     }

js/apps/admin-ui/src/user/UserForm.tsx

@@ -168,11 +168,11 @@ export const UserForm = ({
               ok: "join",
             }}
             canBrowse={isManager}
-            onConfirm={(groups) => {
+            onConfirm={async (groups) => {
               if (user?.id) {
-                addGroups(groups || []);
+                await addGroups(groups || []);
               } else {
-                addChips(groups || []);
+                await addChips(groups || []);
               }
 
               setOpen(false);
@@ -305,8 +305,8 @@ export const UserForm = ({
             <Switch
               data-testid="user-locked-switch"
               id="temporaryLocked"
-              onChange={(_event, value) => {
+              onChange={async (_event, value) => {
-                unLockUser();
+                await unLockUser();
                 setLocked(value);
               }}
               isChecked={locked}

js/apps/admin-ui/src/user/user-credentials/ResetCredentialDialog.tsx

@@ -72,8 +72,8 @@ export const ResetCredentialDialog = ({
       onCancel={onClose}
       toggleDialog={onClose}
       continueButtonLabel="credentialResetConfirm"
-      onConfirm={() => {
+      onConfirm={async () => {
-        handleSubmit(sendCredentialsResetEmail)();
+        await handleSubmit(sendCredentialsResetEmail)();
       }}
       confirmButtonDisabled={!resetIsNotDisabled}
     >

js/apps/admin-ui/src/user/user-credentials/ResetPasswordDialog.tsx

@@ -157,8 +157,8 @@ export const ResetPasswordDialog = ({
             <PasswordInput
               data-testid="passwordField"
               id="password"
-              onChange={(e) => {
+              onChange={async (e) => {
-                onChange(e);
+                await onChange(e);
                 if (passwordConfirmation !== e.currentTarget.value) {
                   setError("passwordConfirmation", {
                     message: t("confirmPasswordDoesNotMatch").toString(),

js/apps/admin-ui/src/utils/useQueryPermission.ts

@@ -26,7 +26,7 @@ export default function useQueryPermission(
     setStatus(null);
     setPlainStatus(null);
 
-    navigator.permissions.query({ name }).then((newStatus) => {
+    void navigator.permissions.query({ name }).then((newStatus) => {
       setStatus(newStatus);
       updatePlainStatus(newStatus);
     });

js/apps/admin-ui/test/identity-providers/main.ts

@@ -90,14 +90,14 @@ async function assertElementExists(
 }
 
 export async function assertJwksUrlExists(page: Page, exist: boolean = true) {
-  assertElementExists(page, "[data-testid='config.jwksUrl']", exist);
+  await assertElementExists(page, "[data-testid='config.jwksUrl']", exist);
 }
 
 export async function assertPkceMethodExists(
   page: Page,
   exist: boolean = true,
 ) {
-  assertElementExists(page, "#config\\.pkceMethod", exist);
+  await assertElementExists(page, "#config\\.pkceMethod", exist);
 }
 
 export async function goToMappersTab(page: Page) {

js/apps/admin-ui/test/sessions/main.ts

@@ -11,7 +11,7 @@ export async function assertRowHasSignOutKebab(page: Page, row: string) {
 }
 
 export async function clickNotBefore(page: Page) {
-  page.getByTestId("clear-not-before-button").click();
+  await page.getByTestId("clear-not-before-button").click();
 }
 
 export async function assertNotBeforeValue(page: Page, value: string) {

js/apps/admin-ui/test/users/main.ts

@@ -9,7 +9,7 @@ export async function clickSaveButton(page: Page) {
 }
 
 export async function clickAddUserButton(page: Page) {
-  page.getByTestId("no-users-found-empty-action").click();
+  await page.getByTestId("no-users-found-empty-action").click();
 }
 
 export async function fillUserForm(

js/apps/admin-ui/test/utils/sidebar.ts

@@ -14,7 +14,7 @@ export async function goToRealms(page: Page) {
 }
 
 export async function goToOrganizations(page: Page) {
-  page.getByTestId("nav-item-organizations").click();
+  await page.getByTestId("nav-item-organizations").click();
 }
 
 export async function goToClients(page: Page) {

js/eslint.config.js

@@ -66,7 +66,6 @@ export default tseslint.config(
       "@typescript-eslint/no-dynamic-delete": "off",
       "@typescript-eslint/no-explicit-any": "off",
       "@typescript-eslint/no-extraneous-class": "off",
-      "@typescript-eslint/no-floating-promises": "off",
       "@typescript-eslint/no-inferrable-types": "off",
       "@typescript-eslint/no-invalid-void-type": "off",
       "@typescript-eslint/no-misused-promises": "off",

js/libs/keycloak-admin-client/test/realms.spec.ts

@@ -158,7 +158,7 @@ describe("Realms", () => {
     });
 
     after(async () => {
-      deleteRealm(kcAdminClient, currentRealmName);
+      await deleteRealm(kcAdminClient, currentRealmName);
     });
 
     it("list client initial access", async () => {
@@ -211,7 +211,7 @@ describe("Realms", () => {
     });
 
     after(async () => {
-      deleteRealm(kcAdminClient, currentRealmName);
+      await deleteRealm(kcAdminClient, currentRealmName);
     });
 
     it("add group to default groups", async () => {
@@ -321,7 +321,7 @@ describe("Realms", () => {
     });
 
     after(async () => {
-      deleteRealm(kcAdminClient, currentRealmName);
+      await deleteRealm(kcAdminClient, currentRealmName);
     });
   });
 
@@ -360,7 +360,7 @@ describe("Realms", () => {
     });
 
     after(async () => {
-      deleteRealm(kcAdminClient, currentRealmName);
+      await deleteRealm(kcAdminClient, currentRealmName);
     });
   });
 
@@ -396,7 +396,7 @@ describe("Realms", () => {
     });
 
     after(async () => {
-      deleteRealm(kcAdminClient, currentRealmName);
+      await deleteRealm(kcAdminClient, currentRealmName);
     });
   });