External-Mirrors/keycloak
2
0
Fork 0
mirror of https://github.com/keycloak/keycloak.git synced 2026-01-10 15:32:05 -03:30
Code Issues Packages Projects Releases Wiki Activity

Connect to primary PostgreSQL instance by default (#36330)

Browse Source 
Closes #24493

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
This commit is contained in:
Alexander Schwartz 2025-01-14 10:24:52 +01:00 committed by GitHub
parent fde4a14901
commit 69d36fcd65
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 30 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
model/jpa/src/main/java/org/keycloak/connections/jpa/DefaultJpaConnectionProviderFactory.java
View File

@ -178,9 +178,7 @@ public class DefaultJpaConnectionProviderFactory implements JpaConnectionProvide
} else {
String url = config.get("url");
String driver = config.get("driver");
if (driver.equals("org.h2.Driver")) {
url = addH2NonKeywords(url);
}
url = augmentJdbcUrl(driver, url);
properties.put(AvailableSettings.JAKARTA_JDBC_URL, url);
properties.put(AvailableSettings.JAKARTA_JDBC_DRIVER, driver);
@ -373,9 +371,7 @@ public class DefaultJpaConnectionProviderFactory implements JpaConnectionProvide
} else {
String url = config.get("url");
String driver = config.get("driver");
if (driver.equals("org.h2.Driver")) {
url = addH2NonKeywords(url);
}
url = augmentJdbcUrl(driver, url);
Class.forName(driver);
return DriverManager.getConnection(StringPropertyReplacer.replaceProperties(url, System.getProperties()), config.get("user"), config.get("password"));
}
@ -384,6 +380,16 @@ public class DefaultJpaConnectionProviderFactory implements JpaConnectionProvide
}
}
private String augmentJdbcUrl(String driver, String url) {
if (driver.equals("org.postgresql.xa.PGXADataSource") || driver.equals("org.postgresql.Driver")) {
url = addPostgreSQLKeywords(url);
}
if (driver.equals("org.h2.Driver")) {
url = addH2NonKeywords(url);
}
return url;
}
@Override
public String getSchema() {
String schema = config.get("schema");
@ -435,4 +441,22 @@ public class DefaultJpaConnectionProviderFactory implements JpaConnectionProvide
return jdbcUrl;
}
/**
* For a PostgreSQL cluster, Keycloak would need to connect to the primary node that is writable.
* The `targetServerType` should avoid connecting to a reader instance accidentally during node failover.
* @return JDBC URL with <code>targetServerType=primary</code> appended if the URL doesn't contain <code>targetServerType=</code> yet
*/
private String addPostgreSQLKeywords(String jdbcUrl) {
if (!jdbcUrl.contains("targetServerType=")) {
if (jdbcUrl.contains("?")) {
jdbcUrl = jdbcUrl + "&";
} else {
jdbcUrl = jdbcUrl + "?";
}
jdbcUrl = jdbcUrl + "targetServerType=primary";
}
return jdbcUrl;
}
}