External-Mirrors/keycloak
2
0
Fork 0
mirror of https://github.com/keycloak/keycloak.git synced 2026-01-09 23:12:06 -03:30
Code Issues Packages Projects Releases Wiki Activity

Use all 1s for ordered list in CONTRIBUTING.md for cleaner blame/diff (#35255)

Browse Source 
Closes #35254

Previously the 5 was repeated twice (presumably to keep diff small)
but that is super confusing. Better to use 1s for everything.

Signed-off-by: Cornelius Roemer <cornelius.roemer@gmail.com>
This commit is contained in:
Cornelius Roemer 2024-11-25 08:20:11 +01:00 committed by GitHub
parent 0eb0281bf2
commit 6bfc54a63d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
CONTRIBUTING.md
View File

@ -16,14 +16,14 @@ discussion first. For minor changes you can skip this part and go straight ahead
Here's a quick checklist for a good PR, more details below:
1. A discussion around the change (https://github.com/keycloak/keycloak/discussions/categories/ideas)
2. A GitHub Issue with a good description associated with the PR
3. One feature/change per PR
4. One commit per PR
5. PR rebased on main (`git rebase`, not `git pull`)
5. [Good descriptive commit message, with link to issue](#commit-messages-and-issue-linking)
6. No changes to code not directly related to your PR
7. Includes functional/integration test
8. Includes documentation
1. A GitHub Issue with a good description associated with the PR
1. One feature/change per PR
1. One commit per PR
1. PR rebased on main (`git rebase`, not `git pull`)
1. [Good descriptive commit message, with link to issue](#commit-messages-and-issue-linking)
1. No changes to code not directly related to your PR
1. Includes functional/integration test
1. Includes documentation
Once you have submitted your PR please monitor it for comments/feedback. We reserve the right to close inactive PRs if
you do not respond within 2 weeks (bear in mind you can always open a new PR if it is closed due to inactivity).