External-Mirrors/keycloak
2
0
Fork 0
mirror of https://github.com/keycloak/keycloak.git synced 2026-01-10 15:32:05 -03:30
Code Issues Packages Projects Releases Wiki Activity

Forward LOGIN_HINT of authentication session with identity-provider-redirector

Browse Source 
Fixes keycloak#36396

Signed-off-by: Oliver Cremerius <antikalk@users.noreply.github.com>
This commit is contained in:
Oliver 2025-01-13 17:56:36 +01:00 committed by Marek Posolda
parent d475c5aecc
commit af40a4db19
4 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
services/src/main/java/org/keycloak/authentication/authenticators/browser/IdentityProviderAuthenticator.java
View File

@ -75,7 +75,8 @@ public class IdentityProviderAuthenticator implements Authenticator {
}
protected void redirect(AuthenticationFlowContext context, String providerId) {
redirect(context, providerId, null);
String loginHint = context.getAuthenticationSession().getClientNote(OIDCLoginProtocol.LOGIN_HINT_PARAM);
redirect(context, providerId, loginHint);
}
protected void redirect(AuthenticationFlowContext context, String providerId, String loginHint) {

20
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/broker/AbstractDefaultIdpTest.java
View File

@ -134,6 +134,26 @@ public abstract class AbstractDefaultIdpTest extends AbstractInitializedBaseBrok
assertEquals(expectedErrorMessageOnLoginScreen, UIUtils.getTextFromElement(errorElement));
}
protected void testLoginHintForwarded() {
// Set the Default Identity Provider option to the remote IdP name
configureFlow(getBrokerConfiguration().getIDPAlias());
String username = "all-info-set@localhost.com";
String urlEncodedUsername = "all-info-set%40localhost.com";
createUser(bc.providerRealmName(), username, "password", "FirstName");
// Navigate to the auth page of consumer realm
oauth.realm(bc.consumerRealmName()).client("broker-app").loginForm().loginHint(username).open();
waitForPage(driver, "sign in to", true);
// Make sure we got redirected to the remote IdP (provider) automatically
Assert.assertTrue("Driver should be on the provider realm page right now",
driver.getCurrentUrl().contains("/auth/realms/" + bc.providerRealmName() + "/"));
Assert.assertTrue("Provider page should contain login_hint parameter",
driver.getCurrentUrl().contains("login_hint=" + urlEncodedUsername));
}
protected void configureFlow(String defaultIdpValue) {
String newFlowAlias;

1
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/broker/KcOidcBrokerConfiguration.java
View File

@ -201,6 +201,7 @@ public class KcOidcBrokerConfiguration implements BrokerConfiguration {
config.put("clientId", CLIENT_ID);
config.put("clientSecret", CLIENT_SECRET);
config.put("prompt", "login");
config.put("loginHint", "true");
config.put(OIDCIdentityProviderConfig.ISSUER, getProviderRoot() + "/auth/realms/" + REALM_PROV_NAME);
config.put("authorizationUrl", getProviderRoot() + "/auth/realms/" + REALM_PROV_NAME + "/protocol/openid-connect/auth");
config.put("tokenUrl", getProviderRoot() + "/auth/realms/" + REALM_PROV_NAME + "/protocol/openid-connect/token");

6
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/broker/KcOidcDefaultIdpTest.java
View File

@ -33,6 +33,12 @@ public class KcOidcDefaultIdpTest extends AbstractDefaultIdpTest {
testDefaultIdpSetTriedAndReturnedError("Access denied when authenticating with kc-oidc-idp");
}
// Issue 36396
@Test
public void testLoginHintIsForwarded() {
testLoginHintForwarded();
}
@Override
protected BrokerConfiguration getBrokerConfiguration() {
return new KcOidcBrokerConfiguration();