From af54d6469d62d83b1e1a83ca485249c12cf108be Mon Sep 17 00:00:00 2001
From: Alexander Schwartz <aschwart@redhat.com>
Date: Thu, 12 Dec 2024 10:05:39 +0100
Subject: [PATCH] Remove unused LDAP properties

Closes #35854

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
---
 .../org/keycloak/storage/ldap/LDAPConfig.java | 28 -------------------
 .../ldap/LDAPStorageProviderFactory.java      | 21 --------------
 .../org/keycloak/models/LDAPConstants.java    |  8 ------
 3 files changed, 57 deletions(-)

diff --git a/federation/ldap/src/main/java/org/keycloak/storage/ldap/LDAPConfig.java b/federation/ldap/src/main/java/org/keycloak/storage/ldap/LDAPConfig.java
index adce4f378a5..92f6b1a776c 100644
--- a/federation/ldap/src/main/java/org/keycloak/storage/ldap/LDAPConfig.java
+++ b/federation/ldap/src/main/java/org/keycloak/storage/ldap/LDAPConfig.java
@@ -132,34 +132,6 @@ public class LDAPConfig {
         }
     }
 
-    public String getConnectionPoolingAuthentication() {
-        return config.getFirst(LDAPConstants.CONNECTION_POOLING_AUTHENTICATION);
-    }
-
-    public String getConnectionPoolingDebug() {
-        return config.getFirst(LDAPConstants.CONNECTION_POOLING_DEBUG);
-    }
-
-    public String getConnectionPoolingInitSize() {
-        return config.getFirst(LDAPConstants.CONNECTION_POOLING_INITSIZE);
-    }
-
-    public String getConnectionPoolingMaxSize() {
-        return config.getFirst(LDAPConstants.CONNECTION_POOLING_MAXSIZE);
-    }
-
-    public String getConnectionPoolingPrefSize() {
-        return config.getFirst(LDAPConstants.CONNECTION_POOLING_PREFSIZE);
-    }
-
-    public String getConnectionPoolingProtocol() {
-        return config.getFirst(LDAPConstants.CONNECTION_POOLING_PROTOCOL);
-    }
-
-    public String getConnectionPoolingTimeout() {
-        return config.getFirst(LDAPConstants.CONNECTION_POOLING_TIMEOUT);
-    }
-
     public String getConnectionTimeout() {
         return config.getFirst(LDAPConstants.CONNECTION_TIMEOUT);
     }
diff --git a/federation/ldap/src/main/java/org/keycloak/storage/ldap/LDAPStorageProviderFactory.java b/federation/ldap/src/main/java/org/keycloak/storage/ldap/LDAPStorageProviderFactory.java
index 7c69e5cdfd6..7941875ab86 100755
--- a/federation/ldap/src/main/java/org/keycloak/storage/ldap/LDAPStorageProviderFactory.java
+++ b/federation/ldap/src/main/java/org/keycloak/storage/ldap/LDAPStorageProviderFactory.java
@@ -174,27 +174,6 @@ public class LDAPStorageProviderFactory implements UserStorageProviderFactory<LD
                 .type(ProviderConfigProperty.BOOLEAN_TYPE)
                 .defaultValue("true")
                 .add()
-                .property().name(LDAPConstants.CONNECTION_POOLING_AUTHENTICATION)
-                .type(ProviderConfigProperty.STRING_TYPE)
-                .add()
-                .property().name(LDAPConstants.CONNECTION_POOLING_DEBUG)
-                .type(ProviderConfigProperty.STRING_TYPE)
-                .add()
-                .property().name(LDAPConstants.CONNECTION_POOLING_INITSIZE)
-                .type(ProviderConfigProperty.STRING_TYPE)
-                .add()
-                .property().name(LDAPConstants.CONNECTION_POOLING_MAXSIZE)
-                .type(ProviderConfigProperty.STRING_TYPE)
-                .add()
-                .property().name(LDAPConstants.CONNECTION_POOLING_PREFSIZE)
-                .type(ProviderConfigProperty.STRING_TYPE)
-                .add()
-                .property().name(LDAPConstants.CONNECTION_POOLING_PROTOCOL)
-                .type(ProviderConfigProperty.STRING_TYPE)
-                .add()
-                .property().name(LDAPConstants.CONNECTION_POOLING_TIMEOUT)
-                .type(ProviderConfigProperty.STRING_TYPE)
-                .add()
                 .property().name(LDAPConstants.CONNECTION_TIMEOUT)
                 .type(ProviderConfigProperty.STRING_TYPE)
                 .add()
diff --git a/server-spi-private/src/main/java/org/keycloak/models/LDAPConstants.java b/server-spi-private/src/main/java/org/keycloak/models/LDAPConstants.java
index 9dfd1478b73..290debc2fb6 100644
--- a/server-spi-private/src/main/java/org/keycloak/models/LDAPConstants.java
+++ b/server-spi-private/src/main/java/org/keycloak/models/LDAPConstants.java
@@ -20,7 +20,6 @@ package org.keycloak.models;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
-import java.util.Map;
 
 /**
  * @author <a href="mailto:mposolda@redhat.com">Marek Posolda</a>
@@ -68,13 +67,6 @@ public class LDAPConstants {
 
     public static final String SEARCH_SCOPE = "searchScope";
     public static final String CONNECTION_POOLING = "connectionPooling";
-    public static final String CONNECTION_POOLING_AUTHENTICATION = "connectionPoolingAuthentication";
-    public static final String CONNECTION_POOLING_DEBUG = "connectionPoolingDebug";
-    public static final String CONNECTION_POOLING_INITSIZE = "connectionPoolingInitSize";
-    public static final String CONNECTION_POOLING_MAXSIZE = "connectionPoolingMaxSize";
-    public static final String CONNECTION_POOLING_PREFSIZE = "connectionPoolingPrefSize";
-    public static final String CONNECTION_POOLING_PROTOCOL = "connectionPoolingProtocol";
-    public static final String CONNECTION_POOLING_TIMEOUT = "connectionPoolingTimeout";
     public static final String CONNECTION_TIMEOUT = "connectionTimeout";
     public static final String READ_TIMEOUT = "readTimeout";
     // Could be discovered by rootDse supportedControl: 1.2.840.113556.1.4.319