diff --git a/quarkus/tests/integration/src/test/java/org/keycloak/it/cli/dist/FipsDistTest.java b/quarkus/tests/integration/src/test/java/org/keycloak/it/cli/dist/FipsDistTest.java index c5860a6e4a1..ed7e99d7f94 100644 --- a/quarkus/tests/integration/src/test/java/org/keycloak/it/cli/dist/FipsDistTest.java +++ b/quarkus/tests/integration/src/test/java/org/keycloak/it/cli/dist/FipsDistTest.java @@ -77,7 +77,6 @@ public class FipsDistTest { runOnFipsEnabledDistribution(dist, () -> { dist.copyOrReplaceFileFromClasspath("/server.keystore", Path.of("conf", "server.keystore")); CLIResult cliResult = dist.run("start", "--fips-mode=strict"); - dist.assertStopped(); cliResult.assertMessage("ERROR: java.lang.IllegalArgumentException: malformed sequence"); }); } @@ -125,7 +124,6 @@ public class FipsDistTest { runOnFipsEnabledDistribution(dist, () -> { dist.copyOrReplaceFileFromClasspath("/server.keystore.pkcs12", Path.of("conf", "server.keystore")); CLIResult cliResult = dist.run("start", "--fips-mode=strict", "--https-key-store-password=passwordpassword"); - dist.assertStopped(); cliResult.assertMessage("ERROR: java.lang.IllegalArgumentException: malformed sequence"); }); } diff --git a/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/KeycloakDistributionDecorator.java b/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/KeycloakDistributionDecorator.java index 85704f9b9bb..efc42f8f948 100644 --- a/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/KeycloakDistributionDecorator.java +++ b/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/KeycloakDistributionDecorator.java @@ -121,11 +121,6 @@ public class KeycloakDistributionDecorator implements KeycloakDistribution { delegate.copyOrReplaceFile(file, targetFile); } - @Override - public void assertStopped() { - delegate.assertStopped(); - } - @Override public void setRequestPort() { delegate.setRequestPort(); diff --git a/quarkus/tests/junit5/src/main/java/org/keycloak/it/utils/DockerKeycloakDistribution.java b/quarkus/tests/junit5/src/main/java/org/keycloak/it/utils/DockerKeycloakDistribution.java index c4c62e7b968..40d81aa33ed 100644 --- a/quarkus/tests/junit5/src/main/java/org/keycloak/it/utils/DockerKeycloakDistribution.java +++ b/quarkus/tests/junit5/src/main/java/org/keycloak/it/utils/DockerKeycloakDistribution.java @@ -269,8 +269,4 @@ public final class DockerKeycloakDistribution implements KeycloakDistribution { throw new IllegalArgumentException("Not a " + type + " type"); } - @Override - public void assertStopped() { - // not implemented - } } diff --git a/quarkus/tests/junit5/src/main/java/org/keycloak/it/utils/KeycloakDistribution.java b/quarkus/tests/junit5/src/main/java/org/keycloak/it/utils/KeycloakDistribution.java index e924dfc0c21..21775b11bca 100644 --- a/quarkus/tests/junit5/src/main/java/org/keycloak/it/utils/KeycloakDistribution.java +++ b/quarkus/tests/junit5/src/main/java/org/keycloak/it/utils/KeycloakDistribution.java @@ -28,8 +28,6 @@ public interface KeycloakDistribution { boolean isManualStop(); - void assertStopped(); - void setRequestPort(); void setRequestPort(int port); diff --git a/quarkus/tests/junit5/src/main/java/org/keycloak/it/utils/RawKeycloakDistribution.java b/quarkus/tests/junit5/src/main/java/org/keycloak/it/utils/RawKeycloakDistribution.java index a6a0fb278c4..4f8b32284f5 100644 --- a/quarkus/tests/junit5/src/main/java/org/keycloak/it/utils/RawKeycloakDistribution.java +++ b/quarkus/tests/junit5/src/main/java/org/keycloak/it/utils/RawKeycloakDistribution.java @@ -43,11 +43,9 @@ import java.util.List; import java.util.Map; import java.util.Properties; import java.util.concurrent.CompletableFuture; -import java.util.concurrent.ExecutionException; import java.util.concurrent.ExecutorService; import java.util.concurrent.Executors; import java.util.concurrent.TimeUnit; -import java.util.concurrent.TimeoutException; import java.util.concurrent.locks.LockSupport; import java.util.function.Consumer; import javax.net.ssl.HostnameVerifier; @@ -217,6 +215,7 @@ public final class RawKeycloakDistribution implements KeycloakDistribution { } catch (Exception cause) { destroyDescendantsOnWindows(keycloak, true); keycloak.destroyForcibly(); + threadDump(); throw new RuntimeException("Failed to stop the server", cause); } } @@ -304,24 +303,6 @@ public final class RawKeycloakDistribution implements KeycloakDistribution { return allArgs.toArray(String[]::new); } - @Override - public void assertStopped() { - try { - if (keycloak != null) { - keycloak.onExit().get(DEFAULT_SHUTDOWN_TIMEOUT_SECONDS, TimeUnit.SECONDS); - } - } catch (InterruptedException e) { - Thread.currentThread().interrupt(); - throw new RuntimeException(e); - } catch (ExecutionException e) { - throw new RuntimeException(e); - } catch (TimeoutException e) { - LOG.warn("Process did not exit as expected, will attempt a thread dump"); - threadDump(); - throw new RuntimeException(e); - } - } - @Override public void setRequestPort() { setRequestPort(requestPort);