diff --git a/adapters/oidc/fuse7/tomcat8/pom.xml b/adapters/oidc/fuse7/tomcat8/pom.xml
index ae094e71cec..3fbad988c7b 100644
--- a/adapters/oidc/fuse7/tomcat8/pom.xml
+++ b/adapters/oidc/fuse7/tomcat8/pom.xml
@@ -57,7 +57,7 @@
org.keycloak
- keycloak-tomcat8-adapter
+ keycloak-tomcat-adapter
provided
diff --git a/adapters/oidc/spring-boot-container-bundle/pom.xml b/adapters/oidc/spring-boot-container-bundle/pom.xml
index 67b0d2ad48f..fd83d32eb5b 100644
--- a/adapters/oidc/spring-boot-container-bundle/pom.xml
+++ b/adapters/oidc/spring-boot-container-bundle/pom.xml
@@ -12,7 +12,7 @@
org.keycloak
- keycloak-tomcat8-adapter
+ keycloak-tomcat-adapter
compile
@@ -41,7 +41,7 @@
- org.keycloak:keycloak-tomcat8-adapter
+ org.keycloak:keycloak-tomcat-adapter
org.keycloak:keycloak-undertow-adapter
org.keycloak:keycloak-jetty93-adapter
org.keycloak:keycloak-tomcat-core-adapter
diff --git a/adapters/oidc/tomcat/pom.xml b/adapters/oidc/tomcat/pom.xml
index e1551ee1e0a..ef2d7094b52 100755
--- a/adapters/oidc/tomcat/pom.xml
+++ b/adapters/oidc/tomcat/pom.xml
@@ -32,7 +32,7 @@
tomcat-core
- tomcat8
+ tomcat
diff --git a/adapters/oidc/tomcat/tomcat8/pom.xml b/adapters/oidc/tomcat/tomcat/pom.xml
similarity index 97%
rename from adapters/oidc/tomcat/tomcat8/pom.xml
rename to adapters/oidc/tomcat/tomcat/pom.xml
index 721d56980f2..922b40e511f 100755
--- a/adapters/oidc/tomcat/tomcat8/pom.xml
+++ b/adapters/oidc/tomcat/tomcat/pom.xml
@@ -26,8 +26,8 @@
4.0.0
- keycloak-tomcat8-adapter
- Keycloak Tomcat 8 Integration
+ keycloak-tomcat-adapter
+ Keycloak Tomcat Integration
1.7
1.7
diff --git a/adapters/oidc/tomcat/tomcat8/src/main/java/org/keycloak/adapters/tomcat/AuthenticatedActionsValve.java b/adapters/oidc/tomcat/tomcat/src/main/java/org/keycloak/adapters/tomcat/AuthenticatedActionsValve.java
similarity index 100%
rename from adapters/oidc/tomcat/tomcat8/src/main/java/org/keycloak/adapters/tomcat/AuthenticatedActionsValve.java
rename to adapters/oidc/tomcat/tomcat/src/main/java/org/keycloak/adapters/tomcat/AuthenticatedActionsValve.java
diff --git a/adapters/oidc/tomcat/tomcat8/src/main/java/org/keycloak/adapters/tomcat/KeycloakAuthenticatorValve.java b/adapters/oidc/tomcat/tomcat/src/main/java/org/keycloak/adapters/tomcat/KeycloakAuthenticatorValve.java
similarity index 100%
rename from adapters/oidc/tomcat/tomcat8/src/main/java/org/keycloak/adapters/tomcat/KeycloakAuthenticatorValve.java
rename to adapters/oidc/tomcat/tomcat/src/main/java/org/keycloak/adapters/tomcat/KeycloakAuthenticatorValve.java
diff --git a/adapters/oidc/tomcat/tomcat8/src/main/java/org/keycloak/adapters/tomcat/Tomcat8RequestAuthenticator.java b/adapters/oidc/tomcat/tomcat/src/main/java/org/keycloak/adapters/tomcat/TomcatRequestAuthenticator.java
similarity index 84%
rename from adapters/oidc/tomcat/tomcat8/src/main/java/org/keycloak/adapters/tomcat/Tomcat8RequestAuthenticator.java
rename to adapters/oidc/tomcat/tomcat/src/main/java/org/keycloak/adapters/tomcat/TomcatRequestAuthenticator.java
index 5829cac3445..8103959fcaa 100755
--- a/adapters/oidc/tomcat/tomcat8/src/main/java/org/keycloak/adapters/tomcat/Tomcat8RequestAuthenticator.java
+++ b/adapters/oidc/tomcat/tomcat/src/main/java/org/keycloak/adapters/tomcat/TomcatRequestAuthenticator.java
@@ -27,8 +27,8 @@ import javax.servlet.http.HttpSession;
* @author Bill Burke
* @version $Revision: 1 $
*/
-public class Tomcat8RequestAuthenticator extends CatalinaRequestAuthenticator {
- public Tomcat8RequestAuthenticator(KeycloakDeployment deployment, AdapterTokenStore tokenStore, CatalinaHttpFacade facade, Request request, GenericPrincipalFactory principalFactory) {
+public class TomcatRequestAuthenticator extends CatalinaRequestAuthenticator {
+ public TomcatRequestAuthenticator(KeycloakDeployment deployment, AdapterTokenStore tokenStore, CatalinaHttpFacade facade, Request request, GenericPrincipalFactory principalFactory) {
super(deployment, tokenStore, facade, request, principalFactory);
}
diff --git a/adapters/saml/tomcat/pom.xml b/adapters/saml/tomcat/pom.xml
index b662da1098a..43a6ef6657a 100755
--- a/adapters/saml/tomcat/pom.xml
+++ b/adapters/saml/tomcat/pom.xml
@@ -32,7 +32,7 @@
tomcat-core
- tomcat8
+ tomcat
diff --git a/adapters/saml/tomcat/tomcat8/pom.xml b/adapters/saml/tomcat/tomcat/pom.xml
similarity index 96%
rename from adapters/saml/tomcat/tomcat8/pom.xml
rename to adapters/saml/tomcat/tomcat/pom.xml
index 13af9e075fd..05c7fa0fa65 100755
--- a/adapters/saml/tomcat/tomcat8/pom.xml
+++ b/adapters/saml/tomcat/tomcat/pom.xml
@@ -26,8 +26,8 @@
4.0.0
- keycloak-saml-tomcat8-adapter
- Keycloak Tomcat 8 SAML Integration
+ keycloak-saml-tomcat-adapter
+ Keycloak Tomcat SAML Integration
1.7
1.7
diff --git a/adapters/saml/tomcat/tomcat8/src/main/java/org/keycloak/adapters/saml/tomcat/SamlAuthenticatorValve.java b/adapters/saml/tomcat/tomcat/src/main/java/org/keycloak/adapters/saml/tomcat/SamlAuthenticatorValve.java
similarity index 86%
rename from adapters/saml/tomcat/tomcat8/src/main/java/org/keycloak/adapters/saml/tomcat/SamlAuthenticatorValve.java
rename to adapters/saml/tomcat/tomcat/src/main/java/org/keycloak/adapters/saml/tomcat/SamlAuthenticatorValve.java
index caf1bf98a7c..58c041091fc 100755
--- a/adapters/saml/tomcat/tomcat8/src/main/java/org/keycloak/adapters/saml/tomcat/SamlAuthenticatorValve.java
+++ b/adapters/saml/tomcat/tomcat/src/main/java/org/keycloak/adapters/saml/tomcat/SamlAuthenticatorValve.java
@@ -44,6 +44,7 @@ public class SamlAuthenticatorValve extends AbstractSamlAuthenticatorValve {
/**
* Method called by Tomcat < 8.5.5
*/
+ @Override
public boolean authenticate(Request request, HttpServletResponse response) throws IOException {
return authenticateInternal(request, response, request.getContext().getLoginConfig());
}
@@ -51,6 +52,7 @@ public class SamlAuthenticatorValve extends AbstractSamlAuthenticatorValve {
/**
* Method called by Tomcat >= 8.5.5
*/
+ @Override
protected boolean doAuthenticate(Request request, HttpServletResponse response) throws IOException {
return this.authenticate(request, response);
}
@@ -62,16 +64,7 @@ public class SamlAuthenticatorValve extends AbstractSamlAuthenticatorValve {
if (config.getErrorPage() == null) return false;
// had to do this to get around compiler/IDE issues :(
try {
- Method method = null;
- /*
- for (Method m : getClass().getDeclaredMethods()) {
- if (m.getName().equals("forwardToErrorPage")) {
- method = m;
- break;
- }
- }
- */
- method = FormAuthenticator.class.getDeclaredMethod("forwardToErrorPage", Request.class, HttpServletResponse.class, LoginConfig.class);
+ Method method = FormAuthenticator.class.getDeclaredMethod("forwardToErrorPage", Request.class, HttpServletResponse.class, LoginConfig.class);
method.setAccessible(true);
method.invoke(this, request, response, config);
} catch (Exception e) {
@@ -80,11 +73,13 @@ public class SamlAuthenticatorValve extends AbstractSamlAuthenticatorValve {
return true;
}
+ @Override
protected void initInternal() {
StandardContext standardContext = (StandardContext) context;
standardContext.addLifecycleListener(this);
}
+ @Override
public void logout(Request request) {
logoutInternal(request);
}
@@ -102,7 +97,7 @@ public class SamlAuthenticatorValve extends AbstractSamlAuthenticatorValve {
@Override
protected SamlSessionStore createSessionStore(Request request, HttpFacade facade, SamlDeployment resolvedDeployment) {
SamlSessionStore store;
- store = new Tomcat8SamlSessionStore(userSessionManagement, createPrincipalFactory(), mapper, request, this, facade, resolvedDeployment);
+ store = new TomcatSamlSessionStore(userSessionManagement, createPrincipalFactory(), mapper, request, this, facade, resolvedDeployment);
return store;
}
diff --git a/adapters/saml/tomcat/tomcat8/src/main/java/org/keycloak/adapters/saml/tomcat/Tomcat8SamlSessionStore.java b/adapters/saml/tomcat/tomcat/src/main/java/org/keycloak/adapters/saml/tomcat/TomcatSamlSessionStore.java
similarity index 84%
rename from adapters/saml/tomcat/tomcat8/src/main/java/org/keycloak/adapters/saml/tomcat/Tomcat8SamlSessionStore.java
rename to adapters/saml/tomcat/tomcat/src/main/java/org/keycloak/adapters/saml/tomcat/TomcatSamlSessionStore.java
index 57fef3e043b..f3d852ece15 100755
--- a/adapters/saml/tomcat/tomcat8/src/main/java/org/keycloak/adapters/saml/tomcat/Tomcat8SamlSessionStore.java
+++ b/adapters/saml/tomcat/tomcat/src/main/java/org/keycloak/adapters/saml/tomcat/TomcatSamlSessionStore.java
@@ -32,8 +32,8 @@ import org.keycloak.adapters.tomcat.GenericPrincipalFactory;
* @author Bill Burke
* @version $Revision: 1 $
*/
-public class Tomcat8SamlSessionStore extends CatalinaSamlSessionStore {
- public Tomcat8SamlSessionStore(CatalinaUserSessionManagement sessionManagement, GenericPrincipalFactory principalFactory, SessionIdMapper idMapper, Request request, AbstractSamlAuthenticatorValve valve, HttpFacade facade, SamlDeployment deployment) {
+public class TomcatSamlSessionStore extends CatalinaSamlSessionStore {
+ public TomcatSamlSessionStore(CatalinaUserSessionManagement sessionManagement, GenericPrincipalFactory principalFactory, SessionIdMapper idMapper, Request request, AbstractSamlAuthenticatorValve valve, HttpFacade facade, SamlDeployment deployment) {
super(sessionManagement, principalFactory, idMapper, SessionIdMapperUpdater.DIRECT, request, valve, facade, deployment);
}
diff --git a/boms/adapter/pom.xml b/boms/adapter/pom.xml
index f8f558ba1c1..82a3a6548a5 100644
--- a/boms/adapter/pom.xml
+++ b/boms/adapter/pom.xml
@@ -66,7 +66,7 @@
org.keycloak
- keycloak-tomcat8-adapter
+ keycloak-tomcat-adapter
7.0.0-SNAPSHOT
diff --git a/distribution/adapters/pom.xml b/distribution/adapters/pom.xml
index 9ebe42cdfd6..017bc3ba7c4 100755
--- a/distribution/adapters/pom.xml
+++ b/distribution/adapters/pom.xml
@@ -47,8 +47,8 @@
+ tomcat-adapter-zip
tomcat7-adapter-zip
- tomcat8-adapter-zip
jetty92-adapter-zip
jetty93-adapter-zip
jetty94-adapter-zip
diff --git a/distribution/adapters/tomcat8-adapter-zip/assembly.xml b/distribution/adapters/tomcat-adapter-zip/assembly.xml
similarity index 95%
rename from distribution/adapters/tomcat8-adapter-zip/assembly.xml
rename to distribution/adapters/tomcat-adapter-zip/assembly.xml
index 9dc47147a18..a5a3c5601b6 100755
--- a/distribution/adapters/tomcat8-adapter-zip/assembly.xml
+++ b/distribution/adapters/tomcat-adapter-zip/assembly.xml
@@ -30,7 +30,7 @@
true
true
- org.keycloak:keycloak-tomcat8-adapter
+ org.keycloak:keycloak-tomcat-adapter
org.apache.tomcat:tomcat-servlet-api
diff --git a/distribution/adapters/tomcat8-adapter-zip/pom.xml b/distribution/adapters/tomcat-adapter-zip/pom.xml
similarity index 93%
rename from distribution/adapters/tomcat8-adapter-zip/pom.xml
rename to distribution/adapters/tomcat-adapter-zip/pom.xml
index f2e2f060ec1..4e7c067d8ad 100755
--- a/distribution/adapters/tomcat8-adapter-zip/pom.xml
+++ b/distribution/adapters/tomcat-adapter-zip/pom.xml
@@ -25,15 +25,15 @@
../../../pom.xml
- keycloak-tomcat8-adapter-dist
+ keycloak-tomcat-adapter-dist
pom
- Keycloak Tomcat 8 Adapter Distro
+ Keycloak Tomcat Adapter Distro
org.keycloak
- keycloak-tomcat8-adapter
+ keycloak-tomcat-adapter
diff --git a/distribution/downloads/src/main/resources/files b/distribution/downloads/src/main/resources/files
index a7bc4fe9844..d84fa46929d 100644
--- a/distribution/downloads/src/main/resources/files
+++ b/distribution/downloads/src/main/resources/files
@@ -11,8 +11,8 @@
keycloak-jetty93-adapter-dist
keycloak-jetty94-adapter-dist
keycloak-js-adapter-dist
+ keycloak-tomcat-adapter-dist
keycloak-tomcat7-adapter-dist
- keycloak-tomcat8-adapter-dist
keycloak-wildfly-adapter-dist
keycloak-fuse-adapter-dist
@@ -22,6 +22,6 @@
keycloak-saml-jetty92-adapter-dist
keycloak-saml-jetty93-adapter-dist
keycloak-saml-jetty94-adapter-dist
+ keycloak-saml-tomcat-adapter-dist
keycloak-saml-tomcat7-adapter-dist
- keycloak-saml-tomcat8-adapter-dist
keycloak-saml-wildfly-adapter-dist
diff --git a/distribution/saml-adapters/pom.xml b/distribution/saml-adapters/pom.xml
index 4a5dd58e6d0..9f79a0e2d91 100755
--- a/distribution/saml-adapters/pom.xml
+++ b/distribution/saml-adapters/pom.xml
@@ -47,8 +47,8 @@
jetty92-adapter-zip
jetty93-adapter-zip
jetty94-adapter-zip
+ tomcat-adapter-zip
tomcat7-adapter-zip
- tomcat8-adapter-zip
diff --git a/distribution/saml-adapters/tomcat8-adapter-zip/assembly.xml b/distribution/saml-adapters/tomcat-adapter-zip/assembly.xml
similarity index 94%
rename from distribution/saml-adapters/tomcat8-adapter-zip/assembly.xml
rename to distribution/saml-adapters/tomcat-adapter-zip/assembly.xml
index e25c17c3e9a..8fce0fa7343 100755
--- a/distribution/saml-adapters/tomcat8-adapter-zip/assembly.xml
+++ b/distribution/saml-adapters/tomcat-adapter-zip/assembly.xml
@@ -30,7 +30,7 @@
true
true
- org.keycloak:keycloak-saml-tomcat8-adapter
+ org.keycloak:keycloak-saml-tomcat-adapter
org.apache.tomcat:tomcat-servlet-api
diff --git a/distribution/saml-adapters/tomcat8-adapter-zip/pom.xml b/distribution/saml-adapters/tomcat-adapter-zip/pom.xml
similarity index 92%
rename from distribution/saml-adapters/tomcat8-adapter-zip/pom.xml
rename to distribution/saml-adapters/tomcat-adapter-zip/pom.xml
index e39c24870a5..5c6e0cc6595 100755
--- a/distribution/saml-adapters/tomcat8-adapter-zip/pom.xml
+++ b/distribution/saml-adapters/tomcat-adapter-zip/pom.xml
@@ -25,15 +25,15 @@
../../../pom.xml
- keycloak-saml-tomcat8-adapter-dist
+ keycloak-saml-tomcat-adapter-dist
pom
- Keycloak SAML Tomcat 8 Adapter Distro
+ Keycloak SAML Tomcat Adapter Distro
org.keycloak
- keycloak-saml-tomcat8-adapter
+ keycloak-saml-tomcat-adapter
diff --git a/pom.xml b/pom.xml
index b4d07cc048d..0caf3acd6f3 100755
--- a/pom.xml
+++ b/pom.xml
@@ -1006,7 +1006,7 @@
org.keycloak
- keycloak-saml-tomcat8-adapter
+ keycloak-saml-tomcat-adapter
${project.version}
@@ -1016,7 +1016,7 @@
org.keycloak
- keycloak-tomcat8-adapter
+ keycloak-tomcat-adapter
${project.version}
@@ -1260,7 +1260,7 @@
org.keycloak
- keycloak-tomcat8-adapter-dist
+ keycloak-tomcat-adapter-dist
${project.version}
zip
@@ -1320,7 +1320,7 @@
org.keycloak
- keycloak-saml-tomcat8-adapter-dist
+ keycloak-saml-tomcat-adapter-dist
${project.version}
zip
diff --git a/testsuite/integration-arquillian/servers/app-server/tomcat/pom.xml b/testsuite/integration-arquillian/servers/app-server/tomcat/pom.xml
index 27be7f5cd97..337707cb13c 100644
--- a/testsuite/integration-arquillian/servers/app-server/tomcat/pom.xml
+++ b/testsuite/integration-arquillian/servers/app-server/tomcat/pom.xml
@@ -34,13 +34,8 @@
${project.parent.basedir}/assembly.xml
${containers.home}/${app.server.tomcat.unpacked.folder.name}
${resteasy.version}
- true
- true
+ false
- 1.0.3
- 3.18.2-GA
- 7.0
- 2.2
1.0.2
1.0
1.0.0.GA
@@ -109,46 +104,6 @@
true
-
- libs-for-tomcat-7
- generate-test-resources
-
- copy
-
-
- ${skip.dependencies.for.tomcat7}
-
-
- org.jboss.resteasy
- resteasy-jaxrs
- ${tomcat.resteasy.version}
-
-
- org.scannotation
- scannotation
- ${tomcat.scannotation.version}
-
-
- org.javassist
- javassist
- ${tomcat.javassist.version}
-
-
- javax
- javaee-api
- ${tomcat.javaee-api.version}
-
-
-
- org.glassfish.web
- el-impl
- ${tomcat.org.glassfish.web.el-impl.version}
-
-
- ${app.server.tomcat.home}/lib
- true
-
-
libs-for-tomcat-8-and-9
generate-test-resources
@@ -156,7 +111,7 @@
copy
- ${skip.dependencies.for.tomcat8}
+ ${skip.dependencies.for.tomcat}
org.jboss.spec.javax.ws.rs
diff --git a/testsuite/integration-arquillian/servers/app-server/tomcat/tomcat7/pom.xml b/testsuite/integration-arquillian/servers/app-server/tomcat/tomcat7/pom.xml
index 385e11d2566..5ce358e7e8e 100644
--- a/testsuite/integration-arquillian/servers/app-server/tomcat/tomcat7/pom.xml
+++ b/testsuite/integration-arquillian/servers/app-server/tomcat/tomcat7/pom.xml
@@ -39,9 +39,14 @@
keycloak-tomcat7-adapter-dist
keycloak-saml-tomcat7-adapter-dist
+ true
+
2.3.1.GA
- false
+ 1.0.3
+ 3.18.2-GA
+ 7.0
+ 2.2
@@ -56,4 +61,53 @@
${arquillian-tomcat7-container-version}
+
+
+
+
+ maven-dependency-plugin
+
+
+ libs-for-tomcat-7
+ generate-test-resources
+
+ copy
+
+
+
+
+ org.jboss.resteasy
+ resteasy-jaxrs
+ ${tomcat.resteasy.version}
+
+
+ org.scannotation
+ scannotation
+ ${tomcat.scannotation.version}
+
+
+ org.javassist
+ javassist
+ ${tomcat.javassist.version}
+
+
+ javax
+ javaee-api
+ ${tomcat.javaee-api.version}
+
+
+
+ org.glassfish.web
+ el-impl
+ ${tomcat.org.glassfish.web.el-impl.version}
+
+
+ ${app.server.tomcat.home}/lib
+ true
+
+
+
+
+
+
diff --git a/testsuite/integration-arquillian/servers/app-server/tomcat/tomcat8/pom.xml b/testsuite/integration-arquillian/servers/app-server/tomcat/tomcat8/pom.xml
index c8c2efc3c84..86c6781bc4c 100644
--- a/testsuite/integration-arquillian/servers/app-server/tomcat/tomcat8/pom.xml
+++ b/testsuite/integration-arquillian/servers/app-server/tomcat/tomcat8/pom.xml
@@ -36,8 +36,8 @@
${tomcat8.version}
apache-tomcat-${tomcat8.version}
- keycloak-tomcat8-adapter-dist
- keycloak-saml-tomcat8-adapter-dist
+ keycloak-tomcat-adapter-dist
+ keycloak-saml-tomcat-adapter-dist
false
diff --git a/testsuite/integration-arquillian/servers/app-server/tomcat/tomcat9/pom.xml b/testsuite/integration-arquillian/servers/app-server/tomcat/tomcat9/pom.xml
index d0028254d92..a7af9f31a17 100644
--- a/testsuite/integration-arquillian/servers/app-server/tomcat/tomcat9/pom.xml
+++ b/testsuite/integration-arquillian/servers/app-server/tomcat/tomcat9/pom.xml
@@ -36,9 +36,8 @@
${tomcat9.version}
apache-tomcat-${tomcat9.version}
-
- keycloak-tomcat8-adapter-dist
- keycloak-saml-tomcat8-adapter-dist
+ keycloak-tomcat-adapter-dist
+ keycloak-saml-tomcat-adapter-dist
false
diff --git a/testsuite/integration-arquillian/test-apps/spring-boot-adapter-app/pom.xml b/testsuite/integration-arquillian/test-apps/spring-boot-adapter-app/pom.xml
index a88211a755e..a604c274843 100644
--- a/testsuite/integration-arquillian/test-apps/spring-boot-adapter-app/pom.xml
+++ b/testsuite/integration-arquillian/test-apps/spring-boot-adapter-app/pom.xml
@@ -18,7 +18,7 @@
${jetty94.version}
false
- keycloak-tomcat8-adapter
+ keycloak-tomcat-adapter