From d91688198c9c1e0313880b2ab67056aa89e00a5c Mon Sep 17 00:00:00 2001 From: Anchels Date: Mon, 26 May 2025 09:38:21 +0000 Subject: [PATCH] Removed dead local stores Closes #39698 Signed-off-by: Anchels --- .../java/org/keycloak/saml/BaseSAML2BindingBuilder.java | 2 +- .../saml/processing/core/parsers/util/SAML11ParserUtil.java | 6 +++--- .../java/org/keycloak/validate/validators/UriValidator.java | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/saml-core/src/main/java/org/keycloak/saml/BaseSAML2BindingBuilder.java b/saml-core/src/main/java/org/keycloak/saml/BaseSAML2BindingBuilder.java index 81c3ee1c7c2..516ef4f79c1 100755 --- a/saml-core/src/main/java/org/keycloak/saml/BaseSAML2BindingBuilder.java +++ b/saml-core/src/main/java/org/keycloak/saml/BaseSAML2BindingBuilder.java @@ -426,7 +426,7 @@ public class BaseSAML2BindingBuilder { rawQuery = rawQuery.substring(pos + 1); } Signature signature = signatureAlgorithm.createSignature(); - byte[] sig = new byte[0]; + byte[] sig = null; try { signature.initSign(signingKeyPair.getPrivate()); signature.update(rawQuery.getBytes(GeneralConstants.SAML_CHARSET)); diff --git a/saml-core/src/main/java/org/keycloak/saml/processing/core/parsers/util/SAML11ParserUtil.java b/saml-core/src/main/java/org/keycloak/saml/processing/core/parsers/util/SAML11ParserUtil.java index 6f93ecdb367..56e7ca9a352 100755 --- a/saml-core/src/main/java/org/keycloak/saml/processing/core/parsers/util/SAML11ParserUtil.java +++ b/saml-core/src/main/java/org/keycloak/saml/processing/core/parsers/util/SAML11ParserUtil.java @@ -545,7 +545,7 @@ public class SAML11ParserUtil { if (xmlEvent instanceof EndElement) { tag = StaxParserUtil.getElementName((EndElement) xmlEvent); if (tag.equals(WSTrustConstants.XMLDSig.KEYINFO)) { - xmlEvent = StaxParserUtil.getNextEndElement(xmlEventReader); + StaxParserUtil.getNextEndElement(xmlEventReader); break; } else throw logger.parserUnknownEndElement(tag, xmlEvent.getLocation()); @@ -606,7 +606,7 @@ public class SAML11ParserUtil { if (xmlEvent instanceof EndElement) { tag = StaxParserUtil.getElementName((EndElement) xmlEvent); if (tag.equals(WSTrustConstants.XMLDSig.RSA_KEYVALUE)) { - xmlEvent = StaxParserUtil.getNextEndElement(xmlEventReader); + StaxParserUtil.getNextEndElement(xmlEventReader); break; } else throw logger.parserUnknownEndElement(tag, xmlEvent.getLocation()); @@ -805,4 +805,4 @@ public class SAML11ParserUtil { } return query; } -} \ No newline at end of file +} diff --git a/server-spi-private/src/main/java/org/keycloak/validate/validators/UriValidator.java b/server-spi-private/src/main/java/org/keycloak/validate/validators/UriValidator.java index f114ae85e80..244797c5214 100644 --- a/server-spi-private/src/main/java/org/keycloak/validate/validators/UriValidator.java +++ b/server-spi-private/src/main/java/org/keycloak/validate/validators/UriValidator.java @@ -163,7 +163,7 @@ public class UriValidator extends AbstractSimpleValidator implements ConfiguredP // This cannot be moved higher because it acts on differently based on environment (e.g. sometimes it checks // scheme, sometimes it doesn't). if (requireValidUrl && valid) { - URL ignored = uri.toURL(); // throws an exception + uri.toURL(); // throws an exception } return valid;