Fix ansible-lint E305 (#6459)

roles/kubernetes/kubeadm/tasks/main.yml

@@ -131,8 +131,8 @@
     group: root
     mode: "0644"
 
-- name: Restart all kube-proxy pods to ensure that they load the new configmap  # noqa 305
-  shell: "{{ bin_dir }}/kubectl --kubeconfig {{ kube_config_dir }}/admin.conf delete pod -n kube-system -l k8s-app=kube-proxy --force --grace-period=0"
+- name: Restart all kube-proxy pods to ensure that they load the new configmap
+  command: "{{ bin_dir }}/kubectl --kubeconfig {{ kube_config_dir }}/admin.conf delete pod -n kube-system -l k8s-app=kube-proxy --force --grace-period=0"
   run_once: true
   delegate_to: "{{ groups['kube-master']|first }}"
   delegate_facts: false
@@ -157,8 +157,8 @@
 
 # FIXME(jjo): need to post-remove kube-proxy until https://github.com/kubernetes/kubeadm/issues/776
 # is fixed
-- name: Delete kube-proxy daemonset if kube_proxy_remove set, e.g. kube_network_plugin providing proxy services  # noqa 305
-  shell: "{{ bin_dir }}/kubectl --kubeconfig /etc/kubernetes/admin.conf delete daemonset -n kube-system kube-proxy"
+- name: Delete kube-proxy daemonset if kube_proxy_remove set, e.g. kube_network_plugin providing proxy services
+  command: "{{ bin_dir }}/kubectl --kubeconfig /etc/kubernetes/admin.conf delete daemonset -n kube-system kube-proxy"
   run_once: true
   delegate_to: "{{ groups['kube-master']|first }}"
   when:

roles/kubernetes/node/tasks/main.yml

@@ -45,8 +45,8 @@
   tags:
     - kube-proxy
 
-- name: Verify if br_netfilter module exists  # noqa 305
-  shell: "modinfo br_netfilter"
+- name: Verify if br_netfilter module exists
+  command: "modinfo br_netfilter"
   environment:
     PATH: "{{ ansible_env.PATH }}:/sbin"  # Make sure we can workaround RH's conservative path management
   register: modinfo_br_netfilter

roles/kubernetes/preinstall/tasks/0040-set_facts.yml

@@ -24,8 +24,8 @@
   set_fact:
     is_fedora_coreos: "{{ ostree.stat.exists and os_variant_coreos is not changed }}"
 
-- name: check resolvconf  # noqa 305
-  shell: which resolvconf
+- name: check resolvconf
+  command: which resolvconf
   register: resolvconf
   failed_when: false
   changed_when: false

roles/kubernetes/preinstall/tasks/0070-system-packages.yml

@@ -1,6 +1,6 @@
 ---
-- name: Update package management cache (zypper) - SUSE  # noqa 305
-  shell: zypper -n --gpg-auto-import-keys ref
+- name: Update package management cache (zypper) - SUSE
+  command: zypper -n --gpg-auto-import-keys ref
   register: make_cache_output
   until: make_cache_output is succeeded
   retries: 4

roles/kubernetes/tokens/tasks/gen_tokens.yml

@@ -34,8 +34,8 @@
   delegate_to: "{{ groups['kube-master'][0] }}"
   when: gen_tokens|default(false)
 
-- name: Gen_tokens | Get list of tokens from first master  # noqa 305
-  shell: "(find {{ kube_token_dir }} -maxdepth 1 -type f)"
+- name: Gen_tokens | Get list of tokens from first master
+  command: "find {{ kube_token_dir }} -maxdepth 1 -type f"
   register: tokens_list
   check_mode: no
   delegate_to: "{{ groups['kube-master'][0] }}"