Resolve ansible-lint name errors (#10253)

* project: fix ansible-lint name

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* project: ignore jinja template error in names

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* project: capitalize ansible name

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* project: update notify after name capitalization

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

---------

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

tests/cloud_playbooks/cleanup-packet.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: localhost
+- name: Cleanup packet vms
+  hosts: localhost
   gather_facts: no
   become: true
   roles:

tests/cloud_playbooks/create-aws.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: localhost
+- name: Provision AWS VMs
+  hosts: localhost
   become: False
   gather_facts: False
 

tests/cloud_playbooks/create-do.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: localhost
+- name: Provision Digital Ocean VMs
+  hosts: localhost
   become: false
   gather_facts: no
   vars:
@@ -47,15 +48,15 @@
     mode: default
 
   tasks:
-    - name: replace_test_id
+    - name: Replace_test_id
       set_fact:
         test_name: "{{ test_id | regex_replace('\\.', '-') }}"
 
-    - name: show vars
+    - name: Show vars
       debug:
         msg: "{{ cloud_region }}, {{ cloud_image }}"
 
-    - name: set instance names
+    - name: Set instance names
       set_fact:
         # noqa: jinja[spacing]
         instance_names: >-

tests/cloud_playbooks/create-gce.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: localhost
+- name: Provision Google Cloud VMs
+  hosts: localhost
   become: false
   gather_facts: no
   vars:
@@ -9,14 +10,14 @@
     ci_job_name: "{{ lookup('env', 'CI_JOB_NAME') }}"
     delete_group_vars: no
   tasks:
-    - name: include vars for test {{ ci_job_name }}
+    - name: Include vars for test {{ ci_job_name }}
       include_vars: "../files/{{ ci_job_name }}.yml"
 
-    - name: replace_test_id
+    - name: Replace_test_id
       set_fact:
         test_name: "{{ test_id | regex_replace('\\.', '-') }}"
 
-    - name: set instance names
+    - name: Set instance names
       set_fact:
         # noqa: jinja[spacing]
         instance_names: >-

tests/cloud_playbooks/create-packet.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: localhost
+- name: Provision Packet VMs
+  hosts: localhost
   gather_facts: no
   become: true
   vars:

tests/cloud_playbooks/delete-aws.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: kube_node
+- name: Terminate AWS VMs
+  hosts: kube_node
   become: False
 
   tasks:

tests/cloud_playbooks/delete-gce.yml

@@ -1,16 +1,17 @@
 ---
-- hosts: localhost
+- name: Terminate Google Cloud VMs
+  hosts: localhost
   become: false
   gather_facts: no
   vars:
     mode: default
 
   tasks:
-    - name: replace_test_id
+    - name: Replace_test_id
       set_fact:
         test_name: "{{ test_id | regex_replace('\\.', '-') }}"
 
-    - name: set instance names
+    - name: Set instance names
       set_fact:
         # noqa: jinja[spacing]
         instance_names: >-
@@ -20,7 +21,7 @@
           k8s-{{ test_name }}-1,k8s-{{ test_name }}-2
           {%- endif -%}
 
-    - name: stop gce instances  # noqa args[module] - Probably doesn't work
+    - name: Stop gce instances  # noqa args[module] - Probably doesn't work
       google.cloud.gcp_compute_instance:
         instance_names: "{{ instance_names }}"
         image: "{{ cloud_image | default(omit) }}"
@@ -34,7 +35,7 @@
       poll: 3
       register: gce
 
-    - name: delete gce instances  # noqa args[module] - Probably doesn't work
+    - name: Delete gce instances  # noqa args[module] - Probably doesn't work
       google.cloud.gcp_compute_instance:
         instance_names: "{{ instance_names }}"
         image: "{{ cloud_image | default(omit) }}"

tests/cloud_playbooks/delete-packet.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: localhost
+- name: Terminate Packet VMs
+  hosts: localhost
   gather_facts: no
   become: true
   vars:

tests/cloud_playbooks/roles/packet-ci/tasks/main.yml

@@ -7,12 +7,15 @@
   set_fact:
     vm_count: "{%- if mode in ['separate', 'separate-scale', 'ha', 'ha-scale', 'ha-recover', 'ha-recover-noquorum'] -%}{{ 3 | int }}{%- elif mode == 'aio' -%}{{ 1 | int }}{%- else -%}{{ 2 | int }}{%- endif -%}"
 
-- import_tasks: cleanup-old-vms.yml
+- name: Cleamup old VMs
+  import_tasks: cleanup-old-vms.yml
 
-- import_tasks: create-vms.yml
+- name: Create VMs
+  import_tasks: create-vms.yml
   when:
     - not vm_cleanup
 
-- import_tasks: delete-vms.yml
+- name: Delete VMs
+  import_tasks: delete-vms.yml
   when:
     - vm_cleanup | default(false)

tests/cloud_playbooks/upload-logs-gcs.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: localhost
+- name: Upload logs to GCS
+  hosts: localhost
   become: false
   gather_facts: no
 
@@ -12,7 +13,7 @@
       changed_when: false
       register: out
 
-    - name: replace_test_id
+    - name: Replace_test_id
       set_fact:
         test_name: "kargo-ci-{{ out.stdout_lines[0] }}"
 

tests/cloud_playbooks/wait-for-ssh.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: all
+- name: Wait until SSH is available
+  hosts: all
   become: False
   gather_facts: False
 

tests/testcases/010_check-apiserver.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: kube_control_plane
+- name: Testcases for apiserver
+  hosts: kube_control_plane
 
   tasks:
   - name: Check the API servers are responding

tests/testcases/015_check-nodes-ready.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: kube_control_plane[0]
+- name: Testcases checking nodes
+  hosts: kube_control_plane[0]
   tasks:
 
   - name: Force binaries directory for Flatcar Container Linux by Kinvolk

tests/testcases/020_check-pods-running.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: kube_control_plane[0]
+- name: Testcases checking pods
+  hosts: kube_control_plane[0]
   tasks:
 
   - name: Force binaries directory for Flatcar Container Linux by Kinvolk

tests/testcases/030_check-network.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: kube_control_plane[0]
+- name: Testcases for network
+  hosts: kube_control_plane[0]
   vars:
     test_image_repo: registry.k8s.io/e2e-test-images/agnhost
     test_image_tag: "2.40"

tests/testcases/040_check-network-adv.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: kube_node
+- name: Testcases for calico
+  hosts: kube_node
   tasks:
     - name: Test tunl0 routes
       shell: "set -o pipefail && ! /sbin/ip ro | grep '/{{ calico_pool_blocksize }} | default(26) via' | grep -v tunl0"
@@ -9,7 +10,8 @@
         - (calico_ipip_mode is defined and calico_ipip_mode != 'Never' or cloud_provider is defined)
         - kube_network_plugin | default('calico') == 'calico'
 
-- hosts: k8s_cluster
+- name: Advanced testcases for network
+  hosts: k8s_cluster
   vars:
     agent_report_interval: 10
     netcheck_namespace: default

tests/testcases/100_check-k8s-conformance.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: kube_control_plane[0]
+- name: Testcases for kubernetes conformance
+  hosts: kube_control_plane[0]
   vars:
     sonobuoy_version: 0.56.11
     sonobuoy_arch: amd64