Adding yamllinter to ci steps (#1556)

* Adding yaml linter to ci check

* Minor linting fixes from yamllint

* Changing CI to install python pkgs from requirements.txt

- adding in a secondary requirements.txt for tests
- moving yamllint to tests requirements

roles/network_plugin/calico/handlers/main.yml

@@ -5,7 +5,7 @@
     - Calico | reload systemd
     - Calico | reload calico-node
 
-- name : Calico | reload systemd
+- name: Calico | reload systemd
   shell: systemctl daemon-reload
 
 - name: Calico | reload calico-node

roles/network_plugin/calico/rr/handlers/main.yml

@@ -5,7 +5,7 @@
     - Calico-rr | reload systemd
     - Calico-rr | reload calico-rr
 
-- name : Calico-rr | reload systemd
+- name: Calico-rr | reload systemd
   shell: systemctl daemon-reload
 
 - name: Calico-rr | reload calico-rr

roles/network_plugin/calico/rr/meta/main.yml

@@ -1,3 +1,4 @@
+---
 dependencies:
   - role: etcd
   - role: docker

roles/network_plugin/canal/defaults/main.yml

@@ -1,3 +1,4 @@
+---
 # The interface used by canal for host <-> host communication.
 # If left blank, then the interface is chosing using the node's
 # default route.
@@ -30,4 +31,3 @@ calicoctl_memory_limit: 170M
 calicoctl_cpu_limit: 100m
 calicoctl_memory_requests: 32M
 calicoctl_cpu_requests: 25m
-

roles/network_plugin/cloud/tasks/main.yml

@@ -14,4 +14,3 @@
     owner: kube
     recurse: true
     mode: "u=rwX,g-rwx,o-rwx"
-

roles/network_plugin/flannel/handlers/main.yml

@@ -18,7 +18,7 @@
     - Flannel | pause while Docker restarts
     - Flannel | wait for docker
 
-- name : Flannel | reload systemd
+- name: Flannel | reload systemd
   shell: systemctl daemon-reload
 
 - name: Flannel | reload docker.socket

roles/network_plugin/flannel/templates/flannel-pod.yml

@@ -1,44 +1,44 @@
 ---
-  kind: "Pod"
-  apiVersion: "v1"
-  metadata:
-    name: "flannel"
-    namespace: "{{system_namespace}}"
-    labels:
-      app: "flannel"
-      version: "v0.1"
-  spec:
-    volumes:
-      - name: "subnetenv"
-        hostPath:
-          path: "/run/flannel"
-      - name: "etcd-certs"
-        hostPath:
-          path: "{{ flannel_cert_dir }}"
-    containers:
-      - name: "flannel-container"
-        image: "{{ flannel_image_repo }}:{{ flannel_image_tag }}"
-        imagePullPolicy: {{ k8s_image_pull_policy }}
-        resources:
-          limits:
-            cpu: {{ flannel_cpu_limit }}
-            memory: {{ flannel_memory_limit }}
-          requests:
-            cpu: {{ flannel_cpu_requests }}
-            memory: {{ flannel_memory_requests }}
-        command:
-          - "/bin/sh"
-          - "-c"
-          - "/opt/bin/flanneld -etcd-endpoints {{ etcd_access_endpoint }} -etcd-prefix /{{ cluster_name }}/network -etcd-cafile {{ flannel_cert_dir }}/ca_cert.crt -etcd-certfile {{ flannel_cert_dir }}/cert.crt -etcd-keyfile {{ flannel_cert_dir }}/key.pem {% if flannel_interface is defined %}-iface {{ flannel_interface }}{% endif %} {% if flannel_public_ip is defined %}-public-ip {{ flannel_public_ip }}{% endif %}"
-        ports:
-          - hostPort: 10253
-            containerPort: 10253
-        volumeMounts:
-          - name: "subnetenv"
-            mountPath: "/run/flannel"
-          - name: "etcd-certs"
-            mountPath: "{{ flannel_cert_dir }}"
-            readOnly: true
-        securityContext:
-          privileged: true
-    hostNetwork: true
+kind: "Pod"
+apiVersion: "v1"
+metadata:
+  name: "flannel"
+  namespace: "{{system_namespace}}"
+  labels:
+    app: "flannel"
+    version: "v0.1"
+spec:
+  volumes:
+    - name: "subnetenv"
+      hostPath:
+        path: "/run/flannel"
+    - name: "etcd-certs"
+      hostPath:
+        path: "{{ flannel_cert_dir }}"
+  containers:
+    - name: "flannel-container"
+      image: "{{ flannel_image_repo }}:{{ flannel_image_tag }}"
+      imagePullPolicy: {{ k8s_image_pull_policy }}
+      resources:
+        limits:
+          cpu: {{ flannel_cpu_limit }}
+          memory: {{ flannel_memory_limit }}
+        requests:
+          cpu: {{ flannel_cpu_requests }}
+          memory: {{ flannel_memory_requests }}
+      command:
+        - "/bin/sh"
+        - "-c"
+        - "/opt/bin/flanneld -etcd-endpoints {{ etcd_access_endpoint }} -etcd-prefix /{{ cluster_name }}/network -etcd-cafile {{ flannel_cert_dir }}/ca_cert.crt -etcd-certfile {{ flannel_cert_dir }}/cert.crt -etcd-keyfile {{ flannel_cert_dir }}/key.pem {% if flannel_interface is defined %}-iface {{ flannel_interface }}{% endif %} {% if flannel_public_ip is defined %}-public-ip {{ flannel_public_ip }}{% endif %}"
+      ports:
+        - hostPort: 10253
+          containerPort: 10253
+      volumeMounts:
+        - name: "subnetenv"
+          mountPath: "/run/flannel"
+        - name: "etcd-certs"
+          mountPath: "{{ flannel_cert_dir }}"
+          readOnly: true
+      securityContext:
+        privileged: true
+  hostNetwork: true

roles/network_plugin/meta/main.yml

@@ -1,16 +1,16 @@
 ---
 dependencies:
- - role: network_plugin/calico
-   when: kube_network_plugin == 'calico'
-   tags: calico
- - role: network_plugin/flannel
-   when: kube_network_plugin == 'flannel'
-   tags: flannel
- - role: network_plugin/weave
-   when: kube_network_plugin == 'weave'
-   tags: weave
- - role: network_plugin/canal
-   when: kube_network_plugin == 'canal'
-   tags: canal
- - role: network_plugin/cloud
-   when: kube_network_plugin == 'cloud'
+  - role: network_plugin/calico
+    when: kube_network_plugin == 'calico'
+    tags: calico
+  - role: network_plugin/flannel
+    when: kube_network_plugin == 'flannel'
+    tags: flannel
+  - role: network_plugin/weave
+    when: kube_network_plugin == 'weave'
+    tags: weave
+  - role: network_plugin/canal
+    when: kube_network_plugin == 'canal'
+    tags: canal
+  - role: network_plugin/cloud
+    when: kube_network_plugin == 'cloud'

roles/network_plugin/weave/tasks/pre-upgrade.yml

@@ -1,3 +1,4 @@
+---
 - name: Weave pre-upgrade | Stop legacy weave
   command: weave stop
   failed_when: false