Do not use ‘yes/no’ for boolean values (#11472)

Consistent boolean values in ansible playbooks

tests/cloud_playbooks/cleanup-packet.yml

@@ -2,7 +2,7 @@
 
 - name: Cleanup packet vms
   hosts: localhost
-  gather_facts: no
+  gather_facts: false
   become: true
   roles:
     - { role: cleanup-packet-ci }

tests/cloud_playbooks/create-packet.yml

@@ -2,7 +2,7 @@
 
 - name: Provision Packet VMs
   hosts: localhost
-  gather_facts: no
+  gather_facts: false
   become: true
   vars:
     ci_job_name: "{{ lookup('env', 'CI_JOB_NAME') }}"

tests/cloud_playbooks/delete-packet.yml

@@ -2,7 +2,7 @@
 
 - name: Terminate Packet VMs
   hosts: localhost
-  gather_facts: no
+  gather_facts: false
   become: true
   vars:
     ci_job_name: "{{ lookup('env', 'CI_JOB_NAME') }}"

tests/cloud_playbooks/roles/packet-ci/tasks/delete-vms.yml

@@ -3,9 +3,9 @@
 - name: Check if temp directory for {{ test_name }} exists
   stat:
     path: "/tmp/{{ test_name }}"
-    get_attributes: no
-    get_checksum: no
-    get_mime: no
+    get_attributes: false
+    get_checksum: false
+    get_mime: false
   register: temp_dir_details
 
 - name: "Cleanup temp directory for {{ test_name }}"

tests/cloud_playbooks/wait-for-ssh.yml

@@ -1,8 +1,8 @@
 ---
 - name: Wait until SSH is available
   hosts: all
-  become: False
-  gather_facts: False
+  become: false
+  gather_facts: false
 
   tasks:
   - name: Wait until SSH is available

tests/files/packet_ubuntu20-all-in-one-docker.yml

@@ -8,7 +8,7 @@ auto_renew_certificates: true
 
 # Currently ipvs not available on KVM: https://packages.ubuntu.com/search?suite=focal&arch=amd64&mode=exactfilename&searchon=contents&keywords=ip_vs_sh.ko
 kube_proxy_mode: iptables
-enable_nodelocaldns: False
+enable_nodelocaldns: false
 
 # Use docker
 container_manager: docker

tests/files/packet_ubuntu20-calico-all-in-one-hardening.yml

@@ -8,7 +8,7 @@ auto_renew_certificates: true
 
 # Currently ipvs not available on KVM: https://packages.ubuntu.com/search?suite=focal&arch=amd64&mode=exactfilename&searchon=contents&keywords=ip_vs_sh.ko
 kube_proxy_mode: iptables
-enable_nodelocaldns: False
+enable_nodelocaldns: false
 
 # The followings are for hardening
 ## kube-apiserver

tests/files/packet_ubuntu20-calico-all-in-one.yml

@@ -8,4 +8,4 @@ auto_renew_certificates: true
 
 # Currently ipvs not available on KVM: https://packages.ubuntu.com/search?suite=focal&arch=amd64&mode=exactfilename&searchon=contents&keywords=ip_vs_sh.ko
 kube_proxy_mode: iptables
-enable_nodelocaldns: False
+enable_nodelocaldns: false

tests/files/packet_ubuntu20-calico-etcd-kubeadm-upgrade-ha.yml

@@ -10,7 +10,7 @@ upgrade_cluster_setup: true
 
 # Currently ipvs not available on KVM: https://packages.ubuntu.com/search?suite=focal&arch=amd64&mode=exactfilename&searchon=contents&keywords=ip_vs_sh.ko
 kube_proxy_mode: iptables
-enable_nodelocaldns: False
+enable_nodelocaldns: false
 
 # Pin disabling ipip mode to ensure proper upgrade
 ipip: false

tests/files/packet_ubuntu20-calico-etcd-kubeadm.yml

@@ -8,7 +8,7 @@ etcd_deployment_type: kubeadm
 
 # Currently ipvs not available on KVM: https://packages.ubuntu.com/search?suite=focal&arch=amd64&mode=exactfilename&searchon=contents&keywords=ip_vs_sh.ko
 kube_proxy_mode: iptables
-enable_nodelocaldns: False
+enable_nodelocaldns: false
 
 # Remove anonymous access to cluster
 remove_anonymous_access: true

tests/files/packet_ubuntu22-all-in-one-docker.yml

@@ -9,7 +9,7 @@ auto_renew_certificates: true
 
 # Currently ipvs not available on KVM: https://packages.ubuntu.com/search?suite=focal&arch=amd64&mode=exactfilename&searchon=contents&keywords=ip_vs_sh.ko
 kube_proxy_mode: iptables
-enable_nodelocaldns: False
+enable_nodelocaldns: false
 
 # Use docker
 container_manager: docker

tests/files/packet_ubuntu22-calico-all-in-one.yml

@@ -9,7 +9,7 @@ auto_renew_certificates: true
 
 # Currently ipvs not available on KVM: https://packages.ubuntu.com/search?suite=focal&arch=amd64&mode=exactfilename&searchon=contents&keywords=ip_vs_sh.ko
 kube_proxy_mode: iptables
-enable_nodelocaldns: False
+enable_nodelocaldns: false
 
 containerd_registries_mirrors:
   - prefix: docker.io

tests/files/packet_ubuntu24-all-in-one-docker.yml

@@ -9,7 +9,7 @@ auto_renew_certificates: true
 
 # Currently ipvs not available on KVM: https://packages.ubuntu.com/search?suite=noble&arch=amd64&mode=exactfilename&searchon=contents&keywords=ip_vs_sh.ko
 kube_proxy_mode: iptables
-enable_nodelocaldns: False
+enable_nodelocaldns: false
 
 # Use docker
 container_manager: docker

tests/files/packet_ubuntu24-calico-all-in-one.yml

@@ -9,7 +9,7 @@ auto_renew_certificates: true
 
 # Currently ipvs not available on KVM: https://packages.ubuntu.com/search?suite=noble&arch=amd64&mode=exactfilename&searchon=contents&keywords=ip_vs_sh.ko
 kube_proxy_mode: iptables
-enable_nodelocaldns: False
+enable_nodelocaldns: false
 
 containerd_registries_mirrors:
   - prefix: docker.io

tests/files/packet_ubuntu24-calico-etcd-datastore.yml

@@ -9,7 +9,7 @@ auto_renew_certificates: true
 
 # Currently ipvs not available on KVM: https://packages.ubuntu.com/search?suite=noble&arch=amd64&mode=exactfilename&searchon=contents&keywords=ip_vs_sh.ko
 kube_proxy_mode: iptables
-enable_nodelocaldns: False
+enable_nodelocaldns: false
 
 containerd_registries:
   "docker.io": "https://mirror.gcr.io"

tests/testcases/010_check-apiserver.yml

@@ -6,7 +6,7 @@
   - name: Check the API servers are responding
     uri:
       url: "https://{{ access_ip | default(ansible_default_ipv4.address) }}:{{ kube_apiserver_port | default(6443) }}/version"
-      validate_certs: no
+      validate_certs: false
       status_code: 200
     register: apiserver_response
     retries: 12

tests/testcases/030_check-network.yml

@@ -153,13 +153,13 @@
   - name: Get running pods
     command: "{{ bin_dir }}/kubectl get pods -n test -o
             jsonpath='{range .items[?(.status.phase==\"Running\")]}{.metadata.name} {.status.podIP} {.status.containerStatuses} {end}'"
-    changed_when: False
+    changed_when: false
     register: running_pods
     no_log: true
 
   - name: Check kubectl output
     command: "{{ bin_dir }}/kubectl get pods --all-namespaces -owide"
-    changed_when: False
+    changed_when: false
     register: get_pods
     no_log: true
 

tests/testcases/040_check-network-adv.yml

@@ -69,7 +69,7 @@
     - name: Get netchecker agents
       uri:
         url: "http://{{ ansible_default_ipv4.address }}:{{ netchecker_port }}/api/v1/agents/"
-        return_content: yes
+        return_content: true
       run_once: true
       delegate_to: "{{ groups['kube_control_plane'][0] }}"
       register: agents
@@ -85,7 +85,7 @@
       uri:
         url: "http://{{ ansible_default_ipv4.address }}:{{ netchecker_port }}/api/v1/connectivity_check"
         status_code: 200
-        return_content: yes
+        return_content: true
       delegate_to: "{{ groups['kube_control_plane'][0] }}"
       run_once: true
       register: connectivity_check

tests/testcases/100_check-k8s-conformance.yml

@@ -24,7 +24,7 @@
       unarchive:
         src: /tmp/sonobuoy.tar.gz
         dest: /usr/local/bin/
-        copy: no
+        copy: false
 
     - name: Run sonobuoy
       command: "{{ sonobuoy_path }} run --mode {{ sonobuoy_mode }} --e2e-parallel {{ sonobuoy_parallel }} --wait"