Yamllint fixes (#4410)

* Lint everything in the repository with yamllint

* yamllint fixes: syntax fixes only

* yamllint fixes: move comments to play names

* yamllint fixes: indent comments in .gitlab-ci.yml file

tests/files/do_ubuntu-canal-ha.yml

@@ -1,3 +1,4 @@
+---
 cloud_image: ubuntu-16-04-x64
 cloud_region: nyc3
 mode: ha

tests/files/gce_centos-weave-kubeadm-sep.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: centos-7
 cloud_machine_type: "n1-standard-1"

tests/files/gce_centos7-calico-ha.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: centos-7
 cloud_region: us-central1-c

tests/files/gce_centos7-cilium.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: centos-7
 cloud_region: us-central1-c

tests/files/gce_centos7-flannel-addons.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: centos-7
 cloud_region: us-central1-c
@@ -15,7 +16,7 @@ deploy_netchecker: true
 dns_min_replicas: 1
 cloud_provider: gce
 kube_encrypt_secret_data: true
-#ingress_nginx_enabled: true
+# ingress_nginx_enabled: true
 cert_manager_enabled: true
 metrics_server_enabled: true
 kube_token_auth: true

tests/files/gce_centos7-kube-router.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: centos-7
 cloud_region: us-central1-c

tests/files/gce_centos7-multus-calico.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: centos-7
 cloud_region: us-central1-c

tests/files/gce_coreos-alpha-weave-ha.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: coreos-alpha
 cloud_region: us-central1-a
@@ -7,7 +8,7 @@ startup_script: 'systemctl disable locksmithd && systemctl stop locksmithd'
 
 # Deployment settings
 kube_network_plugin: weave
-resolvconf_mode: host_resolvconf # this is required as long as the coreos stable channel uses docker < 1.12
+resolvconf_mode: host_resolvconf  # this is required as long as the coreos stable channel uses docker < 1.12
 deploy_netchecker: true
 dns_min_replicas: 1
 cloud_provider: gce

tests/files/gce_coreos-calico-aio.yml

@@ -1,15 +1,16 @@
+---
 # Instance settings
 cloud_image_family: coreos-stable
 cloud_region: us-central1-a
 cloud_machine_type: "n1-standard-2"
 mode: aio
-##user-data to simply turn off coreos upgrades
+## user-data to simply turn off coreos upgrades
 startup_script: 'systemctl disable locksmithd && systemctl stop locksmithd'
 
 # Deployment settings
 no_group_vars: true
 kube_network_plugin: calico
-resolvconf_mode: host_resolvconf # this is required as long as the coreos stable channel uses docker < 1.12
+resolvconf_mode: host_resolvconf  # this is required as long as the coreos stable channel uses docker < 1.12
 deploy_netchecker: true
 dns_min_replicas: 1
 cloud_provider: gce

tests/files/gce_coreos-canal.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: coreos-stable
 cloud_region: us-central1-c
@@ -6,7 +7,7 @@ startup_script: 'systemctl disable locksmithd && systemctl stop locksmithd'
 
 # Deployment settings
 kube_network_plugin: canal
-resolvconf_mode: host_resolvconf # this is required as long as the coreos stable channel uses docker < 1.12
+resolvconf_mode: host_resolvconf  # this is required as long as the coreos stable channel uses docker < 1.12
 deploy_netchecker: true
 dns_min_replicas: 1
 cloud_provider: gce

tests/files/gce_coreos-cilium.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: coreos-stable
 cloud_region: us-central1-c
@@ -6,7 +7,7 @@ startup_script: 'systemctl disable locksmithd && systemctl stop locksmithd'
 
 # Deployment settings
 kube_network_plugin: cilium
-resolvconf_mode: host_resolvconf # this is required as long as the coreos stable channel uses docker < 1.12
+resolvconf_mode: host_resolvconf  # this is required as long as the coreos stable channel uses docker < 1.12
 deploy_netchecker: true
 enable_network_policy: true
 dns_min_replicas: 1

tests/files/gce_coreos-kube-router.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: coreos-stable
 cloud_region: us-central1-c
@@ -8,7 +9,7 @@ startup_script: 'systemctl disable locksmithd && systemctl stop locksmithd'
 # Deployment settings
 kube_network_plugin: kube-router
 bootstrap_os: coreos
-resolvconf_mode: host_resolvconf # this is required as long as the coreos stable channel uses docker < 1.12
+resolvconf_mode: host_resolvconf  # this is required as long as the coreos stable channel uses docker < 1.12
 deploy_netchecker: true
 dns_min_replicas: 1
 cloud_provider: gce

tests/files/gce_debian9-calico-upgrade.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image: debian-9-kubespray
 cloud_region: us-central1-b

tests/files/gce_opensuse-canal.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: opensuse-leap
 cloud_region: us-central1-c

tests/files/gce_rhel7-canal-sep.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: rhel-7
 cloud_region: us-central1-a

tests/files/gce_rhel7-cilium.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: rhel-7
 cloud_region: us-central1-b

tests/files/gce_rhel7-weave.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: rhel-7
 cloud_region: us-central1-b

tests/files/gce_ubuntu-canal-ha.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: ubuntu-1604-lts
 cloud_region: us-central1-b

tests/files/gce_ubuntu-canal-kubeadm.yml

@@ -1,5 +1,6 @@
+---
 # Instance settings
-cloud_image_family:  ubuntu-1604-lts
+cloud_image_family: ubuntu-1604-lts
 cloud_machine_type: "n1-standard-1"
 cloud_region: us-central1-c
 mode: ha

tests/files/gce_ubuntu-cilium-sep.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: ubuntu-1604-lts
 cloud_region: us-central1-b
@@ -9,4 +10,3 @@ deploy_netchecker: true
 enable_network_policy: true
 dns_min_replicas: 1
 cloud_provider: gce
-

tests/files/gce_ubuntu-contiv-sep.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: ubuntu-1604-lts
 cloud_region: us-central1-b

tests/files/gce_ubuntu-flannel-ha.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: ubuntu-1604-lts
 cloud_region: us-central1-b

tests/files/gce_ubuntu-kube-router-sep.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: ubuntu-1604-lts
 cloud_region: us-central1-c

tests/files/gce_ubuntu-rkt-sep.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: ubuntu-1604-lts
 cloud_region: us-central1-c

tests/files/gce_ubuntu-weave-sep.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: ubuntu-1604-lts
 cloud_region: us-central1-c

tests/files/gce_ubuntu18-flannel-aio.yml

@@ -1,3 +1,4 @@
+---
 # Instance settings
 cloud_image_family: ubuntu-1804-lts
 cloud_region: us-central1-a

tests/testcases/030_check-network.yml

@@ -17,9 +17,9 @@
     shell: "{{bin_dir}}/kubectl get pods -n test"
     register: pods
     until:
-      - '"ContainerCreating" not in pods.stdout'
-      - '"Pending" not in pods.stdout'
-      - '"Terminating" not in pods.stdout'
+    - '"ContainerCreating" not in pods.stdout'
+    - '"Pending" not in pods.stdout'
+    - '"Terminating" not in pods.stdout'
     retries: 60
     delay: 2
     no_log: true
@@ -69,12 +69,12 @@
     shell: "{{bin_dir}}/kubectl exec {{item[0]}} -- ping -c 4 {{ item[1] }}"
     when: not item[0] in pods_hostnet and not item[1] in pods_hostnet
     with_nested:
-      - "{{pod_names}}"
-      - "{{pod_ips}}"
+    - "{{pod_names}}"
+    - "{{pod_ips}}"
 
   - name: Ping between hostnet pods is working
     shell: "{{bin_dir}}/kubectl exec {{item[0]}} -- ping -c 4 {{ item[1] }}"
     when: item[0] in pods_hostnet and item[1] in pods_hostnet
     with_nested:
-      - "{{pod_names}}"
-      - "{{pod_ips}}"
+    - "{{pod_names}}"
+    - "{{pod_ips}}"