From b9662dbd8617dc7177a1e4f503fff2a987857b86 Mon Sep 17 00:00:00 2001 From: Max Gautier Date: Fri, 7 Nov 2025 06:16:53 +0000 Subject: [PATCH] cleanup: don't cleanup runc orphan binary on immutable distros (#12669) --- roles/container-engine/runc/tasks/main.yml | 24 ++++++++++++---------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/roles/container-engine/runc/tasks/main.yml b/roles/container-engine/runc/tasks/main.yml index 1d388768d..c57428a47 100644 --- a/roles/container-engine/runc/tasks/main.yml +++ b/roles/container-engine/runc/tasks/main.yml @@ -12,11 +12,20 @@ is_ostree: "{{ ostree.stat.exists }}" - name: Runc | Uninstall runc package managed by package manager - package: - name: "{{ runc_package_name }}" - state: absent when: - - not (is_ostree or (ansible_distribution == "Flatcar Container Linux by Kinvolk") or (ansible_distribution == "Flatcar")) + - not is_ostree + - ansible_distribution != "Flatcar Container Linux by Kinvolk" + - ansible_distribution != "Flatcar" + block: + - name: Runc | Remove package + package: + name: "{{ runc_package_name }}" + state: absent + - name: Runc | Remove orphaned binary + file: + path: /usr/bin/runc + state: absent + when: runc_bin_dir != "/usr/bin" - name: Runc | Download runc binary include_tasks: "../../../download/tasks/download_file.yml" @@ -29,10 +38,3 @@ dest: "{{ runc_bin_dir }}/runc" mode: "0755" remote_src: true - -- name: Runc | Remove orphaned binary - file: - path: /usr/bin/runc - state: absent - when: runc_bin_dir != "/usr/bin" - ignore_errors: true # noqa ignore-errors