Add noqa and disable .ansible-lint global exclusions (#6410)

This commit is contained in:
Maxime Guyot
2020-07-27 15:24:17 +02:00
committed by GitHub
parent b680cdd0e4
commit e70f27dd79
74 changed files with 163 additions and 170 deletions

View File

@@ -4,7 +4,7 @@
vars:
download: "{{ download_defaults | combine(downloads.crictl) }}"
- name: Install crictl config
- name: Install crictl config # noqa 404
template:
src: ../templates/crictl.yaml.j2
dest: /etc/crictl.yaml

View File

@@ -34,7 +34,7 @@
tags:
- facts
- name: disable unified_cgroup_hierarchy in Fedora 31+
- name: disable unified_cgroup_hierarchy in Fedora 31+ # noqa 305
shell:
cmd: grubby --update-kernel=ALL --args="systemd.unified_cgroup_hierarchy=0"
when:

View File

@@ -4,7 +4,7 @@
vars:
download: "{{ download_defaults | combine(downloads.crictl) }}"
- name: Install crictl config
- name: Install crictl config # noqa 404
template:
src: ../templates/crictl.yaml.j2
dest: /etc/crictl.yaml
@@ -21,7 +21,7 @@
group: no
delegate_to: "{{ inventory_hostname }}"
- name: Get crictl completion
- name: Get crictl completion # noqa 305
shell: "{{ bin_dir }}/crictl completion"
changed_when: False
register: cri_completion

View File

@@ -59,7 +59,7 @@
- ansible_distribution == "CentOS"
- ansible_distribution_major_version == "8"
- name: Ensure latest version of libseccom installed
- name: Ensure latest version of libseccom installed # noqa 303
command: "yum update -y libseccomp"
when:
- ansible_distribution == "CentOS"

View File

@@ -47,7 +47,7 @@
tags:
- facts
- name: disable unified_cgroup_hierarchy in Fedora 31+
- name: disable unified_cgroup_hierarchy in Fedora 31+ # noqa 305
shell:
cmd: grubby --update-kernel=ALL --args="systemd.unified_cgroup_hierarchy=0"
when:

View File

@@ -28,13 +28,13 @@
set_fact:
docker_dns_search_domains: "{{ docker_dns_search_domains + searchdomains|default([]) }}"
- name: check system nameservers
- name: check system nameservers # noqa 306
shell: grep "^nameserver" /etc/resolv.conf | sed -r 's/^nameserver\s*([^#\s]+)\s*(#.*)?/\1/'
changed_when: False
register: system_nameservers
check_mode: no
- name: check system search domains
- name: check system search domains # noqa 306
shell: grep "^search" /etc/resolv.conf | sed -r 's/^search\s*([^#]+)\s*(#.*)?/\1/'
changed_when: False
register: system_search_domains

View File

@@ -11,7 +11,7 @@
notify: restart docker
when: http_proxy is defined or https_proxy is defined
- name: get systemd version
- name: get systemd version # noqa 306
# noqa 303 - systemctl is called intentionally here
shell: systemctl --version | head -n 1 | cut -d " " -f 2
register: systemd_version