Bump node-feature-discovery to v0.19.0 (#13512)

* chore(deps): bump node-feature-discovery to v0.19.0

Checked all intermediate releases (0.17.0, 0.18.0, 0.19.0) for breaking changes. v0.19.0's RBAC breaking change (nfd-topology-updater needs list+watch on pods) does not apply here: Kubespray does not deploy an nfd-topology-updater workload (only an unused ConfigMap template for it exists in this role). v0.19.0 also removed env/expandenv/getHostByName from NodeFeatureRule templates -- only affects user-authored custom NodeFeatureRule resources, not anything this role ships by default.

* fix(nfd): add missing namespaces RBAC rule and fix nodefeaturegroups typo

* fix(nfd): add missing delete verb to nfd-worker Role

* chore(nfd): sync CRD manifest with upstream v0.19.0

* fix(nfd): drop removed gRPC-era flags/ports from nfd-master

* fix(nfd): remove leftover crd-controller args block

Previous commit added the new args but left the old -crd-controller
and -metrics block in place instead of replacing it.

* fix(nfd): drop removed gRPC-era flags from nfd-worker

* chore(nfd): drop variables no longer read by any template

* fix(nfd): align nfd-worker port naming and add health probes

* fix(nfd): remove obsolete nfd-master Service

* chore(nfd): register removed variables in validate_inventory

* fix(nfd): clean up the obsolete Service manifest on disk

* fix(nfd): add health probes and http port to nfd-gc

* fix(nfd): align nfd-worker env and mounts with upstream

roles/kubernetes-apps/node_feature_discovery/templates/nfd-master.yaml.j2

@@ -33,21 +33,21 @@ spec:
         image: {{ node_feature_discovery_image_repo }}:{{ node_feature_discovery_image_tag }}
         imagePullPolicy: IfNotPresent
         livenessProbe:
-          grpc:
-            port: 8082
+          httpGet:
+            path: /healthz
+            port: http
           initialDelaySeconds: 10
           periodSeconds: 10
         readinessProbe:
-          grpc:
-            port: 8082
+          httpGet:
+            path: /healthz
+            port: http
           initialDelaySeconds: 5
           periodSeconds: 10
           failureThreshold: 10
         ports:
-        - containerPort: 8082
-          name: grpc
-        - containerPort: 8081
-          name: metrics
+        - containerPort: 8080
+          name: http
         env:
         - name: NODE_NAME
           valueFrom:
@@ -57,23 +57,9 @@ spec:
           - "nfd-master"
         args:
           - "-port=8080"
-{% if not node_feature_discovery_enable_nodefeature_api %}
-          - "-enable-nodefeature-api=false"
-{% elif node_feature_discovery_master_replicas > 1 %}
+{% if node_feature_discovery_master_replicas > 1 %}
           - "-enable-leader-election"
 {% endif %}
-{% if node_feature_discovery_master_crd_controller != none %}
-          - "-crd-controller={{ node_feature_discovery_master_crd_controller }}"
-{% else %}
-{% if node_feature_discovery_master_instance  %}
-          ## By default, disable crd controller for other than the default instances
-          - "-crd-controller=false"
-{% else %}
-          ## By default, disable crd controller for other than the default instances
-          - "-crd-controller=true"
-{% endif %}
-{% endif %}
-          - "-metrics=8081"
         volumeMounts:
           - name: nfd-master-conf
             mountPath: "/etc/kubernetes/node-feature-discovery"