From f53552e56b3586316a71f5c61f95069c6b3f50e2 Mon Sep 17 00:00:00 2001 From: Max Gautier Date: Mon, 20 Jan 2025 10:33:50 +0100 Subject: [PATCH] verify_settings: Consolidate assert loop in one task --- .../preinstall/tasks/0040-verify-settings.yml | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/roles/kubernetes/preinstall/tasks/0040-verify-settings.yml b/roles/kubernetes/preinstall/tasks/0040-verify-settings.yml index 4cd260385..e45eae7c0 100644 --- a/roles/kubernetes/preinstall/tasks/0040-verify-settings.yml +++ b/roles/kubernetes/preinstall/tasks/0040-verify-settings.yml @@ -61,18 +61,15 @@ msg: "The current release of Kubespray only support newer version of Kubernetes than {{ kube_version_min_required }} - You are trying to apply {{ kube_version }}" when: not ignore_assert_errors -# simplify this items-list when https://github.com/ansible/ansible/issues/15753 is resolved - name: "Stop if known booleans are set as strings (Use JSON format on CLI: -e \"{'key': true }\")" assert: - that: item.value | type_debug == 'bool' - msg: "{{ item.value }} isn't a bool" + that: + - download_run_once | type_debug == 'bool' + - deploy_netchecker | type_debug == 'bool' + - download_always_pull | type_debug == 'bool' + - helm_enabled | type_debug == 'bool' + - openstack_lbaas_enabled | type_debug == 'bool' run_once: true - with_items: - - { name: download_run_once, value: "{{ download_run_once }}" } - - { name: deploy_netchecker, value: "{{ deploy_netchecker }}" } - - { name: download_always_pull, value: "{{ download_always_pull }}" } - - { name: helm_enabled, value: "{{ helm_enabled }}" } - - { name: openstack_lbaas_enabled, value: "{{ openstack_lbaas_enabled }}" } when: not ignore_assert_errors - name: Stop if even number of etcd hosts