External-Mirrors/kubespray
2
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kubespray.git synced 2026-02-02 01:58:12 -03:30
Code Issues Packages Projects Releases Wiki Activity

Fix outdated tag and experimental ansible-lint rules (#10254)

Browse Source 
* project: fix outdated tag and experimental

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* project: remove no longer useful noqa 301

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* project: replace unnamed-task by name[missing]

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* project: fix daemon-reload -> daemon_reload

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

---------

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
This commit is contained in:
Arthur Outhenin-Chalandre
2023-06-30 11:51:57 +02:00
committed by GitHub
parent 4f85b75087
commit f8f197e26b
56 changed files with 101 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/cloud_playbooks/create-aws.yml
View File

@@ -20,6 +20,6 @@
- name: Template the inventory
template:
src: ../templates/inventory-aws.j2 # noqa 404 CI inventory templates are not in role_path
src: ../templates/inventory-aws.j2 # noqa no-relative-paths - CI inventory templates are not in role_path
dest: "{{ inventory_path }}"
mode: 0644

2
tests/cloud_playbooks/create-do.yml
View File

@@ -86,7 +86,7 @@
- name: Template the inventory
template:
src: ../templates/inventory-do.j2 # noqa 404 CI templates are not in role_path
src: ../templates/inventory-do.j2 # noqa no-relative-paths - CI templates are not in role_path
dest: "{{ inventory_path }}"
mode: 0644
when: state == 'present'

6
tests/cloud_playbooks/create-gce.yml
View File

@@ -28,7 +28,7 @@
{%- endif -%}
- name: Create gce instances
google.cloud.gcp_compute_instance:
google.cloud.gcp_compute_instance: # noqa args[module] - Probably doesn't work
instance_names: "{{ instance_names }}"
machine_type: "{{ cloud_machine_type }}"
image: "{{ cloud_image | default(omit) }}"
@@ -51,7 +51,7 @@
groupname: "waitfor_hosts"
with_items: '{{ gce.instance_data }}'
- name: Template the inventory # noqa 404 CI inventory templates are not in role_path
- name: Template the inventory # noqa no-relative-paths - CI inventory templates are not in role_path
template:
src: ../templates/inventory-gce.j2
dest: "{{ inventory_path }}"
@@ -64,7 +64,7 @@
mode: 0755
when: mode in ['scale', 'separate-scale', 'ha-scale']
- name: Template fake hosts group vars # noqa 404 CI templates are not in role_path
- name: Template fake hosts group vars # noqa no-relative-paths - CI templates are not in role_path
template:
src: ../templates/fake_hosts.yml.j2
dest: "{{ inventory_path|dirname }}/group_vars/fake_hosts.yml"

4
tests/cloud_playbooks/delete-gce.yml
View File

@@ -19,7 +19,7 @@
k8s-{{ test_name }}-1,k8s-{{ test_name }}-2
{%- endif -%}
- name: stop gce instances
- name: stop gce instances # noqa args[module] - Probably doesn't work
google.cloud.gcp_compute_instance:
instance_names: "{{ instance_names }}"
image: "{{ cloud_image | default(omit) }}"
@@ -33,7 +33,7 @@
poll: 3
register: gce
- name: delete gce instances
- name: delete gce instances # noqa args[module] - Probably doesn't work
google.cloud.gcp_compute_instance:
instance_names: "{{ instance_names }}"
image: "{{ cloud_image | default(omit) }}"

4
tests/cloud_playbooks/upload-logs-gcs.yml
View File

@@ -56,7 +56,7 @@
no_log: True
failed_when: false
- name: Apply the lifecycle rules # noqa 301
- name: Apply the lifecycle rules
command: "{{ dir }}/google-cloud-sdk/bin/gsutil lifecycle set {{ dir }}/gcs_life.json gs://{{ test_name }}"
changed_when: false
environment:
@@ -77,5 +77,5 @@
failed_when: false
no_log: True
- debug: # noqa unnamed-task
- debug: # noqa name[missing]
msg: "A public url https://storage.googleapis.com/{{ test_name }}/{{ file_name }}"

2
tests/testcases/010_check-apiserver.yml
View File

@@ -12,7 +12,7 @@
delay: 5
until: apiserver_response is success
- debug: # noqa unnamed-task
- debug: # noqa name[missing]
msg: "{{ apiserver_response.json }}"
- name: Check API servers version

4
tests/testcases/015_check-nodes-ready.yml
View File

@@ -12,7 +12,7 @@
bin_dir: "/usr/local/bin"
when: not ansible_os_family in ["Flatcar", "Flatcar Container Linux by Kinvolk"]
- import_role: # noqa unnamed-task
- import_role: # noqa name[missing]
name: cluster-dump
- name: Check kubectl output
@@ -21,7 +21,7 @@
register: get_nodes
no_log: true
- debug: # noqa unnamed-task
- debug: # noqa name[missing]
msg: "{{ get_nodes.stdout.split('\n') }}"
- name: Check that all nodes are running and ready

6
tests/testcases/020_check-pods-running.yml
View File

@@ -12,7 +12,7 @@
bin_dir: "/usr/local/bin"
when: not ansible_os_family in ["Flatcar", "Flatcar Container Linux by Kinvolk"]
- import_role: # noqa unnamed-task
- import_role: # noqa name[missing]
name: cluster-dump
- name: Check kubectl output
@@ -21,7 +21,7 @@
register: get_pods
no_log: true
- debug: # noqa unnamed-task
- debug: # noqa name[missing]
msg: "{{ get_pods.stdout.split('\n') }}"
- name: Check that all pods are running and ready
@@ -44,6 +44,6 @@
register: get_pods
no_log: true
- debug: # noqa unnamed-task
- debug: # noqa name[missing]
msg: "{{ get_pods.stdout.split('\n') }}"
failed_when: not run_pods_log is success

10
tests/testcases/030_check-network.yml
View File

@@ -23,7 +23,7 @@
register: get_csr
changed_when: false
- debug: # noqa unnamed-task
- debug: # noqa name[missing]
msg: "{{ get_csr.stdout.split('\n') }}"
- name: Check there are csrs
@@ -63,7 +63,7 @@
when: get_csr.stdout_lines | length > 0
changed_when: certificate_approve.stdout
- debug: # noqa unnamed-task
- debug: # noqa name[missing]
msg: "{{ certificate_approve.stdout.split('\n') }}"
when:
@@ -114,7 +114,7 @@
- agnhost1
- agnhost2
- import_role: # noqa unnamed-task
- import_role: # noqa name[missing]
name: cluster-dump
- name: Check that all pods are running and ready
@@ -137,7 +137,7 @@
register: pods
no_log: true
- debug: # noqa unnamed-task
- debug: # noqa name[missing]
msg: "{{ pods.stdout.split('\n') }}"
failed_when: not run_pods_log is success
@@ -162,7 +162,7 @@
register: get_pods
no_log: true
- debug: # noqa unnamed-task
- debug: # noqa name[missing]
msg: "{{ get_pods.stdout.split('\n') }}"
- name: Set networking facts

10
tests/testcases/040_check-network-adv.yml
View File

@@ -26,7 +26,7 @@
bin_dir: "/usr/local/bin"
when: not ansible_os_family in ["Flatcar", "Flatcar Container Linux by Kinvolk"]
- import_role: # noqa unnamed-task
- import_role: # noqa name[missing]
name: cluster-dump
- name: Wait for netchecker server
@@ -60,7 +60,7 @@
- netchecker-agent-hostnet
when: not nca_pod is success
- debug: # noqa unnamed-task
- debug: # noqa name[missing]
var: nca_pod.stdout_lines
when: inventory_hostname == groups['kube_control_plane'][0]
@@ -96,7 +96,7 @@
when:
- agents.content != '{}'
- debug: # noqa unnamed-task
- debug: # noqa name[missing]
var: ncs_pod
run_once: true
@@ -130,7 +130,7 @@
- agents.content is defined
- agents.content[0] == '{'
- debug: # noqa unnamed-task
- debug: # noqa name[missing]
var: agents_check_result
delegate_to: "{{ groups['kube_control_plane'][0] }}"
run_once: true
@@ -147,7 +147,7 @@
- connectivity_check.content is defined
- connectivity_check.content[0] == '{'
- debug: # noqa unnamed-task
- debug: # noqa name[missing]
var: connectivity_check_result
delegate_to: "{{ groups['kube_control_plane'][0] }}"
run_once: true