Refactor downloads to use download role directly (#1824)

* Refactor downloads to use download role directly

Also disable fact delegation so download delegate works acros OSes.

* clean up bools and ansible_os_family conditionals

roles/kubernetes-apps/efk/elasticsearch/meta/main.yml

@@ -1,7 +1,4 @@
 ---
-dependencies:
-  - role: download
-    file: "{{ downloads.elasticsearch }}"
 # TODO: bradbeam add in curator
 #       https://github.com/Skillshare/kubernetes-efk/blob/master/configs/elasticsearch.yml#L94
 #  - role: download

roles/kubernetes-apps/efk/fluentd/meta/main.yml

@@ -1,4 +0,0 @@
----
-dependencies:
-  - role: download
-    file: "{{ downloads.fluentd }}"

roles/kubernetes-apps/efk/kibana/meta/main.yml

@@ -1,4 +0,0 @@
----
-dependencies:
-  - role: download
-    file: "{{ downloads.kibana }}"

roles/kubernetes-apps/helm/meta/main.yml

@@ -1,6 +0,0 @@
----
-dependencies:
-  - role: download
-    file: "{{ downloads.helm }}"
-  - role: download
-    file: "{{ downloads.tiller }}"

roles/kubernetes-apps/istio/meta/main.yml

@@ -1,4 +0,0 @@
----
-dependencies:
-  - role: download
-    file: "{{ downloads.istioctl }}"

roles/kubernetes-apps/meta/main.yml

@@ -1,19 +1,5 @@
 ---
 dependencies:
-  - role: download
-    file: "{{ downloads.netcheck_server }}"
-    when: deploy_netchecker
-    tags:
-      - download
-      - netchecker
-
-  - role: download
-    file: "{{ downloads.netcheck_agent }}"
-    when: deploy_netchecker
-    tags:
-      - download
-      - netchecker
-
   - role: kubernetes-apps/ansible
     tags:
       - apps

roles/kubernetes-apps/policy_controller/meta/main.yml

@@ -1,15 +1,5 @@
 ---
 dependencies:
-  - role: download
-    file: "{{ downloads.calico_policy }}"
-    when:
-      - enable_network_policy
-      - kube_network_plugin in ['calico', 'canal']
-    tags:
-      - download
-      - canal
-      - policy-controller
-
   - role: policy_controller/calico
     when:
       - kube_network_plugin == 'calico'