mirror of
https://github.com/kubernetes-sigs/kubespray.git
synced 2026-10-29 22:03:22 -02:30
W GengandWeigang Geng
65832d2e2e
The plays carry `any_errors_fatal: "{{ any_errors_fatal | default(true) }}"`,
added in #1201 so the behaviour could be turned off.
`any_errors_fatal` is an Ansible play keyword, and Ansible reserves keyword
names in the variable namespace. Setting it through -e, group_vars or
host_vars is rejected with "Found variable using reserved name:
any_errors_fatal" and the value never reaches the play, so the expression
always falls through to `default(true)`. The knob has been inert since it was
introduced.
Rename the variable to `kubespray_any_errors_fatal`. Default behaviour is
unchanged -- still fatal -- but `-e kubespray_any_errors_fatal=false` now
works as #1201 intended.
This matters most in playbooks/internal_facts.yml, where the fatal bootstrap
play runs ahead of the play that gathers and caches facts: one unreachable
host aborts the run before any facts are cached, the playbook still exits 0,
and a later `scale.yml --limit=...` refuses because the excluded hosts have
no cache entries. roles/network_facts already sets ignore_unreachable: true
for this reason, but it never executes.
Refs #13407
Claude-Session: https://claude.ai/code/session_017RCEoUNR9gthd455d8Anrx
Signed-off-by: Weigang Geng <3356786+gengwg@users.noreply.github.com>
Co-authored-by: Weigang Geng <3356786+gengwg@users.noreply.github.com>
27 lines
869 B
YAML
27 lines
869 B
YAML
---
|
|
- name: Add worker nodes to the etcd play if needed
|
|
hosts: kube_node
|
|
roles:
|
|
- { role: kubespray_defaults }
|
|
tasks:
|
|
- name: Check if nodes needs etcd client certs (depends on network_plugin)
|
|
group_by:
|
|
key: "_kubespray_needs_etcd"
|
|
when:
|
|
- kube_network_plugin in ["flannel", "canal", "cilium"] or
|
|
(cilium_deploy_additionally | default(false)) or
|
|
(kube_network_plugin == "calico" and calico_datastore == "etcd")
|
|
- etcd_deployment_type != "kubeadm"
|
|
tags: etcd
|
|
|
|
- name: Install etcd
|
|
hosts: etcd:kube_control_plane:_kubespray_needs_etcd
|
|
gather_facts: false
|
|
any_errors_fatal: "{{ kubespray_any_errors_fatal | default(true) }}"
|
|
environment: "{{ proxy_disable_env }}"
|
|
roles:
|
|
- { role: kubespray_defaults }
|
|
- role: etcd
|
|
tags: etcd
|
|
when: etcd_deployment_type != "kubeadm"
|