mirror of
https://github.com/kubernetes-sigs/kubespray.git
synced 2026-10-30 14:15:38 -02:30
Mehrdad Biukian
d75f23cba3
* fix(container-engine/cri-o): flush Restart crio handler inside the role During a Kubernetes upgrade (e.g. 1.32 -> 1.33) the cri-o systemd service is not restarted even though the new cri-o binaries are deployed. This leaves the node running the old cri-o version (reported as crio://1.32.x after kubelet is upgraded to 1.33.x); a manual 'systemctl restart crio' fixes it. The cri-o role notifies 'Restart crio' from several tasks (binary copy, registries, proxy drop-in, service file, etc.) but never flushes the handler itself. The handler only fired when the kubernetes/node role ran its own 'meta: flush_handlers' later in the same play. That cross-role dependency is fragile during upgrades: if kubernetes/node is skipped, tagged out, or the flush is reordered, the restart is silently dropped. Route every restart through the single handler: crio.conf and config.json now notify 'Restart crio' and the ad-hoc 'trigger service restart only when needed' task is dropped (its restart duplicated what the handler already does, and a restarted unit also starts a stopped one). Then add 'meta: flush_handlers' right after the service start task so the pending handlers run as part of this role regardless of any downstream role's flush timing. Signed-off-by: Mehrdad Biukian Naeini <mehrdadbiukian@gmail.com> * test(youki): run youki before cri-o in molecule converge The converge ran container-engine/cri-o before container-engine/youki, the reverse of the order used by the container-engine role, which installs the runtime roles (kata-containers, gvisor, crun, youki) before the container manager role. With cri-o flushing its restart handler inside the role, cri-o is now restarted while /usr/local/bin/youki does not exist yet: CRI-O skips the runtime whose binary is missing, so the youki runtime handler is never registered and the verify step fails with 'failed to find runtime handler youki from runtime list map[crun:...]'. Running the roles in the playbook order puts the youki binary in place before cri-o starts. Signed-off-by: Mehrdad Biukian Naeini <mehrdadbiukian@gmail.com> --------- Signed-off-by: Mehrdad Biukian Naeini <mehrdadbiukian@gmail.com>