Merge pull request #13552 from gamuniz/prevent_constructed_sourceinventory

[constructed-inventory] Prevent constructed sourceinventory creation
This commit is contained in:
Gabriel Muniz 2023-02-10 15:32:53 -05:00 committed by GitHub
commit 0866bfc549
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -2270,6 +2270,8 @@ class InventorySourceSerializer(UnifiedJobTemplateSerializer, InventorySourceOpt
if get_field_from_model_or_attrs('source') == 'scm':
if ('source' in attrs or 'source_project' in attrs) and get_field_from_model_or_attrs('source_project') is None:
raise serializers.ValidationError({"source_project": _("Project required for scm type sources.")})
elif get_field_from_model_or_attrs('source') == 'constructed':
raise serializers.ValidationError({"Error": _('constructed not a valid source for inventory')})
else:
redundant_scm_fields = list(filter(lambda x: attrs.get(x, None), ['source_project', 'source_path']))
if redundant_scm_fields: