Merge pull request #13600 from gamuniz/fix_validation_bug_constructed

[constructed-inventory]Fix validation issue constructed
This commit is contained in:
Hao Liu 2023-02-20 10:33:21 -05:00 committed by GitHub
commit 103b4567fe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -2272,7 +2272,7 @@ class InventorySourceSerializer(UnifiedJobTemplateSerializer, InventorySourceOpt
if get_field_from_model_or_attrs('source') == 'scm':
if ('source' in attrs or 'source_project' in attrs) and get_field_from_model_or_attrs('source_project') is None:
raise serializers.ValidationError({"source_project": _("Project required for scm type sources.")})
elif get_field_from_model_or_attrs('source') == 'constructed':
elif (get_field_from_model_or_attrs('source') == 'constructed') and (self.instance and self.instance.source != 'constructed'):
raise serializers.ValidationError({"Error": _('constructed not a valid source for inventory')})
else:
redundant_scm_fields = list(filter(lambda x: attrs.get(x, None), ['source_project', 'source_path']))