External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-05-07 01:17:37 -02:30
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6989 from nixocio/ui_update_string_cap

Browse Source 
Update strings to follow `sentence capitalization` style

Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
This commit is contained in:
softwarefactory-project-zuul[bot]
2020-05-12 20:53:04 +00:00
committed by GitHub
parent 4378dc62bb d6b56d8794
commit 12a04bf42e
5 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
awx/ui_next/CONTRIBUTING.md
View File

@@ -35,6 +35,7 @@ Have questions about this document or anything not covered here? Feel free to re
- functions should adopt camelCase - functions should adopt camelCase
- constructors/classes should adopt PascalCase - constructors/classes should adopt PascalCase
- constants to be exported should adopt UPPERCASE - constants to be exported should adopt UPPERCASE
- For strings, we adopt the `sentence capitalization` since it is a (patternfly style guide)[https://www.patternfly.org/v4/design-guidelines/content/grammar-and-terminology#capitalization].
## Setting up your development environment ## Setting up your development environment

2
awx/ui_next/src/components/CodeMirrorInput/VariablesField.jsx
View File

@@ -64,7 +64,7 @@ function VariablesField({
{promptId && ( {promptId && (
<StyledCheckboxField <StyledCheckboxField
id="template-ask-variables-on-launch" id="template-ask-variables-on-launch"
label={i18n._(t`Prompt On Launch`)} label={i18n._(t`Prompt on launch`)}
name="ask_variables_on_launch" name="ask_variables_on_launch"
/> />
)} )}

2
awx/ui_next/src/components/FieldWithPrompt/FieldWithPrompt.jsx
View File

@@ -45,7 +45,7 @@ function FieldWithPrompt({
</div> </div>
<StyledCheckboxField <StyledCheckboxField
id={promptId} id={promptId}
label={i18n._(t`Prompt On Launch`)} label={i18n._(t`Prompt on launch`)}
name={promptName} name={promptName}
/> />
</FieldHeader> </FieldHeader>

2
awx/ui_next/src/screens/Template/JobTemplateDetail/JobTemplateDetail.jsx
View File

@@ -143,7 +143,7 @@ function JobTemplateDetail({ i18n, template }) {
<Link to={`/inventories/${inventorykind}/${id}/details`}> <Link to={`/inventories/${inventorykind}/${id}/details`}>
{summary_fields.inventory.name} {summary_fields.inventory.name}
</Link> </Link>
<span> {i18n._(t`(Prompt on Launch)`)}</span> <span> {i18n._(t`(Prompt on launch)`)}</span>
</Fragment> </Fragment>
) : ( ) : (
<Link to={`/inventories/${inventorykind}/${id}/details`}> <Link to={`/inventories/${inventorykind}/${id}/details`}>

2
awx/ui_next/src/screens/Template/WorkflowJobTemplateDetail/WorkflowJobTemplateDetail.jsx
View File

@@ -88,7 +88,7 @@ function WorkflowJobTemplateDetail({ template, i18n }) {
<Link to={`/inventories/${inventorykind}/${inventoryId}/details`}> <Link to={`/inventories/${inventorykind}/${inventoryId}/details`}>
<Label>{summary_fields.inventory.name}</Label> <Label>{summary_fields.inventory.name}</Label>
</Link> </Link>
<span> {i18n._(t`(Prompt on Launch)`)}</span> <span> {i18n._(t`(Prompt on launch)`)}</span>
</> </>
) : ( ) : (
<Link to={`/inventories/${inventorykind}/${inventoryId}/details`}> <Link to={`/inventories/${inventorykind}/${inventoryId}/details`}>