Merge pull request #2408 from ryanpetrello/fix-2323

properly check read permissions in `GET /api/v2/wfjt/N/copy/`
This commit is contained in:
Ryan Petrello 2018-07-03 15:32:20 -04:00 committed by GitHub
commit 151187f623
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -3720,7 +3720,11 @@ class WorkflowJobTemplateCopy(WorkflowsEnforcementMixin, CopyAPIView):
copy_return_serializer_class = WorkflowJobTemplateSerializer
def get(self, request, *args, **kwargs):
if get_request_version(request) < 2:
return self.v1_not_allowed()
obj = self.get_object()
if not request.user.can_access(obj.__class__, 'read', obj):
raise PermissionDenied()
can_copy, messages = request.user.can_access_with_errors(self.model, 'copy', obj)
data = OrderedDict([
('can_copy', can_copy), ('can_copy_without_user_input', can_copy),