External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-01-11 01:57:35 -03:30
Code Issues Packages Projects Releases Wiki Activity

Add validate for CredentialLookup using required prop

Browse Source 
When using `CredentialLookup` with required prop. The `validate`
argument must be provided to the `useField`.

See: https://github.com/ansible/awx/issues/8184
This commit is contained in:
nixocio 2020-09-25 12:03:46 -04:00
parent b4d6270eab
commit 1aa90af342
10 changed files with 56 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
awx/ui_next/src/screens/InstanceGroup/shared/ContainerGroupForm.jsx
View File

@ -23,9 +23,11 @@ import { VariablesField } from '../../../components/CodeMirrorInput';
function ContainerGroupFormFields({ i18n, instanceGroup }) {
const { setFieldValue } = useFormikContext();
const [credentialField, credentialMeta, credentialHelpers] = useField(
'credential'
);
const [credentialField, credentialMeta, credentialHelpers] = useField({
name: 'credential',
validate: required(i18n._(t`Select a value for this field`), i18n),
});
const [overrideField] = useField('override');
const onCredentialChange = useCallback(

13
awx/ui_next/src/screens/InstanceGroup/shared/ContainerGroupForm.test.jsx
View File

@ -28,12 +28,21 @@ const instanceGroup = {
is_controller: false,
is_isolated: false,
is_containerized: false,
credential: null,
credential: 3,
policy_instance_percentage: 46,
policy_instance_minimum: 12,
policy_instance_list: [],
pod_spec_override: '',
summary_fields: {
credential: {
id: 3,
name: 'test',
description: 'Simple one',
kind: 'kubernetes_bearer_token',
cloud: false,
kubernetes: true,
credential_type_id: 17,
},
user_capabilities: {
edit: true,
delete: true,
@ -101,7 +110,7 @@ describe('<ContainerGroupForm/>', () => {
.find('Checkbox[aria-label="Customize pod specification"]')
.prop('isChecked')
).toBeFalsy();
expect(wrapper.find('CredentialLookup').prop('value')).toBeFalsy();
expect(wrapper.find('CredentialLookup').prop('value').name).toBe('test');
});
test('should update form values', () => {

8
awx/ui_next/src/screens/Inventory/shared/InventorySourceSubForms/AzureSubForm.jsx
View File

@ -11,12 +11,14 @@ import {
EnabledValueField,
HostFilterField,
} from './SharedFields';
import { required } from '../../../../util/validators';
const AzureSubForm = ({ autoPopulateCredential, i18n }) => {
const { setFieldValue } = useFormikContext();
const [credentialField, credentialMeta, credentialHelpers] = useField(
'credential'
);
const [credentialField, credentialMeta, credentialHelpers] = useField({
name: 'credential',
validate: required(i18n._(t`Select a value for this field`), i18n),
});
const handleCredentialUpdate = useCallback(
value => {

8
awx/ui_next/src/screens/Inventory/shared/InventorySourceSubForms/CloudFormsSubForm.jsx
View File

@ -11,12 +11,14 @@ import {
EnabledValueField,
HostFilterField,
} from './SharedFields';
import { required } from '../../../../util/validators';
const CloudFormsSubForm = ({ i18n }) => {
const { setFieldValue } = useFormikContext();
const [credentialField, credentialMeta, credentialHelpers] = useField(
'credential'
);
const [credentialField, credentialMeta, credentialHelpers] = useField({
name: 'credential',
validate: required(i18n._(t`Select a value for this field`), i18n),
});
const handleCredentialUpdate = useCallback(
value => {

8
awx/ui_next/src/screens/Inventory/shared/InventorySourceSubForms/GCESubForm.jsx
View File

@ -10,12 +10,14 @@ import {
EnabledValueField,
HostFilterField,
} from './SharedFields';
import { required } from '../../../../util/validators';
const GCESubForm = ({ autoPopulateCredential, i18n }) => {
const { setFieldValue } = useFormikContext();
const [credentialField, credentialMeta, credentialHelpers] = useField(
'credential'
);
const [credentialField, credentialMeta, credentialHelpers] = useField({
name: 'credential',
validate: required(i18n._(t`Select a value for this field`), i18n),
});
const handleCredentialUpdate = useCallback(
value => {

8
awx/ui_next/src/screens/Inventory/shared/InventorySourceSubForms/OpenStackSubForm.jsx
View File

@ -11,12 +11,14 @@ import {
EnabledValueField,
HostFilterField,
} from './SharedFields';
import { required } from '../../../../util/validators';
const OpenStackSubForm = ({ autoPopulateCredential, i18n }) => {
const { setFieldValue } = useFormikContext();
const [credentialField, credentialMeta, credentialHelpers] = useField(
'credential'
);
const [credentialField, credentialMeta, credentialHelpers] = useField({
name: 'credential',
validate: required(i18n._(t`Select a value for this field`), i18n),
});
const handleCredentialUpdate = useCallback(
value => {

8
awx/ui_next/src/screens/Inventory/shared/InventorySourceSubForms/SatelliteSubForm.jsx
View File

@ -11,12 +11,14 @@ import {
EnabledValueField,
HostFilterField,
} from './SharedFields';
import { required } from '../../../../util/validators';
const SatelliteSubForm = ({ autoPopulateCredential, i18n }) => {
const { setFieldValue } = useFormikContext();
const [credentialField, credentialMeta, credentialHelpers] = useField(
'credential'
);
const [credentialField, credentialMeta, credentialHelpers] = useField({
name: 'credential',
validate: required(i18n._(t`Select a value for this field`), i18n),
});
const handleCredentialUpdate = useCallback(
value => {

8
awx/ui_next/src/screens/Inventory/shared/InventorySourceSubForms/TowerSubForm.jsx
View File

@ -10,12 +10,14 @@ import {
EnabledValueField,
HostFilterField,
} from './SharedFields';
import { required } from '../../../../util/validators';
const TowerSubForm = ({ autoPopulateCredential, i18n }) => {
const { setFieldValue } = useFormikContext();
const [credentialField, credentialMeta, credentialHelpers] = useField(
'credential'
);
const [credentialField, credentialMeta, credentialHelpers] = useField({
name: 'credential',
validate: required(i18n._(t`Select a value for this field`), i18n),
});
const handleCredentialUpdate = useCallback(
value => {

8
awx/ui_next/src/screens/Inventory/shared/InventorySourceSubForms/VMwareSubForm.jsx
View File

@ -11,12 +11,14 @@ import {
EnabledValueField,
HostFilterField,
} from './SharedFields';
import { required } from '../../../../util/validators';
const VMwareSubForm = ({ autoPopulateCredential, i18n }) => {
const { setFieldValue } = useFormikContext();
const [credentialField, credentialMeta, credentialHelpers] = useField(
'credential'
);
const [credentialField, credentialMeta, credentialHelpers] = useField({
name: 'credential',
validate: required(i18n._(t`Select a value for this field`), i18n),
});
const handleCredentialUpdate = useCallback(
value => {

8
awx/ui_next/src/screens/Inventory/shared/InventorySourceSubForms/VirtualizationSubForm.jsx
View File

@ -10,12 +10,14 @@ import {
EnabledValueField,
HostFilterField,
} from './SharedFields';
import { required } from '../../../../util/validators';
const VirtualizationSubForm = ({ autoPopulateCredential, i18n }) => {
const { setFieldValue } = useFormikContext();
const [credentialField, credentialMeta, credentialHelpers] = useField(
'credential'
);
const [credentialField, credentialMeta, credentialHelpers] = useField({
name: 'credential',
validate: required(i18n._(t`Select a value for this field`), i18n),
});
const handleCredentialUpdate = useCallback(
value => {