Merge pull request #9192 from jakemcdermott/fix-9191

Fix container group detail link outs

Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
This commit is contained in:
softwarefactory-project-zuul[bot] 2021-01-29 19:38:40 +00:00 committed by GitHub
commit 1b32dad745
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -106,7 +106,7 @@ function JobDetail({ job, i18n }) {
}
};
const isIsolatedInstanceGroup = item => {
const buildInstanceGroupLink = item => {
if (item.is_isolated) {
return (
<>
@ -122,6 +122,14 @@ function JobDetail({ job, i18n }) {
return <Link to={`/instance_groups/${item.id}`}>{item.name}</Link>;
};
const buildContainerGroupLink = item => {
return (
<Link to={`/instance_groups/container_group/${item.id}`}>
{item.name}
</Link>
);
};
return (
<CardBody>
<DetailList>
@ -210,10 +218,16 @@ function JobDetail({ job, i18n }) {
<Detail label={i18n._(t`Verbosity`)} value={VERBOSITY[job.verbosity]} />
<Detail label={i18n._(t`Environment`)} value={job.custom_virtualenv} />
<Detail label={i18n._(t`Execution Node`)} value={job.execution_node} />
{instanceGroup && (
{instanceGroup && !instanceGroup?.is_containerized && (
<Detail
label={i18n._(t`Instance Group`)}
value={isIsolatedInstanceGroup(instanceGroup)}
value={buildInstanceGroupLink(instanceGroup)}
/>
)}
{instanceGroup && instanceGroup?.is_containerized && (
<Detail
label={i18n._(t`Container Group`)}
value={buildContainerGroupLink(instanceGroup)}
/>
)}
{typeof job.job_slice_number === 'number' &&