External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-01-15 03:40:42 -03:30
Code Issues Packages Projects Releases Wiki Activity

Fix linter errors and add test to AnsibleSelect component.

Browse Source
This commit is contained in:
kialam 2019-02-12 09:42:41 -05:00
parent 97477b789a
commit 2b18cee9c0
No known key found for this signature in database
GPG Key ID: 2D0E60E4B8C7EA0F
3 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
__tests__/components/AnsibleSelect.test.jsx
View File

@ -41,4 +41,16 @@ describe('<AnsibleSelect />', () => {
expect(wrapper.find('FormGroup')).toHaveLength(0);
expect(wrapper.find('Select')).toHaveLength(0);
});
test('Returns correct select options if defaultSelected props is passed', () => {
const wrapper = mount(
<AnsibleSelect
selected="foo"
selectChange={() => { }}
labelName={label}
data={mockData}
defaultSelected={mockData[1]}
/>
);
expect(wrapper.find('Select')).toHaveLength(1);
});
});

5
src/components/AnsibleSelect/AnsibleSelect.jsx
View File

@ -39,9 +39,8 @@ class AnsibleSelect extends React.Component {
<FormGroup label={labelName} fieldId="ansible-select">
<Select value={selected} onChange={this.onSelectChange} aria-label="Select Input">
<SelectOption isDisabled key="" value="" label={`Use Default ${labelName}`} />
{data.map((datum) =>
datum !== defaultSelected ?
(<SelectOption key={datum} value={datum} label={datum} />) : null)
{data.map((datum) => (datum !== defaultSelected
? (<SelectOption key={datum} value={datum} label={datum} />) : null))
}
</Select>
</FormGroup>

2
src/pages/Organizations/screens/OrganizationAdd.jsx
View File

@ -40,7 +40,7 @@ class OrganizationAdd extends React.Component {
this.onCancel = this.onCancel.bind(this);
this.updateSelectedInstanceGroups = this.updateSelectedInstanceGroups.bind(this);
}
state = {
name: '',
description: '',