External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-01-11 10:00:01 -03:30
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13005 from marshmalien/13002-fix-source-add-schedule

Browse Source 
Fix undefined launchConfig error in schedule form
This commit is contained in:
Sarah Akus 2022-10-06 14:18:23 -04:00 committed by GitHub
commit 35a7e43f22
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
awx/ui/src/components/Schedule/shared/ScheduleForm.js
View File

@ -67,14 +67,14 @@ function ScheduleForm({
if (schedule.id) {
if (
resource.type === 'job_template' &&
launchConfig.ask_credential_on_launch
launchConfig?.ask_credential_on_launch
) {
const {
data: { results },
} = await SchedulesAPI.readCredentials(schedule.id);
creds = results;
}
if (launchConfig.ask_labels_on_launch) {
if (launchConfig?.ask_labels_on_launch) {
const {
data: { results },
} = await SchedulesAPI.readAllLabels(schedule.id);
@ -82,7 +82,7 @@ function ScheduleForm({
}
if (
resource.type === 'job_template' &&
launchConfig.ask_instance_groups_on_launch
launchConfig?.ask_instance_groups_on_launch
) {
const {
data: { results },
@ -91,7 +91,7 @@ function ScheduleForm({
}
} else {
if (resource.type === 'job_template') {
if (launchConfig.ask_labels_on_launch) {
if (launchConfig?.ask_labels_on_launch) {
const {
data: { results },
} = await JobTemplatesAPI.readAllLabels(resource.id);
@ -100,7 +100,7 @@ function ScheduleForm({
}
if (
resource.type === 'workflow_job_template' &&
launchConfig.ask_labels_on_launch
launchConfig?.ask_labels_on_launch
) {
const {
data: { results },
@ -123,14 +123,7 @@ function ScheduleForm({
zoneLinks: data.links,
credentials: creds,
};
}, [
schedule,
resource.id,
resource.type,
launchConfig.ask_labels_on_launch,
launchConfig.ask_instance_groups_on_launch,
launchConfig.ask_credential_on_launch,
]),
}, [schedule, resource.id, resource.type, launchConfig]),
{
zonesOptions: [],
zoneLinks: {},
@ -146,7 +139,7 @@ function ScheduleForm({
const missingRequiredInventory = useCallback(() => {
let missingInventory = false;
if (
launchConfig.inventory_needed_to_start &&
launchConfig?.inventory_needed_to_start &&
!schedule?.summary_fields?.inventory?.id
) {
missingInventory = true;

2
awx/ui/src/screens/ManagementJob/ManagementJob.js
View File

@ -180,8 +180,6 @@ function ManagementJob({ setBreadcrumb }) {
loadSchedules={loadSchedules}
loadScheduleOptions={loadScheduleOptions}
setBreadcrumb={setBreadcrumb}
launchConfig={{}}
surveyConfig={{}}
/>
</Route>
) : null}