External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-03-18 17:37:30 -02:30
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5709 from wwitzel3/issue-5702

Browse Source 
correct unintentional stripping of - from order by fields
This commit is contained in:
Wayne Witzel III
2017-03-13 22:35:18 -04:00
committed by GitHub
parent 47a894a339 ea1c4ee1d5
commit 3b1556c0d5
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
awx/api/filters.py
View File

@@ -339,12 +339,12 @@ class OrderByBackend(BaseFilterBackend):
def _strip_sensitive_model_fields(self, model, order_by):
for field_name in order_by:
# strip off the negation prefix `-` if it exists
field_name = field_name.split('-')[-1]
_field_name = field_name.split('-')[-1]
try:
# if the field name is encrypted/sensitive, don't sort on it
if field_name in getattr(model, 'PASSWORD_FIELDS', ()) or \
getattr(model._meta.get_field(field_name), '__prevent_search__', False):
raise ParseError(_('cannot order by field %s') % field_name)
if _field_name in getattr(model, 'PASSWORD_FIELDS', ()) or \
getattr(model._meta.get_field(_field_name), '__prevent_search__', False):
raise ParseError(_('cannot order by field %s') % _field_name)
except FieldDoesNotExist:
pass
yield field_name