External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-01-13 11:00:03 -03:30
Code Issues Packages Projects Releases Wiki Activity

Disable tools/legend buttons when the workflow has no nodes and is displaying the start screen.

Browse Source
This commit is contained in:
mabashian 2020-02-11 13:00:47 -05:00
parent aa6857fd38
commit 48eeeea7f3
2 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
awx/ui_next/src/screens/Template/WorkflowJobTemplateVisualizer/Visualizer.test.jsx
View File

@ -192,6 +192,30 @@ describe('Visualizer', () => {
).toHaveBeenCalledWith(8, 9);
});
test('Start Screen shown when no nodes are present', async () => {
WorkflowJobTemplatesAPI.readNodes.mockResolvedValue({
data: {
count: 0,
results: [],
},
});
await act(async () => {
wrapper = mountWithContexts(
<svg>
<Visualizer template={template} />
</svg>
);
});
wrapper.update();
expect(wrapper.find('VisualizerStartScreen')).toHaveLength(1);
expect(
wrapper.find('ActionButton#visualizer-toggle-tools').props().isDisabled
).toBe(true);
expect(
wrapper.find('ActionButton#visualizer-toggle-legend').props().isDisabled
).toBe(true);
});
test('Error shown to user when error thrown fetching workflow nodes', async () => {
WorkflowJobTemplatesAPI.readNodes.mockRejectedValue(new Error());
await act(async () => {

7
awx/ui_next/src/screens/Template/WorkflowJobTemplateVisualizer/VisualizerToolbar.jsx
View File

@ -39,6 +39,7 @@ const ActionButton = styled(Button)`
color: white;
}
`;
ActionButton.displayName = 'ActionButton';
function VisualizerToolbar({ i18n, onClose, onSave, template }) {
const dispatch = useContext(WorkflowDispatchContext);
@ -62,7 +63,8 @@ function VisualizerToolbar({ i18n, onClose, onSave, template }) {
<Tooltip content={i18n._(t`Toggle Legend`)} position="bottom">
<ActionButton
id="visualizer-toggle-legend"
isActive={showLegend}
isActive={totalNodes > 0 && showLegend}
isDisabled={totalNodes === 0}
onClick={() => dispatch({ type: 'TOGGLE_LEGEND' })}
variant="plain"
>
@ -72,7 +74,8 @@ function VisualizerToolbar({ i18n, onClose, onSave, template }) {
<Tooltip content={i18n._(t`Toggle Tools`)} position="bottom">
<ActionButton
id="visualizer-toggle-tools"
isActive={showTools}
isActive={totalNodes > 0 && showTools}
isDisabled={totalNodes === 0}
onClick={() => dispatch({ type: 'TOGGLE_TOOLS' })}
variant="plain"
>