Merge pull request #10402 from AlexSCorey/10350-TeamAddLoop

Stops infinte REST calls on ResourcesAccessAdd workflow

SUMMARY
resolves #10350
There is no functionality changes, I just moved the location of the variables so they are defined outside of the component.
E2E test triggered
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

UI

Reviewed-by: Kersom <None>
Reviewed-by: Jake McDermott <yo@jakemcdermott.me>
Reviewed-by: Tiago Góes <tiago.goes2009@gmail.com>
This commit is contained in:
softwarefactory-project-zuul[bot]
2021-06-09 15:33:11 +00:00
committed by GitHub

View File

@@ -17,6 +17,57 @@ const readTeams = async queryParams => TeamsAPI.read(queryParams);
const readTeamsOptions = async () => TeamsAPI.readOptions();
const userSearchColumns = [
{
name: t`Username`,
key: 'username__icontains',
isDefault: true,
},
{
name: t`First Name`,
key: 'first_name__icontains',
},
{
name: t`Last Name`,
key: 'last_name__icontains',
},
];
const userSortColumns = [
{
name: t`Username`,
key: 'username',
},
{
name: t`First Name`,
key: 'first_name',
},
{
name: t`Last Name`,
key: 'last_name',
},
];
const teamSearchColumns = [
{
name: t`Name`,
key: 'name',
isDefault: true,
},
{
name: t`Created By (Username)`,
key: 'created_by__username',
},
{
name: t`Modified By (Username)`,
key: 'modified_by__username',
},
];
const teamSortColumns = [
{
name: t`Name`,
key: 'name',
},
];
function AddResourceRole({ onSave, onClose, roles, resource, onError }) {
const history = useHistory();
@@ -119,58 +170,6 @@ function AddResourceRole({ onSave, onClose, roles, resource, onError }) {
});
}
const userSearchColumns = [
{
name: t`Username`,
key: 'username__icontains',
isDefault: true,
},
{
name: t`First Name`,
key: 'first_name__icontains',
},
{
name: t`Last Name`,
key: 'last_name__icontains',
},
];
const userSortColumns = [
{
name: t`Username`,
key: 'username',
},
{
name: t`First Name`,
key: 'first_name',
},
{
name: t`Last Name`,
key: 'last_name',
},
];
const teamSearchColumns = [
{
name: t`Name`,
key: 'name',
isDefault: true,
},
{
name: t`Created By (Username)`,
key: 'created_by__username',
},
{
name: t`Modified By (Username)`,
key: 'modified_by__username',
},
];
const teamSortColumns = [
{
name: t`Name`,
key: 'name',
},
];
let wizardTitle = '';
switch (selectedResource) {