Merge pull request #2840 from ryanpetrello/project-update-bug

resolve a nuanced traceback for JTs that run w/ a failed project

Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
This commit is contained in:
softwarefactory-project-zuul[bot] 2018-11-29 22:35:59 +00:00 committed by GitHub
commit 4955fc8bc4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1413,6 +1413,11 @@ class RunJob(BaseTask):
def final_run_hook(self, job, status, **kwargs):
super(RunJob, self).final_run_hook(job, status, **kwargs)
if 'private_data_dir' not in kwargs:
# If there's no private data dir, that means we didn't get into the
# actual `run()` call; this _usually_ means something failed in
# the pre_run_hook method
return
if job.use_fact_cache:
job.finish_job_fact_cache(
kwargs['private_data_dir'],