External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-01-12 02:19:58 -03:30
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6624 from marshmalien/6608-project-lookup-bug

Browse Source 
Prevent project lookup from firing requests on every render

Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
This commit is contained in:
softwarefactory-project-zuul[bot] 2020-04-07 15:53:07 +00:00 committed by GitHub
commit 508aed67de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
awx/ui_next/src/screens/Template/shared/JobTemplateForm.jsx
View File

@ -103,6 +103,7 @@ function JobTemplateForm({
}
}, [template, validateField])
);
const {
request: loadRelatedInstanceGroups,
error: instanceGroupError,
@ -143,7 +144,7 @@ function JobTemplateForm({
playbookHelpers.setValue(0);
scmHelpers.setValue('');
},
[setProject, projectHelpers, playbookHelpers, scmHelpers]
[] // eslint-disable-line react-hooks/exhaustive-deps
);
const jobTypeOptions = [
@ -289,7 +290,7 @@ function JobTemplateForm({
/>
<PlaybookSelect
projectId={project?.id || projectField.value?.id}
isValid={!(playbookMeta.touched || playbookMeta.error)}
isValid={!playbookMeta.touched || !playbookMeta.error}
field={playbookField}
onBlur={() => playbookHelpers.setTouched()}
onError={setContentError}