External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-03-03 01:38:50 -03:30
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6624 from marshmalien/6608-project-lookup-bug

Browse Source 
Prevent project lookup from firing requests on every render

Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
This commit is contained in:
softwarefactory-project-zuul[bot]
2020-04-07 15:53:07 +00:00
committed by GitHub
parent d40143a63d c2ba495824
commit 508aed67de
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
awx/ui_next/src/screens/Template/shared/JobTemplateForm.jsx
View File

@@ -103,6 +103,7 @@ function JobTemplateForm({
} }
}, [template, validateField]) }, [template, validateField])
); );
const { const {
request: loadRelatedInstanceGroups, request: loadRelatedInstanceGroups,
error: instanceGroupError, error: instanceGroupError,
@@ -143,7 +144,7 @@ function JobTemplateForm({
playbookHelpers.setValue(0); playbookHelpers.setValue(0);
scmHelpers.setValue(''); scmHelpers.setValue('');
}, },
[setProject, projectHelpers, playbookHelpers, scmHelpers] [] // eslint-disable-line react-hooks/exhaustive-deps
); );
const jobTypeOptions = [ const jobTypeOptions = [
@@ -289,7 +290,7 @@ function JobTemplateForm({
/> />
<PlaybookSelect <PlaybookSelect
projectId={project?.id || projectField.value?.id} projectId={project?.id || projectField.value?.id}
isValid={!(playbookMeta.touched || playbookMeta.error)} isValid={!playbookMeta.touched || !playbookMeta.error}
field={playbookField} field={playbookField}
onBlur={() => playbookHelpers.setTouched()} onBlur={() => playbookHelpers.setTouched()}
onError={setContentError} onError={setContentError}