Kill eager unbind on window resize event

This severly breaks any window resize bindings in directives. That is
double plus bad. I made the executive decision to remove them because
they exist for cleanup that should be done already, assuming we are
following good practices. We aren't yet, so it _could_ cause some
problems, but not likely. I've already pinged @jlaska to keep an eye on
resizing behavior & memory usage in his testing.
This commit is contained in:
Joe Fiorini
2015-01-26 13:08:55 -05:00
parent 7ddb695afc
commit 6046419e2d
3 changed files with 3 additions and 7 deletions

View File

@@ -49,7 +49,6 @@ angular.module('Utilities', ['RestServices', 'Utilities'])
} catch (e) {
// ignore
}
$(window).unbind('resize');
};
}])
@@ -859,4 +858,4 @@ angular.module('Utilities', ['RestServices', 'Utilities'])
};
}
]);
]);

View File

@@ -223,8 +223,6 @@ angular.module('FormGenerator', ['GeneratorHelpers', 'Utilities', 'ListGenerator
$(this).remove();
});
$(window).unbind('resize');
// Prepend an asterisk to required field label
$('.form-control[required], input[type="radio"][required]').each(function () {
var label, span;
@@ -1656,4 +1654,4 @@ angular.module('FormGenerator', ['GeneratorHelpers', 'Utilities', 'ListGenerator
}
};
}
]);
]);

View File

@@ -186,7 +186,6 @@ angular.module('ListGenerator', ['GeneratorHelpers'])
// remove lingering popover <div>. Seems to be a bug in TB3 RC1
$(this).remove();
});
$(window).unbind('resize');
try {
$('#help-modal').empty().dialog('destroy');
@@ -582,4 +581,4 @@ angular.module('ListGenerator', ['GeneratorHelpers'])
return html;
}
};
}]);
}]);